* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-28 13:53 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2015-01-28 13:53 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Rob Herring, Krzysztof Halasa, linux-arm-kernel, linux-pci
The recent patch to convert the cns3xxx PCI code added an
extraneous opening bracket, which makes the build fail,
so remove this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
---
Hi Bjorn,
The broken patch just showed up in linux-next. Please apply this one on top,
or fold it into the original patch if you don't mind rebasing.
diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
index e41fc339d100..c622c306c390 100644
--- a/arch/arm/mach-cns3xxx/pcie.c
+++ b/arch/arm/mach-cns3xxx/pcie.c
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
* for a PCIe bridge. So we must fixup the class code
* to 0x604 here.
*/
- *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+ *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
return ret;
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-28 13:53 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2015-01-28 13:53 UTC (permalink / raw)
To: linux-arm-kernel
The recent patch to convert the cns3xxx PCI code added an
extraneous opening bracket, which makes the build fail,
so remove this.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
---
Hi Bjorn,
The broken patch just showed up in linux-next. Please apply this one on top,
or fold it into the original patch if you don't mind rebasing.
diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
index e41fc339d100..c622c306c390 100644
--- a/arch/arm/mach-cns3xxx/pcie.c
+++ b/arch/arm/mach-cns3xxx/pcie.c
@@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
* for a PCIe bridge. So we must fixup the class code
* to 0x604 here.
*/
- *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
+ *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
return ret;
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
2015-01-28 13:53 ` Arnd Bergmann
@ 2015-01-28 15:17 ` Bjorn Helgaas
-1 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2015-01-28 15:17 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Rob Herring, Krzysztof Halasa, linux-arm-kernel, linux-pci
On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
> ---
>
> Hi Bjorn,
>
> The broken patch just showed up in linux-next. Please apply this one on top,
> or fold it into the original patch if you don't mind rebasing.
I folded it in, thanks! I guess Fengguang's autobuilder must not build
this config, because I got a success report from it.
> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
> index e41fc339d100..c622c306c390 100644
> --- a/arch/arm/mach-cns3xxx/pcie.c
> +++ b/arch/arm/mach-cns3xxx/pcie.c
> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
> * for a PCIe bridge. So we must fixup the class code
> * to 0x604 here.
> */
> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>
> return ret;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-28 15:17 ` Bjorn Helgaas
0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2015-01-28 15:17 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
> ---
>
> Hi Bjorn,
>
> The broken patch just showed up in linux-next. Please apply this one on top,
> or fold it into the original patch if you don't mind rebasing.
I folded it in, thanks! I guess Fengguang's autobuilder must not build
this config, because I got a success report from it.
> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
> index e41fc339d100..c622c306c390 100644
> --- a/arch/arm/mach-cns3xxx/pcie.c
> +++ b/arch/arm/mach-cns3xxx/pcie.c
> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
> * for a PCIe bridge. So we must fixup the class code
> * to 0x604 here.
> */
> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>
> return ret;
> }
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
2015-01-28 15:17 ` Bjorn Helgaas
@ 2015-01-28 15:34 ` Rob Herring
-1 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2015-01-28 15:34 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Arnd Bergmann, Krzysztof Halasa, linux-arm-kernel, linux-pci
On Wed, Jan 28, 2015 at 9:17 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
>> The recent patch to convert the cns3xxx PCI code added an
>> extraneous opening bracket, which makes the build fail,
>> so remove this.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
>> ---
>>
>> Hi Bjorn,
>>
>> The broken patch just showed up in linux-next. Please apply this one on top,
>> or fold it into the original patch if you don't mind rebasing.
>
> I folded it in, thanks! I guess Fengguang's autobuilder must not build
> this config, because I got a success report from it.
Sorry about this. I had fixed this in my tree, but forgot to send out
the update. I've double checked and this was the only fix I had.
How do you get success reports? I only ever get failures.
Rob
>
>> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
>> index e41fc339d100..c622c306c390 100644
>> --- a/arch/arm/mach-cns3xxx/pcie.c
>> +++ b/arch/arm/mach-cns3xxx/pcie.c
>> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>> * for a PCIe bridge. So we must fixup the class code
>> * to 0x604 here.
>> */
>> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>
>> return ret;
>> }
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-28 15:34 ` Rob Herring
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2015-01-28 15:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 28, 2015 at 9:17 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
>> The recent patch to convert the cns3xxx PCI code added an
>> extraneous opening bracket, which makes the build fail,
>> so remove this.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
>> ---
>>
>> Hi Bjorn,
>>
>> The broken patch just showed up in linux-next. Please apply this one on top,
>> or fold it into the original patch if you don't mind rebasing.
>
> I folded it in, thanks! I guess Fengguang's autobuilder must not build
> this config, because I got a success report from it.
Sorry about this. I had fixed this in my tree, but forgot to send out
the update. I've double checked and this was the only fix I had.
How do you get success reports? I only ever get failures.
Rob
>
>> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
>> index e41fc339d100..c622c306c390 100644
>> --- a/arch/arm/mach-cns3xxx/pcie.c
>> +++ b/arch/arm/mach-cns3xxx/pcie.c
>> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>> * for a PCIe bridge. So we must fixup the class code
>> * to 0x604 here.
>> */
>> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>
>> return ret;
>> }
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
2015-01-28 15:34 ` Rob Herring
@ 2015-01-28 15:38 ` Bjorn Helgaas
-1 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2015-01-28 15:38 UTC (permalink / raw)
To: Rob Herring, Wu Fengguang
Cc: Arnd Bergmann, Krzysztof Halasa, linux-arm-kernel, linux-pci
[+cc Fengguang]
On Wed, Jan 28, 2015 at 9:34 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jan 28, 2015 at 9:17 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
>>> The recent patch to convert the cns3xxx PCI code added an
>>> extraneous opening bracket, which makes the build fail,
>>> so remove this.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
>>> ---
>>>
>>> Hi Bjorn,
>>>
>>> The broken patch just showed up in linux-next. Please apply this one on top,
>>> or fold it into the original patch if you don't mind rebasing.
>>
>> I folded it in, thanks! I guess Fengguang's autobuilder must not build
>> this config, because I got a success report from it.
>
> Sorry about this. I had fixed this in my tree, but forgot to send out
> the update. I've double checked and this was the only fix I had.
>
> How do you get success reports? I only ever get failures.
I think Fengguang has it set up so success reports only go to the
owner of the tree, while failure reports go to the owner + people
related to the patch, e.g., maybe people in the signed-off-by list? I
don't know whether that's configurable, or whether you'd even want to
see all the success reports from my tree :)
Bjorn
>>> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
>>> index e41fc339d100..c622c306c390 100644
>>> --- a/arch/arm/mach-cns3xxx/pcie.c
>>> +++ b/arch/arm/mach-cns3xxx/pcie.c
>>> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>>> * for a PCIe bridge. So we must fixup the class code
>>> * to 0x604 here.
>>> */
>>> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>>
>>> return ret;
>>> }
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-28 15:38 ` Bjorn Helgaas
0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Helgaas @ 2015-01-28 15:38 UTC (permalink / raw)
To: linux-arm-kernel
[+cc Fengguang]
On Wed, Jan 28, 2015 at 9:34 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jan 28, 2015 at 9:17 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> On Wed, Jan 28, 2015 at 02:53:07PM +0100, Arnd Bergmann wrote:
>>> The recent patch to convert the cns3xxx PCI code added an
>>> extraneous opening bracket, which makes the build fail,
>>> so remove this.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
>>> ---
>>>
>>> Hi Bjorn,
>>>
>>> The broken patch just showed up in linux-next. Please apply this one on top,
>>> or fold it into the original patch if you don't mind rebasing.
>>
>> I folded it in, thanks! I guess Fengguang's autobuilder must not build
>> this config, because I got a success report from it.
>
> Sorry about this. I had fixed this in my tree, but forgot to send out
> the update. I've double checked and this was the only fix I had.
>
> How do you get success reports? I only ever get failures.
I think Fengguang has it set up so success reports only go to the
owner of the tree, while failure reports go to the owner + people
related to the patch, e.g., maybe people in the signed-off-by list? I
don't know whether that's configurable, or whether you'd even want to
see all the success reports from my tree :)
Bjorn
>>> diff --git a/arch/arm/mach-cns3xxx/pcie.c b/arch/arm/mach-cns3xxx/pcie.c
>>> index e41fc339d100..c622c306c390 100644
>>> --- a/arch/arm/mach-cns3xxx/pcie.c
>>> +++ b/arch/arm/mach-cns3xxx/pcie.c
>>> @@ -101,7 +101,7 @@ static int cns3xxx_pci_read_config(struct pci_bus *bus, unsigned int devfn,
>>> * for a PCIe bridge. So we must fixup the class code
>>> * to 0x604 here.
>>> */
>>> - *val = (((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>> + *val = ((((*val << shift) & 0xff) | (0x604 << 16)) >> shift) & mask;
>>>
>>> return ret;
>>> }
>>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
2015-01-28 13:53 ` Arnd Bergmann
@ 2015-01-29 6:37 ` Krzysztof Hałasa
-1 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Hałasa @ 2015-01-29 6:37 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Bjorn Helgaas, Rob Herring, linux-arm-kernel, linux-pci
Arnd Bergmann <arnd@arndb.de> writes:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: cns3xxx: fix typo in PCI config accessor
@ 2015-01-29 6:37 ` Krzysztof Hałasa
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Hałasa @ 2015-01-29 6:37 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The recent patch to convert the cns3xxx PCI code added an
> extraneous opening bracket, which makes the build fail,
> so remove this.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 10e2c5540d48 ("ARM: cns3xxx: Convert PCI to use generic config accessors")
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-29 6:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 13:53 [PATCH] ARM: cns3xxx: fix typo in PCI config accessor Arnd Bergmann
2015-01-28 13:53 ` Arnd Bergmann
2015-01-28 15:17 ` Bjorn Helgaas
2015-01-28 15:17 ` Bjorn Helgaas
2015-01-28 15:34 ` Rob Herring
2015-01-28 15:34 ` Rob Herring
2015-01-28 15:38 ` Bjorn Helgaas
2015-01-28 15:38 ` Bjorn Helgaas
2015-01-29 6:37 ` Krzysztof Hałasa
2015-01-29 6:37 ` Krzysztof Hałasa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.