From: Marc-Christian Petersen <m.c.p@wolk-project.de>
To: Andrew Morton <akpm@osdl.org>,
Thomas Schlichter <schlicht@uni-mannheim.de>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.74-mm3
Date: Wed, 9 Jul 2003 11:38:07 +0200 [thread overview]
Message-ID: <200307091138.07580.m.c.p@wolk-project.de> (raw)
In-Reply-To: <20030709021849.31eb3aec.akpm@osdl.org>
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
On Wednesday 09 July 2003 11:18, Andrew Morton wrote:
Hi Andrew,
> > arch/i386/kernel/apm.c: In function `apm_bios_call':
> > arch/i386/kernel/apm.c:600: error: incompatible types in assignment
> > arch/i386/kernel/apm.c: In function `apm_bios_call_simple':
> > arch/i386/kernel/apm.c:643: error: incompatible types in assignment
> > The attached patch fixes this...
> Seems complex. I just have this:
>
>
> diff -puN arch/i386/kernel/apm.c~cpumask-apm-fix-2 arch/i386/kernel/apm.c
> --- 25/arch/i386/kernel/apm.c~cpumask-apm-fix-2 2003-07-08
> 23:09:23.000000000 -0700 +++ 25-akpm/arch/i386/kernel/apm.c 2003-07-08
> 23:28:50.000000000 -0700 @@ -528,7 +528,7 @@ static inline void
> apm_restore_cpus(cpum
> * No CPU lockdown needed on a uniprocessor
> */
>
> -#define apm_save_cpus() 0
> +#define apm_save_cpus() CPU_MASK_NONE
> #define apm_restore_cpus(x) (void)(x)
>
> #endif
>
better use the attached one ;)
ciao, Marc
[-- Attachment #2: 15_fixup-apm-small.patch --]
[-- Type: text/x-diff, Size: 640 bytes --]
diff -puN arch/i386/kernel/apm.c~cpumask-apm-fix-2 arch/i386/kernel/apm.c
--- 25/arch/i386/kernel/apm.c~cpumask-apm-fix-2 2003-07-08 23:09:23.000000000 -0700
+++ 25-akpm/arch/i386/kernel/apm.c 2003-07-08 23:28:50.000000000 -0700
@@ -222,6 +222,7 @@
#include <linux/kernel.h>
#include <linux/smp.h>
#include <linux/smp_lock.h>
+#include <linux/cpumask.h>
#include <asm/system.h>
#include <asm/uaccess.h>
@@ -528,7 +529,7 @@ static inline void apm_restore_cpus(cpum
* No CPU lockdown needed on a uniprocessor
*/
-#define apm_save_cpus() 0
+#define apm_save_cpus() CPU_MASK_NONE
#define apm_restore_cpus(x) (void)(x)
#endif
next prev parent reply other threads:[~2003-07-09 9:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 5:35 2.5.74-mm3 Andrew Morton
2003-07-09 5:35 ` 2.5.74-mm3 Andrew Morton
2003-07-09 9:05 ` 2.5.74-mm3 Thomas Schlichter
2003-07-09 9:18 ` 2.5.74-mm3 Andrew Morton
2003-07-09 9:18 ` 2.5.74-mm3 Andrew Morton
2003-07-09 9:25 ` 2.5.74-mm3 Thomas Schlichter
2003-07-09 9:25 ` 2.5.74-mm3 Thomas Schlichter
2003-07-09 9:38 ` Marc-Christian Petersen [this message]
2003-07-09 11:23 ` 2.5.74-mm3 Jan De Luyck
2003-07-09 11:23 ` 2.5.74-mm3 Jan De Luyck
2003-07-09 13:23 ` 2.5.74-mm3 Ramón Rey Vicente
2003-07-10 5:44 ` 2.5.74-mm3 - apm_save_cpus() Macro still bombs out Piet Delaney
2003-07-10 5:44 ` Piet Delaney
2003-07-10 6:08 ` William Lee Irwin III
2003-07-10 6:08 ` William Lee Irwin III
2003-07-10 7:10 ` William Lee Irwin III
2003-07-10 7:10 ` William Lee Irwin III
2003-07-10 7:18 ` Andrew Morton
2003-07-10 7:18 ` Andrew Morton
2003-07-10 7:59 ` William Lee Irwin III
2003-07-10 7:59 ` William Lee Irwin III
2003-07-10 4:09 ` hptraid.o -- No array found? Seth Chromick
2003-07-10 12:20 ` Alan Cox
2003-07-10 8:15 ` 2.5.74-mm3 - module-init-tools: necessary to replace root copies? Piet Delaney
2003-07-10 8:15 ` Piet Delaney
2003-07-10 8:15 ` Piet Delaney
2003-07-10 8:15 ` Piet Delaney
2003-07-10 8:23 ` Andrew Morton
2003-07-10 8:23 ` Andrew Morton
2003-07-10 9:22 ` 2.5.74-mm3 - apm_save_cpus() Macro still bombs out Thomas Schlichter
2003-07-10 9:22 ` Thomas Schlichter
2003-07-10 9:27 ` William Lee Irwin III
2003-07-10 9:27 ` William Lee Irwin III
2003-07-10 9:42 ` Thomas Schlichter
2003-07-10 9:42 ` Thomas Schlichter
2003-07-10 9:48 ` William Lee Irwin III
2003-07-10 9:48 ` William Lee Irwin III
2003-07-10 9:59 ` Thomas Schlichter
2003-07-10 9:59 ` Thomas Schlichter
2003-07-10 10:30 ` William Lee Irwin III
2003-07-10 10:30 ` William Lee Irwin III
2003-07-10 10:49 ` Thomas Schlichter
2003-07-10 10:49 ` Thomas Schlichter
2003-07-11 14:56 ` Matt Mackall
2003-07-11 14:56 ` Matt Mackall
2003-07-09 9:24 ` 2.5.74-mm3 Matt Mackall
2003-07-09 9:24 ` 2.5.74-mm3 Matt Mackall
2003-07-09 9:29 ` 2.5.74-mm3 William Lee Irwin III
2003-07-09 9:29 ` 2.5.74-mm3 William Lee Irwin III
2003-07-10 18:21 ` 2.5.74-mm3 Valdis.Kletnieks
2003-07-11 8:25 ` 2.5.74-mm3 Joe Thornber
2003-07-11 8:25 ` 2.5.74-mm3 Joe Thornber
2003-07-11 16:02 ` 2.5.74-mm3 Anton Blanchard
2003-07-11 16:02 ` 2.5.74-mm3 Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307091138.07580.m.c.p@wolk-project.de \
--to=m.c.p@wolk-project.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.