All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@sistina.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.74-mm3
Date: Fri, 11 Jul 2003 09:25:32 +0100	[thread overview]
Message-ID: <20030711082532.GA432@fib011235813.fsnet.co.uk> (raw)
In-Reply-To: <200307101821.h6AIL87u013299@turing-police.cc.vt.edu>

On Thu, Jul 10, 2003 at 02:21:08PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 08 Jul 2003 22:35:48 PDT, Andrew Morton <akpm@osdl.org>  said:
> 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.74/2.5.74-mm3/
> 
> OK, I'm finally getting around to actually commenting, this has been a niggling issue for
> a while...
> 
> > All 113 patches:
> 
> > 64-bit-dev_t-kdev_t.patch
> >   64-bit dev_t and kdev_t
> 
> Yes, this patch says "not ready for prime time, it breaks things".
> 
> In particular, this gives the device-mapper userspace indigestion, because the
> ioctl passes something other than a 64-bit kdev_t in from libdevmapper. Upshot
> is that the LVM2 'vgchange -ay' fails gloriously.
> 
> Workaround:  Compile the devmapper/LVM stuff with a private copy of include/
> linux/kdev_t.h that matches the one the kernel uses.  No, I didn't actually get
> that to work, so I backed out the 64-bit patch...
> 
> (And no, the recent devmapper/LVM2 stuff posted doesn't fix this).

The v1 ioctl interface passes the dev in as a __kernel_dev_t, so
unfortunately if you change the size of __kernel_dev_t you will have
to rebuild the tools.

The v4 ioctl interface just uses a __u64 which I hope will be future
proof.

- Joe

WARNING: multiple messages have this Message-ID (diff)
From: Joe Thornber <thornber@sistina.com>
To: Valdis.Kletnieks@vt.edu
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.74-mm3
Date: Fri, 11 Jul 2003 09:25:32 +0100	[thread overview]
Message-ID: <20030711082532.GA432@fib011235813.fsnet.co.uk> (raw)
In-Reply-To: <200307101821.h6AIL87u013299@turing-police.cc.vt.edu>

On Thu, Jul 10, 2003 at 02:21:08PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Tue, 08 Jul 2003 22:35:48 PDT, Andrew Morton <akpm@osdl.org>  said:
> 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.5/2.5.74/2.5.74-mm3/
> 
> OK, I'm finally getting around to actually commenting, this has been a niggling issue for
> a while...
> 
> > All 113 patches:
> 
> > 64-bit-dev_t-kdev_t.patch
> >   64-bit dev_t and kdev_t
> 
> Yes, this patch says "not ready for prime time, it breaks things".
> 
> In particular, this gives the device-mapper userspace indigestion, because the
> ioctl passes something other than a 64-bit kdev_t in from libdevmapper. Upshot
> is that the LVM2 'vgchange -ay' fails gloriously.
> 
> Workaround:  Compile the devmapper/LVM stuff with a private copy of include/
> linux/kdev_t.h that matches the one the kernel uses.  No, I didn't actually get
> that to work, so I backed out the 64-bit patch...
> 
> (And no, the recent devmapper/LVM2 stuff posted doesn't fix this).

The v1 ioctl interface passes the dev in as a __kernel_dev_t, so
unfortunately if you change the size of __kernel_dev_t you will have
to rebuild the tools.

The v4 ioctl interface just uses a __u64 which I hope will be future
proof.

- Joe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2003-07-11  8:11 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-09  5:35 2.5.74-mm3 Andrew Morton
2003-07-09  5:35 ` 2.5.74-mm3 Andrew Morton
2003-07-09  9:05 ` 2.5.74-mm3 Thomas Schlichter
2003-07-09  9:18   ` 2.5.74-mm3 Andrew Morton
2003-07-09  9:18     ` 2.5.74-mm3 Andrew Morton
2003-07-09  9:25     ` 2.5.74-mm3 Thomas Schlichter
2003-07-09  9:25       ` 2.5.74-mm3 Thomas Schlichter
2003-07-09  9:38     ` 2.5.74-mm3 Marc-Christian Petersen
2003-07-09 11:23       ` 2.5.74-mm3 Jan De Luyck
2003-07-09 11:23         ` 2.5.74-mm3 Jan De Luyck
2003-07-09 13:23       ` 2.5.74-mm3 Ramón Rey Vicente󮠒
2003-07-10  5:44     ` 2.5.74-mm3 - apm_save_cpus() Macro still bombs out Piet Delaney
2003-07-10  5:44       ` Piet Delaney
2003-07-10  6:08       ` William Lee Irwin III
2003-07-10  6:08         ` William Lee Irwin III
2003-07-10  7:10         ` William Lee Irwin III
2003-07-10  7:10           ` William Lee Irwin III
2003-07-10  7:18           ` Andrew Morton
2003-07-10  7:18             ` Andrew Morton
2003-07-10  7:59             ` William Lee Irwin III
2003-07-10  7:59               ` William Lee Irwin III
2003-07-10  4:09               ` hptraid.o -- No array found? Seth Chromick
2003-07-10 12:20                 ` Alan Cox
2003-07-10  8:15             ` 2.5.74-mm3 - module-init-tools: necessary to replace root copies? Piet Delaney
2003-07-10  8:15               ` Piet Delaney
2003-07-10  8:15             ` Piet Delaney
2003-07-10  8:15               ` Piet Delaney
2003-07-10  8:23               ` Andrew Morton
2003-07-10  8:23                 ` Andrew Morton
2003-07-10  9:22       ` 2.5.74-mm3 - apm_save_cpus() Macro still bombs out Thomas Schlichter
2003-07-10  9:22         ` Thomas Schlichter
2003-07-10  9:27         ` William Lee Irwin III
2003-07-10  9:27           ` William Lee Irwin III
2003-07-10  9:42           ` Thomas Schlichter
2003-07-10  9:42             ` Thomas Schlichter
2003-07-10  9:48             ` William Lee Irwin III
2003-07-10  9:48               ` William Lee Irwin III
2003-07-10  9:59               ` Thomas Schlichter
2003-07-10  9:59                 ` Thomas Schlichter
2003-07-10 10:30                 ` William Lee Irwin III
2003-07-10 10:30                   ` William Lee Irwin III
2003-07-10 10:49                   ` Thomas Schlichter
2003-07-10 10:49                     ` Thomas Schlichter
2003-07-11 14:56                   ` Matt Mackall
2003-07-11 14:56                     ` Matt Mackall
2003-07-09  9:24 ` 2.5.74-mm3 Matt Mackall
2003-07-09  9:24   ` 2.5.74-mm3 Matt Mackall
2003-07-09  9:29   ` 2.5.74-mm3 William Lee Irwin III
2003-07-09  9:29     ` 2.5.74-mm3 William Lee Irwin III
2003-07-10 18:21 ` 2.5.74-mm3 Valdis.Kletnieks
2003-07-11  8:25   ` Joe Thornber [this message]
2003-07-11  8:25     ` 2.5.74-mm3 Joe Thornber
2003-07-11 16:02     ` 2.5.74-mm3 Anton Blanchard
2003-07-11 16:02       ` 2.5.74-mm3 Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030711082532.GA432@fib011235813.fsnet.co.uk \
    --to=thornber@sistina.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.