Whatever happened to write_super_lockfs?

Whatever happened to write_super_lockfs?

[Matthew Wilcox]

$ find -type f |xargs grep write_super_lockfs
./fs/ext3/super.c:      .write_super_lockfs = ext3_write_super_lockfs,
./fs/ext3/super.c:void ext3_write_super_lockfs(struct super_block *sb)
./fs/jfs/super.c:static void jfs_write_super_lockfs(struct super_block *sb)
./fs/jfs/super.c:       .write_super_lockfs = jfs_write_super_lockfs,
./fs/ntfs/super.c:      //write_super_lockfs    = NULL,   /* ? */
./fs/reiserfs/super.c:static void reiserfs_write_super_lockfs (struct super_block * s)
./fs/reiserfs/super.c:  .write_super_lockfs = reiserfs_write_super_lockfs,
./fs/xfs/linux/xfs_super.c:     .write_super_lockfs     = linvfs_freeze_fs,
./include/linux/ext3_fs.h:extern void ext3_write_super_lockfs (struct super_block *);
./include/linux/fs.h:   void (*write_super_lockfs) (struct super_block *);

Should we just delete that code now?

(Ditto unlockfs, btw:

$ find -type f |xargs grep unlockfs |grep -v ^Binary
./fs/ext3/super.c:      .unlockfs       = ext3_unlockfs,
./fs/ext3/super.c:void ext3_unlockfs(struct super_block *sb)
./fs/jfs/super.c:static void jfs_unlockfs(struct super_block *sb)
./fs/jfs/super.c:       .unlockfs       = jfs_unlockfs,
./fs/ntfs/super.c:      //unlockfs      = NULL,           /* ? */
./fs/reiserfs/super.c:void reiserfs_unlockfs(struct super_block *s) {
./fs/reiserfs/super.c:  .unlockfs = reiserfs_unlockfs,
./fs/xfs/linux/xfs_super.c:     .unlockfs               = linvfs_unfreeze_fs,
./include/linux/ext3_fs.h:extern void ext3_unlockfs (struct super_block *);
./include/linux/fs.h:   void (*unlockfs) (struct super_block *);
)

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: Whatever happened to write_super_lockfs?

[Andreas Dilger]

On Jul 18, 2003  21:39 +0100, Matthew Wilcox wrote:
> $ find -type f |xargs grep write_super_lockfs
> ./fs/ext3/super.c:      .write_super_lockfs = ext3_write_super_lockfs,
> ./fs/ext3/super.c:void ext3_write_super_lockfs(struct super_block *sb)
> ./fs/jfs/super.c:static void jfs_write_super_lockfs(struct super_block *sb)
> ./fs/jfs/super.c:       .write_super_lockfs = jfs_write_super_lockfs,
> ./fs/ntfs/super.c:      //write_super_lockfs    = NULL,   /* ? */
> ./fs/reiserfs/super.c:static void reiserfs_write_super_lockfs (struct super_block * s)
> ./fs/reiserfs/super.c:  .write_super_lockfs = reiserfs_write_super_lockfs,
> ./fs/xfs/linux/xfs_super.c:     .write_super_lockfs     = linvfs_freeze_fs,
> ./include/linux/ext3_fs.h:extern void ext3_write_super_lockfs (struct super_block *);
> ./include/linux/fs.h:   void (*write_super_lockfs) (struct super_block *);
> 
> Should we just delete that code now?
> 
> (Ditto unlockfs, btw:
> 
> $ find -type f |xargs grep unlockfs |grep -v ^Binary
> ./fs/ext3/super.c:      .unlockfs       = ext3_unlockfs,
> ./fs/ext3/super.c:void ext3_unlockfs(struct super_block *sb)
> ./fs/jfs/super.c:static void jfs_unlockfs(struct super_block *sb)
> ./fs/jfs/super.c:       .unlockfs       = jfs_unlockfs,
> ./fs/ntfs/super.c:      //unlockfs      = NULL,           /* ? */
> ./fs/reiserfs/super.c:void reiserfs_unlockfs(struct super_block *s) {
> ./fs/reiserfs/super.c:  .unlockfs = reiserfs_unlockfs,
> ./fs/xfs/linux/xfs_super.c:     .unlockfs               = linvfs_unfreeze_fs,
> ./include/linux/ext3_fs.h:extern void ext3_unlockfs (struct super_block *);
> ./include/linux/fs.h:   void (*unlockfs) (struct super_block *);
> )

No.  I've been trying to get Chris Mason to submit the (very small) code
into the kernel for a long time now.  It is needed for LVM and EVMS snapshots.
The inclusion is being slowed down by the lack of Viro.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

Re: Whatever happened to write_super_lockfs?

[Matthew Wilcox]

On Fri, Jul 18, 2003 at 02:06:51PM -0700, Andreas Dilger wrote:
> No.  I've been trying to get Chris Mason to submit the (very small) code
> into the kernel for a long time now.  It is needed for LVM and EVMS snapshots.
> The inclusion is being slowed down by the lack of Viro.

Can we see the patch so I can document the locking?

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: Whatever happened to write_super_lockfs?

[Andreas Dilger]

On Jul 18, 2003  22:09 +0100, Matthew Wilcox wrote:
> On Fri, Jul 18, 2003 at 02:06:51PM -0700, Andreas Dilger wrote:
> > No.  I've been trying to get Chris Mason to submit the (very small) code
> > into the kernel for a long time now.  It is needed for LVM and EVMS snapshots.
> > The inclusion is being slowed down by the lack of Viro.
> 
> Can we see the patch so I can document the locking?

Chris Mason has posted it to this list in the past (most recent and
not widely tested version maybe 2 months ago).  Older versions are
in the LVM CVS/tarball at sistina.com and in most distro kernels.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/