[parisc-linux] [PATCH] Prevent loopback traffic to be shown on the network leds

[parisc-linux] [PATCH] Prevent loopback traffic to be shown on the network leds

[Rüdiger Scholz]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Hi,

looking at the Download page from the ESIEE-Team I found the following 
patch from Thibaut. It filters the traffic from/to the loopback device, 
so network led isn't blinking when accessing the loopback device. 
Should'nt it go into CVS?

Rüdiger

[-- Attachment #2: led.c-diff --]
[-- Type: text/plain, Size: 882 bytes --]

Index: linux/arch/parisc/kernel/led.c
===================================================================
RCS file: /var/cvs/linux/arch/parisc/kernel/led.c,v
retrieving revision 1.28
diff -u -p -u -r1.28 led.c
--- linux/arch/parisc/kernel/led.c	29 Sep 2002 15:49:20 -0000	1.28
+++ linux/arch/parisc/kernel/led.c	17 Jan 2003 16:02:56 -0000
@@ -365,10 +365,12 @@ static void led_get_net_stats(int addval
 	 * for reading should be OK */
 	read_lock(&dev_base_lock);
 	for (dev = dev_base; dev != NULL; dev = dev->next) {
-	    if (dev->get_stats) { 
-	        stats = dev->get_stats(dev);
-		rx_total += stats->rx_packets;
-		tx_total += stats->tx_packets;
+	    if (!(dev->flags & IFF_LOOPBACK)) {
+		if (dev->get_stats) {
+		    stats = dev->get_stats(dev);
+		    rx_total += stats->rx_packets;
+		    tx_total += stats->tx_packets;
+		}
 	    }
 	}
 	read_unlock(&dev_base_lock);

Re: [parisc-linux] [PATCH] Prevent loopback traffic to be shown on the network leds

[Matthew Wilcox]

On Sat, Jul 19, 2003 at 01:31:41PM +0200, Rüdiger Scholz wrote:
> Hi,
> 
> looking at the Download page from the ESIEE-Team I found the following 
> patch from Thibaut. It filters the traffic from/to the loopback device, 
> so network led isn't blinking when accessing the loopback device. 
> Should'nt it go into CVS?

Seems like a reasonable patch to me.  I'll ask Thibaut about it when
he gets here.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk

Re: [parisc-linux] [PATCH] Prevent loopback traffic to be shown on the network leds

[Thibaut VARENE]

-------------------
> On Sat, Jul 19, 2003 at 01:31:41PM +0200, R=FCdiger Scholz wrote:
> > Hi,
> >=20
> > looking at the Download page from the ESIEE-Team I found the
following=20
> > patch from Thibaut. It filters the traffic from/to the loopback
device,=20
> > so network led isn't blinking when accessing the loopback device.=20
> > Should'nt it go into CVS?
>=20
> Seems like a reasonable patch to me.  I'll ask Thibaut about it when
> he gets here.
>=20

sure, go ahead ;o)

T-Bone, finally getting a (pretty wicked) internet access ;^)