All of lore.kernel.org
 help / color / mirror / Atom feed
* Trivial cosmetic unimportant issue (urgent)
@ 2003-07-23 19:12 Sean
  2003-07-23 20:19 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sean @ 2003-07-23 19:12 UTC (permalink / raw)
  To: netdev

Hi folks,

      Just a few days uptime and sysfs is reporting that i've transfered a _negative_ number of bytes!  Any chance this could be
unsigned output instead?    The display is created in a common net_device_stat_show but none of the others values should go negative
either.

Cheers,
Sean

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Trivial cosmetic unimportant issue (urgent)
  2003-07-23 19:12 Trivial cosmetic unimportant issue (urgent) Sean
@ 2003-07-23 20:19 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-07-23 20:19 UTC (permalink / raw)
  To: Sean; +Cc: netdev

On Wed, 23 Jul 2003 15:12:24 -0400
"Sean" <seanlkml@rogers.com> wrote:

>       Just a few days uptime and sysfs is reporting that i've transfered a _negative_ number of bytes!  Any chance this could be
> unsigned output instead?    The display is created in a common net_device_stat_show but none of the others values should go negative
> either.

This should fix it.

--- net/core/net-sysfs.c.~1~	Wed Jul 23 12:20:15 2003
+++ net/core/net-sysfs.c	Wed Jul 23 12:20:24 2003
@@ -186,7 +186,7 @@
 
 static ssize_t net_device_stat_show(unsigned long var, char *buf)
 {
-	return sprintf(buf, "%ld\n", var);
+	return sprintf(buf, "%lu\n", var);
 }
 
 /* generate a read-only statistics attribute */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-07-23 20:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-23 19:12 Trivial cosmetic unimportant issue (urgent) Sean
2003-07-23 20:19 ` David S. Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.