From: Russell King <rmk@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Lawrence <dgl@integrinautics.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: compact flash IDE hot-swap summary please
Date: Wed, 23 Jul 2003 22:15:25 +0100 [thread overview]
Message-ID: <20030723221525.A3397@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1058991230.5515.126.camel@dhcp22.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Wed, Jul 23, 2003 at 09:13:51PM +0100
On Wed, Jul 23, 2003 at 09:13:51PM +0100, Alan Cox wrote:
> Everyone I know is using the PCMCIA interface stuff for that. Now that
> can support the unplugging but the ide-cs code is still not doing the
> right things in this case (and the core could be a little more careful).
> The ide_unregister can fail - you are supposed to call it again later if
> it does - ide_cs doesnt
Ok, I see a couple of problems here.
Firstly, how does ide_cs in 2.6.0-test1 know that ide_unregister has
failed? In my copy of 2.6.0-test1, it doesn't return any values.
Secondly, 2.4.21 seems to fail with value '1' for two cases:
- the ide interface wasn't found to be present
- the drive is in use
- the shutdown fails
In the first case, we just want to forget all about the interface - we
don't want to retry at some time in the future. In the second case,
well, the device has physically gone, so any outstanding requests are
not going to complete. Hopefully an in-progress request should time
out, but we shouldn't try to start a new request.
Thirdly, we don't change the iops on unregister. Some hardware returns
random garbage to reads from the PCMCIA space when there isn't a card
present.
So, in short, I think that IDE unplug is broken in the core IDE driver
and needs significant work in _both_ 2.4 and 2.6 before we can think
about getting PCMCIA-based IDE cards to work sufficiently well. Yes,
ide-cs.c may need some work, but ide.c also requires work.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2003-07-23 21:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-23 18:11 compact flash IDE hot-swap summary please Dave Lawrence
2003-07-23 18:18 ` Alan Cox
2003-07-23 19:49 ` Russell King
2003-07-23 20:13 ` Alan Cox
2003-07-23 21:15 ` Russell King [this message]
2003-07-23 22:15 ` Alan Cox
2003-08-14 0:21 ` Vojtech Pavlik
2003-07-23 19:12 ` Andre Hedrick
2003-07-23 19:51 ` Russell King
2003-07-23 19:48 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030723221525.A3397@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dgl@integrinautics.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.