dev/core/net_sysfs.c: missing release() function in net_class

dev/core/net_sysfs.c: missing release() function in net_class

[Ville Nuorvala]

Hi,

lately I've been getting a nasty looking warning from class_dev_release()
in drivers/base/class.c when I unregister my ip6_tunnel devices.

The warning (added by Greg Kroah-Hartman in cset 1.1152.2.7) is apparently
triggered because net_class doesn't have .release set.

Would an empty dummy function be enough for net_class or should the
release function actually do something?

Thanks,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257

Re: dev/core/net_sysfs.c: missing release() function in net_class

[David S. Miller]

On Tue, 19 Aug 2003 15:47:03 +0300 (EEST)
Ville Nuorvala <vnuorval@tcs.hut.fi> wrote:

> lately I've been getting a nasty looking warning from class_dev_release()
> in drivers/base/class.c when I unregister my ip6_tunnel devices.

This is fixed in current sources after recent changes
done by Stephen Hemminger.

[PATCH] IPv6: Fix target address for (proxy/anycast) NA

[Ville Nuorvala]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 339 bytes --]

Hi,

the target address in neighbor advertisements must be the solicited
address. Otherwise proxy NAs (and NAs for anycast addresses) don't work.
Please apply!

Thanks,
Ville
--
Ville Nuorvala
Research Assistant, Institute of Digital Communications,
Helsinki University of Technology
email: vnuorval@tcs.hut.fi, phone: +358 (0)9 451 5257


[-- Attachment #2: Type: TEXT/PLAIN, Size: 452 bytes --]

--- linux-2.5.OLD/net/ipv6/ndisc.c	2003-08-20 14:09:13.000000000 +0300
+++ linux-2.5/net/ipv6/ndisc.c	2003-08-20 14:09:28.000000000 +0300
@@ -485,7 +485,7 @@
         msg->icmph.icmp6_override  = !!override;
 
         /* Set the target address. */
-	ipv6_addr_copy(&msg->target, src_addr);
+	ipv6_addr_copy(&msg->target, solicited_addr);
 
 	if (inc_opt)
 		ndisc_fill_option(msg->opt, ND_OPT_TARGET_LL_ADDR, dev->dev_addr, dev->addr_len);

Re: [PATCH] IPv6: Fix target address for (proxy/anycast) NA

[David S. Miller]

On Wed, 20 Aug 2003 14:23:12 +0300 (EEST)
Ville Nuorvala <vnuorval@tcs.hut.fi> wrote:

> the target address in neighbor advertisements must be the solicited
> address. Otherwise proxy NAs (and NAs for anycast addresses) don't work.

Applied, thanks.