* [PATCH] memory leak in irda/sa1100_ir.c
@ 2003-10-09 16:37 Stephen Hemminger
2003-10-10 7:01 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2003-10-09 16:37 UTC (permalink / raw)
To: Jean Tourrilhes, David S. Miller; +Cc: irda-users, netdev
This driver seems confused about what get done for it on module exit.
It needs to free the network device it created.
Patch against 2.6.0-test7
diff -urN -X dontdiff linux-2.5/drivers/net/irda/sa1100_ir.c linux-2.5-net/drivers/net/irda/sa1100_ir.c
--- linux-2.5/drivers/net/irda/sa1100_ir.c 2003-09-30 13:53:58.000000000 -0700
+++ linux-2.5-net/drivers/net/irda/sa1100_ir.c 2003-09-17 15:49:30.000000000 -0700
@@ -1132,12 +1132,8 @@
release_mem_region(__PREG(Ser2HSCR0), 0x1c);
release_mem_region(__PREG(Ser2UTCR0), 0x24);
- /*
- * We now know that the netdevice is no longer in use, and all
- * references to our driver have been removed. The only structure
- * which may still be present is the netdevice, which will get
- * cleaned up by net/core/dev.c
- */
+ if(dev)
+ free_netdev(dev);
}
static int __init sa1100ir_setup(char *line)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] memory leak in irda/sa1100_ir.c
2003-10-09 16:37 [PATCH] memory leak in irda/sa1100_ir.c Stephen Hemminger
@ 2003-10-10 7:01 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-10-10 7:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: jt, irda-users, netdev
On Thu, 9 Oct 2003 09:37:52 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> This driver seems confused about what get done for it on module exit.
> It needs to free the network device it created.
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-10-10 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-09 16:37 [PATCH] memory leak in irda/sa1100_ir.c Stephen Hemminger
2003-10-10 7:01 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.