[PATCH] sysfs -- don't crash if removing non-existant attribute group

[PATCH] sysfs -- don't crash if removing non-existant attribute group

[Stephen Hemminger]

Some (buggy) network drivers in 2.6 decide to set the statistics hook,
after registration. This causes unregister_netdevice to crash because it attempts 
to remove the 'statistics' attribute group it thought was created.  

This fixes sysfs so it ignores the problem.  Another set of patches
will address the remaining buggy ether drivers.

diff -Nru a/fs/sysfs/group.c b/fs/sysfs/group.c
--- a/fs/sysfs/group.c	Mon Oct 13 16:04:31 2003
+++ b/fs/sysfs/group.c	Mon Oct 13 16:04:31 2003
@@ -65,9 +65,11 @@
 {
 	struct dentry * dir;
 
-	if (grp->name)
+	if (grp->name) {
 		dir = sysfs_get_dentry(kobj->dentry,grp->name);
-	else
+		if (dir == NULL)	/* non-existent */
+			return;
+	} else
 		dir = kobj->dentry;
 
 	remove_files(dir,grp);

Re: [PATCH] sysfs -- don't crash if removing non-existant attribute group

[David S. Miller]

On Mon, 13 Oct 2003 16:25:59 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:

> This fixes sysfs so it ignores the problem.  Another set of patches
> will address the remaining buggy ether drivers.

Please change this patch to add a net_ratelimit()'d warning message so
that we can catch new instances of this problem.

Thanks.