Toshiba Satellite 1905S303 DSDT table

Toshiba Satellite 1905S303 DSDT table

[Erico M Mendonca]

I'm currently trying to debug the DSDT table of this aforementioned 
machine, and managed to clear all the errors, except for this one:
=================
Intel ACPI Component Architecture
ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
Copyright (C) 2000 - 2003 Intel Corporation
Supports ACPI Specification Revision 2.0b

s303.asl   468:                 If(\_OSI) {
Error    1028 -      Too few arguments ^  (\_OSI requires 1)

s303.asl   469:                     "Windows 2001"
Error    1037 -                                  ^ parse error, 
unexpected PARSEOP_STRING_LITERAL

ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
==============

I searched around the web and found only one message stating that 
acpidump didn't support the _OSI method yet (late 2002). Did this ever 
got solved?

-- Erico Mendonca
Techisa do Brasil



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Erico M Mendonca]

Erico M Mendonca wrote:

> I'm currently trying to debug the DSDT table of this aforementioned 
> machine, and managed to clear all the errors, except for this one:
> =================
> Intel ACPI Component Architecture
> ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
> Copyright (C) 2000 - 2003 Intel Corporation
> Supports ACPI Specification Revision 2.0b
>
> s303.asl   468:                 If(\_OSI) {
> Error    1028 -      Too few arguments ^  (\_OSI requires 1)
>
> s303.asl   469:                     "Windows 2001"
> Error    1037 -                                  ^ parse error, 
> unexpected PARSEOP_STRING_LITERAL
>
> ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
> Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
> ==============
>
> I searched around the web and found only one message stating that 
> acpidump didn't support the _OSI method yet (late 2002). Did this ever 
> got solved?
>
> -- Erico Mendonca
> Techisa do Brasil
>
>
Replying to myself...

The acpidump code I'm using is from the CVS, downloaded today:
6685 May  1  2003 acpidump.c







-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Ducrot Bruno]

On Sun, Nov 02, 2003 at 09:14:48PM -0200, Erico M Mendonca wrote:
> I'm currently trying to debug the DSDT table of this aforementioned 
> machine, and managed to clear all the errors, except for this one:
> =================
> Intel ACPI Component Architecture
> ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
> Copyright (C) 2000 - 2003 Intel Corporation
> Supports ACPI Specification Revision 2.0b
> 
> s303.asl   468:                 If(\_OSI) {
> Error    1028 -      Too few arguments ^  (\_OSI requires 1)
> 
> s303.asl   469:                     "Windows 2001"
> Error    1037 -                                  ^ parse error, 
> unexpected PARSEOP_STRING_LITERAL
> 
> ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
> Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
> ==============
> 
> I searched around the web and found only one message stating that 
> acpidump didn't support the _OSI method yet (late 2002). Did this ever 
> got solved?
> 

I remember that acpidmp is no more supported, in favor to iasl.
acpidmp is now, under F-BSD, a wrapper for iasl, with some little
goodies, like dumping more infos.  Therefore, I doubt this will
be corrected.

If you want more info, you should search FreeBSD mailing list (I
don't remember the correct one, should be -current IIRC).

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Martin Michlmayr]

* Erico M Mendonca <erico-cz9lu//xMc+vYRxJAoKWRg@public.gmane.org> [2003-11-02 21:14]:
> machine, and managed to clear all the errors, except for this one:

> s303.asl   468:                 If(\_OSI) {
> Error    1028 -      Too few arguments ^  (\_OSI requires 1)
> s303.asl   469:                     "Windows 2001"
> Error    1037 -                                  ^ parse error, 

I managed to fix this error with the following change:

--- dsdt.asl.orig	2003-10-25 18:43:53.000000000 +1000
+++ dsdt.asl	2003-10-25 18:47:02.000000000 +1000
@@ -144,8 +144,7 @@
         }
         If(LOr(LEqual(C006, 0x0), LEqual(C006, 0x3))) {
             If(CondRefOf(\_OSI, Local0)) {
-                If(\_OSI) {
-                    "Windows 2001"
+                If(\_OSI ("Windows 2001")) {
                     Store(0x4, C006)
                 }
             }

This is basically in line with some other DSDTs I've seen on the net.
-- 
Martin Michlmayr
tbm-R+vWnYXSFMfQT0dZR+AlfA@public.gmane.org


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Erico M Mendonca]

Martin Michlmayr wrote:

>* Erico M Mendonca <erico-cz9lu//xMc+vYRxJAoKWRg@public.gmane.org> [2003-11-02 21:14]:
>  
>
>>machine, and managed to clear all the errors, except for this one:
>>    
>>
>
>  
>
>>s303.asl   468:                 If(\_OSI) {
>>Error    1028 -      Too few arguments ^  (\_OSI requires 1)
>>s303.asl   469:                     "Windows 2001"
>>Error    1037 -                                  ^ parse error, 
>>    
>>
>
>I managed to fix this error with the following change:
>
>--- dsdt.asl.orig	2003-10-25 18:43:53.000000000 +1000
>+++ dsdt.asl	2003-10-25 18:47:02.000000000 +1000
>@@ -144,8 +144,7 @@
>         }
>         If(LOr(LEqual(C006, 0x0), LEqual(C006, 0x3))) {
>             If(CondRefOf(\_OSI, Local0)) {
>-                If(\_OSI) {
>-                    "Windows 2001"
>+                If(\_OSI ("Windows 2001")) {
>                     Store(0x4, C006)
>                 }
>             }
>
>This is basically in line with some other DSDTs I've seen on the net.
>  
>

Yesterday I did the same thing :)

Anyway, it did compile ok, I recompiled the kernel and added the fixed 
DSDT table. It worked quite nice, I now also have the power button 
generating the shutdown event.

I still have the fn-F5 panic though. I compiled the kernel with kdb and 
tried to redirect it to the serial console, but alas, this machine does 
not have a serial port, and as far as I have researched, support for USB 
serial adapters as console is available only on kernel 2.5+.

-- 

-- Erico Mendonca
Techisa do Brasil





-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Nate Lawson]

On Mon, 3 Nov 2003, Ducrot Bruno wrote:
> On Sun, Nov 02, 2003 at 09:14:48PM -0200, Erico M Mendonca wrote:
> > I'm currently trying to debug the DSDT table of this aforementioned
> > machine, and managed to clear all the errors, except for this one:
> > =================
> > Intel ACPI Component Architecture
> > ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
> > Copyright (C) 2000 - 2003 Intel Corporation
> > Supports ACPI Specification Revision 2.0b
> >
> > s303.asl   468:                 If(\_OSI) {
> > Error    1028 -      Too few arguments ^  (\_OSI requires 1)
> >
> > s303.asl   469:                     "Windows 2001"
> > Error    1037 -                                  ^ parse error,
> > unexpected PARSEOP_STRING_LITERAL
> >
> > ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
> > Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
> > ==============
> >
> > I searched around the web and found only one message stating that
> > acpidump didn't support the _OSI method yet (late 2002). Did this ever
> > got solved?
>
> I remember that acpidmp is no more supported, in favor to iasl.
> acpidmp is now, under F-BSD, a wrapper for iasl, with some little
> goodies, like dumping more infos.  Therefore, I doubt this will
> be corrected.
>
> If you want more info, you should search FreeBSD mailing list (I
> don't remember the correct one, should be -current IIRC).

I'm the FreeBSD maintainer.  acpidump(8) now just dumps the DSDT to a file
and prints the fixed tables.  It then calls iasl -d to disassemble the
DSDT.  I'm planning to add support for SSDT as well soon.  If anyone from
Linux is looking to port the new acpidump(8), let me know.

-Nate


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Ducrot Bruno]

On Sun, Nov 02, 2003 at 09:14:48PM -0200, Erico M Mendonca wrote:
> I'm currently trying to debug the DSDT table of this aforementioned 
> machine, and managed to clear all the errors, except for this one:
> =================
> Intel ACPI Component Architecture
> ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
> Copyright (C) 2000 - 2003 Intel Corporation
> Supports ACPI Specification Revision 2.0b
> 
> s303.asl   468:                 If(\_OSI) {
> Error    1028 -      Too few arguments ^  (\_OSI requires 1)
> 
> s303.asl   469:                     "Windows 2001"
> Error    1037 -                                  ^ parse error, 
> unexpected PARSEOP_STRING_LITERAL
> 
> ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
> Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
> ==============
> 

FYI I have debugged a *lot* of similar models.  What is the
problem you encounter for that one?


-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Erico M Mendonca]

Ducrot Bruno wrote:

>On Sun, Nov 02, 2003 at 09:14:48PM -0200, Erico M Mendonca wrote:
>  
>
>>I'm currently trying to debug the DSDT table of this aforementioned 
>>machine, and managed to clear all the errors, except for this one:
>>=================
>>Intel ACPI Component Architecture
>>ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
>>Copyright (C) 2000 - 2003 Intel Corporation
>>Supports ACPI Specification Revision 2.0b
>>
>>s303.asl   468:                 If(\_OSI) {
>>Error    1028 -      Too few arguments ^  (\_OSI requires 1)
>>
>>s303.asl   469:                     "Windows 2001"
>>Error    1037 -                                  ^ parse error, 
>>unexpected PARSEOP_STRING_LITERAL
>>
>>ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
>>Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
>>==============
>>
>>    
>>
>
>FYI I have debugged a *lot* of similar models.  What is the
>problem you encounter for that one?
>
>
>  
>
I solved this by changing it to a simple

               If(\_OSI ("Windows 2001")) 

as suggested by Martin earlier.

Anyway, I got the ACPI working fine for most functions, except:
- processor: no throttling (Pentium 4), but that may be out of the scope 
of ACPI(?)

processor id:            0
acpi id:                 0
bus mastering control:   no
power management:        yes
throttling control:      no
performance management:  no
limit interface:         no


- fan control/reporting
- thermal_zone and power_resource


The lid and power buttons are generating events after recompiling the DSDT table (they didn't before). Proper IRQ routing, battery and ac_adapter worked before.


As for the Fn-keys:

Fn-ESC (mute): doesn't work
Fn-F1 (screen lock): doesn't work
Fn-F2 (power toggle): doesn't work
Fn-F3 (suspend to RAM): doesn't work
Fn-F4 (hibernate): doesn't work
Fn-F5 (video switch): hangs the machine (read below)
Fn-F6/F7 (brightness): works
Fn-F8 (wireless toggle): works
Fn-F9 (touchpad toggle): works
Fn-F10/F11/F12: well, they should work anyway :)

I know some of these can be mapped to generate key events and call 
specific user programs. The one big problem I'm having now is with Fn-F5 
(video switch). With an older kernel version (2.4.20) it worked 
flawlessly, but with 2.4.22 (from Mandrake 9.2) it hangs the machine 
solid. I tried setting a serial console to check out any oops/kernel 
panic messages, even tried KDB, but alas, this machine doesn't have a 
serial port.

I searched around and found out that there's an USB serial console 
patch, but for kernel 2.5+.

I'm just beginning with ACPI, so if you have any suggestions on this, 
I'd be glad to hear. I'm still reading the 500+ page tome of the ACPI 
spec... :)

-- 

-- Erico Mendonca
Techisa do Brasil





-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Ducrot Bruno]

On Tue, Nov 04, 2003 at 10:57:08AM -0200, Erico M Mendonca wrote:
> Ducrot Bruno wrote:
> 
> >On Sun, Nov 02, 2003 at 09:14:48PM -0200, Erico M Mendonca wrote:
> > 
> >
> >>I'm currently trying to debug the DSDT table of this aforementioned 
> >>machine, and managed to clear all the errors, except for this one:
> >>=================
> >>Intel ACPI Component Architecture
> >>ASL Optimizing Compiler / AML Disassembler version 20030918 [Sep 18 2003]
> >>Copyright (C) 2000 - 2003 Intel Corporation
> >>Supports ACPI Specification Revision 2.0b
> >>
> >>s303.asl   468:                 If(\_OSI) {
> >>Error    1028 -      Too few arguments ^  (\_OSI requires 1)
> >>
> >>s303.asl   469:                     "Windows 2001"
> >>Error    1037 -                                  ^ parse error, 
> >>unexpected PARSEOP_STRING_LITERAL
> >>
> >>ASL Input:  s303.asl - 2871 lines, 112889 bytes, 2084 keywords
> >>Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 538 Optimizations
> >>==============
> >>
> >>   
> >>
> >
> >FYI I have debugged a *lot* of similar models.  What is the
> >problem you encounter for that one?
> >
> >
> > 
> >
> I solved this by changing it to a simple
> 
>               If(\_OSI ("Windows 2001")) 

As I already tryed to say, unless you are on a BSD system,
or unless someone port the FreeBSD acpidump, do not use acpidump.
Or else, you are missing informations for debugging irq for example.



> Anyway, I got the ACPI working fine for most functions, except:
> - processor: no throttling (Pentium 4), but that may be out of the scope 
> of ACPI(?)

It may be done via ACPI, but cpufreq can do that via p4-clockmod.

> processor id:            0
> acpi id:                 0
> bus mastering control:   no
> power management:        yes
> throttling control:      no
> performance management:  no
> limit interface:         no

performance should work, strange.  Anyway, cpufreq can do that via
speedstep-ich.

> 
> - fan control/reporting
> - thermal_zone and power_resource

A thermal_zone can be added to the AML for that model.

> The lid and power buttons are generating events after recompiling the DSDT 
> table (they didn't before). Proper IRQ routing, battery and ac_adapter 
> worked before.
> 
> 
> As for the Fn-keys:
> 
> Fn-ESC (mute): doesn't work
> Fn-F1 (screen lock): doesn't work
> Fn-F2 (power toggle): doesn't work
> Fn-F3 (suspend to RAM): doesn't work
> Fn-F4 (hibernate): doesn't work
> Fn-F5 (video switch): hangs the machine (read below)
> Fn-F6/F7 (brightness): works
> Fn-F8 (wireless toggle): works
> Fn-F9 (touchpad toggle): works
> Fn-F10/F11/F12: well, they should work anyway :)
> 

Some, if not all, of this Fn-key can be done via the omnibook kernel
module (see http://sf.net/projects/omke).  You can test at first
the perl tool, in order to check if that is ok.

Cheers,

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Len Brown]

On Tue, 2003-11-04 at 10:09, Ducrot Bruno wrote:
> On Tue, Nov 04, 2003 at 10:57:08AM -0200, Erico M Mendonca wrote:
> > Ducrot Bruno wrote:

> As I already tryed to say, unless you are on a BSD system,
> or unless someone port the FreeBSD acpidump, do not use acpidump.
> Or else, you are missing informations for debugging irq for example.

huh?
Are you referring to acpidmp from Intel's pmtools package?
What exactly is it missing?

thanks,
-Len




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: Toshiba Satellite 1905S303 DSDT table

[Ducrot Bruno]

On Tue, Nov 04, 2003 at 08:07:41PM -0500, Len Brown wrote:
> On Tue, 2003-11-04 at 10:09, Ducrot Bruno wrote:
> > On Tue, Nov 04, 2003 at 10:57:08AM -0200, Erico M Mendonca wrote:
> > > Ducrot Bruno wrote:
> 
> > As I already tryed to say, unless you are on a BSD system,
> > or unless someone port the FreeBSD acpidump, do not use acpidump.
> > Or else, you are missing informations for debugging irq for example.
> 
> huh?
> Are you referring to acpidmp from Intel's pmtools package?
> What exactly is it missing?

acpidump, with a 'u'.  It has nothing to do with pmtools.

It was the only free, decent AML decompiler available, before iasl
implemented the '-d' option, and is part of FreeBSD system.

A backport for other OS, like linux, were made, but is
less complete than the FreeBSD version.

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?   SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/