hw cursor is corrupted on Mach64

hw cursor is corrupted on Mach64

[Alexander Kern]

Hi,

does know anybody, what is mask layout in 

void aty_set_cursor_shape(struct fb_info *info, u8 *dst, u8 *src, unsigned int 
width)

I think, here is a corrupted mask! First scanlines are
FF FF <- seems to be correct, but the rest A5 A5 A5 A5...
And is it top - bottom or bottom - top ?

Regards Alex



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

Re: hw cursor is corrupted on Mach64

[Alexander Kern]

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

This patch cures corruption of HW-cursor!

bye
Alex

Am Freitag, 21. November 2003 19:45 schrieb Alexander Kern:
> Hi,
>
> does know anybody, what is mask layout in
>
> void aty_set_cursor_shape(struct fb_info *info, u8 *dst, u8 *src, unsigned
> int width)
>
> I think, here is a corrupted mask! First scanlines are
> FF FF <- seems to be correct, but the rest A5 A5 A5 A5...
> And is it top - bottom or bottom - top ?
>
> Regards Alex
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive?  Does it
> help you create better code?  SHARE THE LOVE, and help us help
> YOU!  Click Here: http://sourceforge.net/donate/
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

[-- Attachment #2: fbcon.patch --]
[-- Type: text/x-diff, Size: 837 bytes --]

--- fbcon.c.orig	2003-10-31 20:20:30.000000000 +0100
+++ fbcon.c	2003-11-30 21:43:24.000000000 +0100
@@ -1046,13 +1046,14 @@
                         dst = kmalloc(size, GFP_ATOMIC);
                         if (!dst)
                                 return;
+                        memset(dst, 0, size);
                         
                         cursor.set |= FB_CUR_SETSHAPE;
                         if (info->cursor.mask)
                                 kfree(info->cursor.mask);
                         info->cursor.mask = dst;
 
-                        for (i = 0; i < cur_height; i++) {
+                        for (i = 0; i < vc->vc_font.height; i++) {
                                 for (c = 0; c < s_pitch; c++)
                                         *dst++ = 0xff ^ *src++;
                         }       

Re: hw cursor is corrupted on Mach64

[James Simmons]

Applied. Missed clearing the default mask.


On Sun, 30 Nov 2003, Alexander Kern wrote:

> This patch cures corruption of HW-cursor!
> 
> bye
> Alex
> 
> Am Freitag, 21. November 2003 19:45 schrieb Alexander Kern:
> > Hi,
> >
> > does know anybody, what is mask layout in
> >
> > void aty_set_cursor_shape(struct fb_info *info, u8 *dst, u8 *src, unsigned
> > int width)
> >
> > I think, here is a corrupted mask! First scanlines are
> > FF FF <- seems to be correct, but the rest A5 A5 A5 A5...
> > And is it top - bottom or bottom - top ?
> >
> > Regards Alex
> >
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: SF.net Giveback Program.
> > Does SourceForge.net help you be more productive?  Does it
> > help you create better code?  SHARE THE LOVE, and help us help
> > YOU!  Click Here: http://sourceforge.net/donate/
> > _______________________________________________
> > Linux-fbdev-devel mailing list
> > Linux-fbdev-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click

Re: hw cursor is corrupted on Mach64

[James Simmons]

> does know anybody, what is mask layout in 
> 
> void aty_set_cursor_shape(struct fb_info *info, u8 *dst, u8 *src, unsigned int 
> width)
> 
> I think, here is a corrupted mask! First scanlines are
> FF FF <- seems to be correct, but the rest A5 A5 A5 A5...
> And is it top - bottom or bottom - top ?

That is correct. The cursor data area (what do you call it?) is 2 bits in 
size. The 2 bits are 

00    	Background color
01	Transparent.
10	Forground color. 
11	??

I can't remember off the top of my head.




-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click