All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: 2.6.0-mm1
@ 2003-12-24  9:59 GCS
  2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
  2003-12-24 14:38 ` 2.6.0-mm1 GCS
  0 siblings, 2 replies; 27+ messages in thread
From: GCS @ 2003-12-24  9:59 UTC (permalink / raw)
  To: linux-kernel

Hi,

On Tue, Dec 23, 2003 at 05:11:31AM +0200, Andrew Morton <akpm@osdl.org> wrote:

> It would be appreciated if people who have
> significant patches in -mm could retest please.
 It seems I can write CDs on my laptop now. AFAICR I was last trying it on
test8, but it was the same: if the image is over ~400Mb, the machine
freezes hard. If it's shorter, then it's ok, but still some lock or sth
is not unlocked, as the CPU is used more and more about five secs by one
or two percent. Sooner or later it's crashed as well, but I could
restart the machine before that happened. Rebooting to 2.4.2x and
writing CDs there was working all the time.
 So I do not know if it's fixed since test8, or in 2.6.0-mm1, but I am
happy with it. Also, I have two problems with 2.6.0-mm1:
- I can not deselect CONFIG_SCSI, only module or built-in available.
  Maybe something is depend on it, but could not figure out what (no
  CONFIG_BLK_DEV_IDESCSI, nothing is selected under CONFIG_SCSI).
- I have a synaptics touchpad, which is detected correctly, but only
  works if I set psmouse_noext=1. Under vanilla 2.6.0 it still works this
  way, but with 2.6.0-mm1 it works only on the console, but not under
  XFree86. Strange, as gpm interprets the input and pipes thru gpmdata
  to XFree86 4.3.0. Any idea what broke this configuration?

Thanks,
GCS

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24  9:59 2.6.0-mm1 GCS
@ 2003-12-24 11:32 ` Andrew Morton
  2003-12-24 11:53   ` 2.6.0-mm1 GCS
                     ` (2 more replies)
  2003-12-24 14:38 ` 2.6.0-mm1 GCS
  1 sibling, 3 replies; 27+ messages in thread
From: Andrew Morton @ 2003-12-24 11:32 UTC (permalink / raw)
  To: GCS; +Cc: linux-kernel, Peter Osterlund, Dmitry Torokhov

GCS <gcs@lsc.hu> wrote:
>
> Hi,
> 
> On Tue, Dec 23, 2003 at 05:11:31AM +0200, Andrew Morton <akpm@osdl.org> wrote:
> 
> > It would be appreciated if people who have
> > significant patches in -mm could retest please.
>  It seems I can write CDs on my laptop now. AFAICR I was last trying it on
> test8, but it was the same: if the image is over ~400Mb, the machine
> freezes hard. If it's shorter, then it's ok, but still some lock or sth
> is not unlocked, as the CPU is used more and more about five secs by one
> or two percent. Sooner or later it's crashed as well, but I could
> restart the machine before that happened. Rebooting to 2.4.2x and
> writing CDs there was working all the time.
>  So I do not know if it's fixed since test8, or in 2.6.0-mm1, but I am
> happy with it. Also, I have two problems with 2.6.0-mm1:

> - I can not deselect CONFIG_SCSI, only module or built-in available.
>   Maybe something is depend on it, but could not figure out what (no
>   CONFIG_BLK_DEV_IDESCSI, nothing is selected under CONFIG_SCSI).

Yes, this part of the config system is hard.  It always has been.  It's
similar to "wtf do I have to enable to make the <foo> menu appear.

I bit of grepping tells us that CONFIG_USB_STORAGE turns on CONFIG_SCSI.

> - I have a synaptics touchpad, which is detected correctly, but only
>   works if I set psmouse_noext=1. Under vanilla 2.6.0 it still works this
>   way, but with 2.6.0-mm1 it works only on the console, but not under
>   XFree86. Strange, as gpm interprets the input and pipes thru gpmdata
>   to XFree86 4.3.0. Any idea what broke this configuration?

Peter or Dmitry may be able to tell us.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
@ 2003-12-24 11:53   ` GCS
  2003-12-24 12:23     ` 2.6.0-mm1 GCS
  2003-12-24 12:47   ` 2.6.0-mm1 Thomas Molina
  2003-12-25  9:11   ` 2.6.0-mm1 Dmitry Torokhov
  2 siblings, 1 reply; 27+ messages in thread
From: GCS @ 2003-12-24 11:53 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Peter Osterlund, Dmitry Torokhov

On Wed, Dec 24, 2003 at 03:32:00AM -0800, Andrew Morton <akpm@osdl.org> wrote:
> I bit of grepping tells us that CONFIG_USB_STORAGE turns on CONFIG_SCSI.
 Thanks! Never throught. I could come up with this:
find . -name Kconfig| xargs grep --colour 'depends.* SCSI'
(Execute in the kernel tree, and replace SCSI with whatever you like;
may help others with similar questions).

> Peter or Dmitry may be able to tell us.
 IMHO it's either:
serio-04-synaptics-cleanup.patch
serio-06-synaptics-use-reconnect.patch
synaptics-powerpro-fix.patch
serio-pm-fix.patch
input-02-add-psmouse_proto.patch (?)
input-05-psmouse-fixes.patch
input-07-remove-synaptics-config-option.patch (maybe?)
input-08-synaptics-protocol-discovery.patch

Thus meanwhile I try to revert them. Anyway, as -mm1 is already bigger,
is it possible that you release 2.6.1 in this year with some/most of the
fixes in mm1?

GCS

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 11:53   ` 2.6.0-mm1 GCS
@ 2003-12-24 12:23     ` GCS
  2003-12-24 15:17       ` 2.6.0-mm1 Dmitry Torokhov
  0 siblings, 1 reply; 27+ messages in thread
From: GCS @ 2003-12-24 12:23 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Peter Osterlund, Dmitry Torokhov

On Wed, Dec 24, 2003 at 12:53:42PM +0100, GCS <gcs@lsc.hu> wrote:
> input-02-add-psmouse_proto.patch (?)
 Just found out psmouse_noext is deprecated. I have specified
psmouse_proto then, but imps and exps (and bare too, but I have not
tested it, as reading the code it seems psmouse_noext falls back to
bare) are the same. On the console touchpad is working, under XFree86
4.3.0 is not. To be more specific, the buttons do work, but I can not
move the pointer at all. Well, first I thought the middle two buttons
are for scrolling, as they are placed (and IIRC, they do scroll under
m$ win), but the top button is like the left button and the bottom button
is for paste, ie middle button on three buttons mices.

GCS

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
  2003-12-24 11:53   ` 2.6.0-mm1 GCS
@ 2003-12-24 12:47   ` Thomas Molina
  2003-12-25  9:11   ` 2.6.0-mm1 Dmitry Torokhov
  2 siblings, 0 replies; 27+ messages in thread
From: Thomas Molina @ 2003-12-24 12:47 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Kernel Mailing List



On Wed, 24 Dec 2003, Andrew Morton wrote:

> > - I have a synaptics touchpad, which is detected correctly, but only
> >   works if I set psmouse_noext=1. Under vanilla 2.6.0 it still works this
> >   way, but with 2.6.0-mm1 it works only on the console, but not under
> >   XFree86. Strange, as gpm interprets the input and pipes thru gpmdata
> >   to XFree86 4.3.0. Any idea what broke this configuration?
> 
> Peter or Dmitry may be able to tell us.

On the other hand, the synaptics touchpad on my laptop works under 
2.6.0-mm1 without the need to use the above parameter.  I don't get the 
jitter I reported for vanilla 2.6.0 synaptics support, but I do get an 
occasional small mouse jump.  

Other than that, 2.6.0-mm1 appears to be working well on my Presario 
12XL325 laptop.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24  9:59 2.6.0-mm1 GCS
  2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
@ 2003-12-24 14:38 ` GCS
  1 sibling, 0 replies; 27+ messages in thread
From: GCS @ 2003-12-24 14:38 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton

On Wed, Dec 24, 2003 at 10:59:21AM +0100, GCS <gcs@lsc.hu> wrote:
> [...] but still some lock or sth
> is not unlocked, as the CPU is used more and more about five secs by one
> or two percent. Sooner or later it's crashed as well, but I could
> restart the machine before that happened.
 Update: I could trigger this bug in 2.6.0-mm1 as well with the Linux
port of Head over Heels (classic game from C64). The CPU was getting
more and more used, so the game slowed down. I could quit then from the
game and XFree86. I did an emergency sync, and it succeded. Issued halt,
but it stopped at init sending term to all processes, so I tried a hard
power off. I got an error, something about slab, maybe at line 168. It
was scrolled out too fast by the stack-trace, and at the end:
ACPI-0094: *** Error: Could not acquire interpreter mutex
Crashed there. :-(

GCS

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 12:23     ` 2.6.0-mm1 GCS
@ 2003-12-24 15:17       ` Dmitry Torokhov
  2003-12-24 19:12         ` 2.6.0-mm1 GCS
  0 siblings, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-24 15:17 UTC (permalink / raw)
  To: GCS, Andrew Morton; +Cc: linux-kernel, Peter Osterlund

On Wednesday 24 December 2003 07:23 am, GCS wrote:
> On Wed, Dec 24, 2003 at 12:53:42PM +0100, GCS <gcs@lsc.hu> wrote:
> > input-02-add-psmouse_proto.patch (?)
>
>  Just found out psmouse_noext is deprecated. I have specified
> psmouse_proto then, but imps and exps (and bare too, but I have not
> tested it, as reading the code it seems psmouse_noext falls back to
> bare) are the same. On the console touchpad is working, under XFree86
> 4.3.0 is not. To be more specific, the buttons do work, but I can not
> move the pointer at all. Well, first I thought the middle two buttons
> are for scrolling, as they are placed (and IIRC, they do scroll under
> m$ win), but the top button is like the left button and the bottom
> button is for paste, ie middle button on three buttons mices.

May we see your dmegs, XF86Config and the parameters you are passing
to GPM please? Btw, what version of GPM are you using?

As far as reverting patches I would start with
input-08-synaptics-protocol-discovery.patch

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 15:17       ` 2.6.0-mm1 Dmitry Torokhov
@ 2003-12-24 19:12         ` GCS
  0 siblings, 0 replies; 27+ messages in thread
From: GCS @ 2003-12-24 19:12 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, linux-kernel, Peter Osterlund

On Wed, Dec 24, 2003 at 10:17:43AM -0500, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> May we see your dmegs, XF86Config and the parameters you are passing
> to GPM please?
 Sure, sorry for not doing it earlier:
-- dmesg --
i8042.c: Detected active multiplexing controller, rev 1.1.
serio: i8042 AUX0 port at 0x60,0x64 irq 12
serio: i8042 AUX1 port at 0x60,0x64 irq 12
serio: i8042 AUX2 port at 0x60,0x64 irq 12
serio: i8042 AUX3 port at 0x60,0x64 irq 12
Synaptics Touchpad, model: 1
 Firmware: 5.6
 180 degree mounted touchpad
 Sensor: 18
 new absolute packet format
 Touchpad has extended capability bits
 -> four buttons
 -> multifinger detection
 -> palm detection
input: SynPS/2 Synaptics TouchPad on isa0060/serio4
serio: i8042 KBD port at 0x60,0x64 irq 1
input: AT Translated Set 2 keyboard on isa0060/serio0
-- dmesg --

-- XF86Config-4 --
Section "Module"
        Load    "GLcore"
        Load    "bitmap"
        Load    "dbe"
        Load    "ddc"
        Load    "dri"
        Load    "extmod"
        Load    "glx"
        Load    "int10"
        Load    "record"
        Load    "speedo"
        Load    "type1"
        Load    "vbe"
        Load    "xtt"
        Load    "synaptics"
EndSection

Section "InputDevice"
        Driver        "synaptics"
        Identifier    "Configured Mouse"
        Option        "Device"        "/dev/gpmdata"
        Option        "Protocol"      "auto-dev"
        Option        "LeftEdge"      "1900"
        Option        "RightEdge"     "5400"
        Option        "TopEdge"       "1900"
        Option        "BottomEdge"    "4000"
        Option        "FingerLow"     "25"
        Option        "FingerHigh"    "30"
        Option        "MaxTapTime"    "180"
        Option        "MaxTapMove"    "220"
        Option        "VertScrollDelta" "100"
        Option        "MinSpeed"      "0.02"
        Option        "MaxSpeed"      "0.18"
        Option        "AccelFactor" "0.0010"
        Option        "SHMConfig"     "on"
#       Option       "Repeater"      "/dev/ps2mouse"
EndSection
-- XF86Config-4 --

The Synaptics driver used is 0.12.2, compiled for myself, evdev is in
module, but ofcourse it's loaded before XFree86 starts. (I have stripped
down the files a bit, if you would like to see the whole files or other
parts, please ask - I thought it would be easier to see the relevant
lines only). gpm is configured by /etc/gpm.conf , but it should be:
gpm -m /dev/psaux -t ps2 -R raw
Also, the XFree86 Synaptics driver prints this while starting and
switching between console and XFree86:
Synaptics DeviceInit called
SynapticsCtrl called.
Synaptics DeviceOn called
Synaptics DeviceOff called
[the last two repeated more times]

> Btw, what version of GPM are you using?
 I am running Debian Sid, thus I also thought gpm is the newest; as I
do understand I should use 1.20.1, which is the latest AFAIK. Thus I was
shocked a bit on what 'dpkg -l gpm' gives:
ii  gpm            1.19.6-12.1    General Purpose Mouse Interface
More than a year old! Already filed an important bug on this. Sorry, it
seems to be the problem, or at least produces strange behavior:
I plugged in an USB mouse, which works while the touchpad still not
under XFree86 (both works at the same time under console - even if I did
not specified any additional config for gpm). The config for XFree86:
-- XF86Config-4 --
Section "InputDevice"
        Identifier      "USB Mouse"
        Driver          "mouse"
        Option          "CorePointer"
        Option          "Device"                "/dev/input/mice"
        Option          "Protocol"              "imps/2"
        Option          "Emulate3Buttons"       "true"
        Option          "ZAxisMapping"          "4 5"
EndSection
-- XF86Config-4 --

Made it the only one pointer input. Now, if I kill gpm with 'gpm -k',
then the touchpad begins to work! Sometimes if I release it, then the
pointer jumps a bit from where I pointed it, but that's all. I'm not
good in mice stuff, so I can't explain this. Anyway, I will try to
compile a newer gpm, change it's device, so play a bit; maybe I can come
up with something.

> As far as reverting patches I would start with
> input-08-synaptics-protocol-discovery.patch
 It did not help. :-(

Thanks, and Merry Christmas!
GCS

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
  2003-12-24 11:53   ` 2.6.0-mm1 GCS
  2003-12-24 12:47   ` 2.6.0-mm1 Thomas Molina
@ 2003-12-25  9:11   ` Dmitry Torokhov
  2003-12-25  9:13     ` 2.6.0-mm1 - Patch 1/2 - mousedev-remove-jitter Dmitry Torokhov
  2003-12-25 18:22     ` 2.6.0-mm1 GCS
  2 siblings, 2 replies; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-25  9:11 UTC (permalink / raw)
  To: Andrew Morton, GCS; +Cc: linux-kernel, Peter Osterlund

On Wednesday 24 December 2003 06:32 am, Andrew Morton wrote:
> GCS <gcs@lsc.hu> wrote:
[..SKIP..]
>
> > - I have a synaptics touchpad, which is detected correctly, but only
> >   works if I set psmouse_noext=1. Under vanilla 2.6.0 it still works
> > this way, but with 2.6.0-mm1 it works only on the console, but not
> > under XFree86. Strange, as gpm interprets the input and pipes thru
> > gpmdata to XFree86 4.3.0. Any idea what broke this configuration?
>
> Peter or Dmitry may be able to tell us.

Whew.. that wasn't easy to spot... When doing PS/2 emulation for touchpads
that use absolute events, when processing BTN_TOUCH event mousedev would
stop on the very first client. So in your normal case only GPM would see
the Synaptics but once you killed GPM XFree would be the first in line and
magically start working.

My guess you didn't see that in stock 2.6.0 because you were compiling
without Synaptics support.

I am sending 2 patches - one to remove mouse jitter with Synaptics when
it is used through mousedev (PS/2 emulation) - mousedev will use 3 point
history and average when calculating deltas, the other one is the fix for
the problem you are experiencing. They should apply to 2.6.0-mm1 and to
stock 2.6.0 with minimal jitter.

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1 - Patch 1/2 - mousedev-remove-jitter
  2003-12-25  9:11   ` 2.6.0-mm1 Dmitry Torokhov
@ 2003-12-25  9:13     ` Dmitry Torokhov
  2003-12-25  9:14       ` 2.6.0-mm1 - Patch 2/2 - mousedev-dont-stop Dmitry Torokhov
  2003-12-25 18:22     ` 2.6.0-mm1 GCS
  1 sibling, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-25  9:13 UTC (permalink / raw)
  To: Andrew Morton, GCS; +Cc: linux-kernel, Peter Osterlund

===================================================================


ChangeSet@1.1522, 2003-12-23 02:24:12-05:00, dtor_core@ameritech.net
  Input: when calculating deltas for touchpads that generate
         absolute events use average over the last 3 packets
         to remove jitter


 mouse/synaptics.c |   11 ++++---
 mousedev.c        |   84 +++++++++++++++++++++++++++++++-----------------------
 2 files changed, 56 insertions(+), 39 deletions(-)


===================================================================



diff -Nru a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
--- a/drivers/input/mouse/synaptics.c	Thu Dec 25 03:58:14 2003
+++ b/drivers/input/mouse/synaptics.c	Thu Dec 25 03:58:14 2003
@@ -553,15 +553,18 @@
 		finger_width = 0;
 	}
 
-	/* Post events */
+	/* Post events
+	 * BTN_TOUCH has to be first as mousedev relies on it when doing
+	 * absolute -> relative conversion
+	 */
+	if (hw.z > 30) input_report_key(dev, BTN_TOUCH, 1);
+	if (hw.z < 25) input_report_key(dev, BTN_TOUCH, 0);
+
 	if (hw.z > 0) {
 		input_report_abs(dev, ABS_X, hw.x);
 		input_report_abs(dev, ABS_Y, YMAX_NOMINAL + YMIN_NOMINAL - hw.y);
 	}
 	input_report_abs(dev, ABS_PRESSURE, hw.z);
-
-	if (hw.z > 30) input_report_key(dev, BTN_TOUCH, 1);
-	if (hw.z < 25) input_report_key(dev, BTN_TOUCH, 0);
 
 	input_report_abs(dev, ABS_TOOL_WIDTH, finger_width);
 	input_report_key(dev, BTN_TOOL_FINGER, num_fingers == 1);
diff -Nru a/drivers/input/mousedev.c b/drivers/input/mousedev.c
--- a/drivers/input/mousedev.c	Thu Dec 25 03:58:14 2003
+++ b/drivers/input/mousedev.c	Thu Dec 25 03:58:14 2003
@@ -53,12 +53,14 @@
 	struct fasync_struct *fasync;
 	struct mousedev *mousedev;
 	struct list_head node;
-	int dx, dy, dz, oldx, oldy;
-	signed char ps2[6];
+	int dx, dy, dz;
+	int old_x[4], old_y[4];
 	unsigned long buttons;
+	signed char ps2[6];
 	unsigned char ready, buffer, bufsiz;
 	unsigned char mode, imexseq, impsseq;
-	int finger;
+	unsigned int pkt_count;
+	unsigned char touch;
 };
 
 #define MOUSEDEV_SEQ_LEN	6
@@ -74,49 +76,49 @@
 static int xres = CONFIG_INPUT_MOUSEDEV_SCREEN_X;
 static int yres = CONFIG_INPUT_MOUSEDEV_SCREEN_Y;
 
+#define fx(i)  (list->old_x[(list->pkt_count - (i)) & 03])
+#define fy(i)  (list->old_y[(list->pkt_count - (i)) & 03])
+
 static void mousedev_abs_event(struct input_handle *handle, struct mousedev_list *list, unsigned int code, int value)
 {
 	int size;
+	int touchpad;
 
 	/* Ignore joysticks */
 	if (test_bit(BTN_TRIGGER, handle->dev->keybit))
 		return;
 
-	/* Handle touchpad data */
-	if (test_bit(BTN_TOOL_FINGER, handle->dev->keybit)) {
+	touchpad = test_bit(BTN_TOOL_FINGER, handle->dev->keybit);
 
-		if (list->finger && list->finger < 3)
-			list->finger++;
-
-		switch (code) {
-			case ABS_X:
-				if (list->finger == 3)
-					list->dx += (value - list->oldx) / 8;
-				list->oldx = value;
-				return;
-			case ABS_Y:
-				if (list->finger == 3)
-					list->dy -= (value - list->oldy) / 8;
-				list->oldy = value;
-				return;
-		}
-		return;
-	}
-
-	/* Handle tablet data */
 	switch (code) {
 		case ABS_X:
-			size = handle->dev->absmax[ABS_X] - handle->dev->absmin[ABS_X];
-			if (size == 0) size = xres;
-			list->dx += (value * xres - list->oldx) / size;
-			list->oldx += list->dx * size;
-			return;
+			if (touchpad) {
+				if (list->touch) {
+					fx(0) = value;
+					if (list->pkt_count >= 2)
+						list->dx = ((fx(0) - fx(1)) / 2 + (fx(1) - fx(2)) / 2) / 8;
+				}
+			} else {
+				size = handle->dev->absmax[ABS_X] - handle->dev->absmin[ABS_X];
+				if (size == 0) size = xres;
+				list->dx += (value * xres - list->old_x[0]) / size;
+				list->old_x[0] += list->dx * size;
+			}
+			break;
 		case ABS_Y:
-			size = handle->dev->absmax[ABS_Y] - handle->dev->absmin[ABS_Y];
-			if (size == 0) size = yres;
-			list->dy -= (value * yres - list->oldy) / size;
-			list->oldy -= list->dy * size;
-			return;
+			if (touchpad) {
+				if (list->touch) {
+					fy(0) = value;
+					if (list->pkt_count >= 2)
+						list->dy = -((fy(0) - fy(1)) / 2 + (fy(1) - fy(2)) / 2) / 8;
+				}
+			} else {
+				size = handle->dev->absmax[ABS_Y] - handle->dev->absmin[ABS_Y];
+				if (size == 0) size = yres;
+				list->dy -= (value * yres - list->old_y[0]) / size;
+				list->old_y[0] -= list->dy * size;
+			}
+			break;
 	}
 }
 
@@ -149,7 +151,9 @@
 					switch (code) {
 						case BTN_TOUCH: /* Handle touchpad data */
 							if (test_bit(BTN_TOOL_FINGER, handle->dev->keybit)) {
-								list->finger = value;
+								list->touch = value;
+								if (!list->touch)
+									list->pkt_count = 0;
 								return;
 							}
 						case BTN_0:
@@ -178,6 +182,16 @@
 				case EV_SYN:
 					switch (code) {
 						case SYN_REPORT:
+							if (list->touch) {
+								list->pkt_count++;
+								/* Input system eats duplicate events, 
+								 * but we need all of them to do correct
+								 * averaging so apply present one forward
+								 */
+								fx(0) = fx(1);
+								fy(0) = fy(1);
+							}
+
 							list->ready = 1;
 							kill_fasync(&list->fasync, SIGIO, POLL_IN);
 							wake = 1;

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1 - Patch 2/2 - mousedev-dont-stop
  2003-12-25  9:13     ` 2.6.0-mm1 - Patch 1/2 - mousedev-remove-jitter Dmitry Torokhov
@ 2003-12-25  9:14       ` Dmitry Torokhov
  2003-12-27 11:38         ` Synaptics problems in -mm1 Tomas Szepe
  0 siblings, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-25  9:14 UTC (permalink / raw)
  To: Andrew Morton, GCS; +Cc: linux-kernel, Peter Osterlund

===================================================================


ChangeSet@1.1525, 2003-12-25 03:56:28-05:00, dtor_core@ameritech.net
  Input: correctly perform PS/2 (mousedev) emulation for touchpads
         generating absolute events (do not stop with the first
         client)


 mousedev.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)


===================================================================



diff -Nru a/drivers/input/mousedev.c b/drivers/input/mousedev.c
--- a/drivers/input/mousedev.c	Thu Dec 25 03:57:50 2003
+++ b/drivers/input/mousedev.c	Thu Dec 25 03:57:50 2003
@@ -148,14 +148,16 @@
 					break;
 
 				case EV_KEY:
+					if (code == BTN_TOUCH && test_bit(BTN_TOOL_FINGER, handle->dev->keybit)) {
+						/* Handle touchpad data */
+						list->touch = value;
+						if (!list->touch)
+							list->pkt_count = 0;
+						break;
+					}
+
 					switch (code) {
-						case BTN_TOUCH: /* Handle touchpad data */
-							if (test_bit(BTN_TOOL_FINGER, handle->dev->keybit)) {
-								list->touch = value;
-								if (!list->touch)
-									list->pkt_count = 0;
-								return;
-							}
+						case BTN_TOUCH:
 						case BTN_0:
 						case BTN_FORWARD:
 						case BTN_LEFT:   index = 0; break;

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: 2.6.0-mm1
  2003-12-25  9:11   ` 2.6.0-mm1 Dmitry Torokhov
  2003-12-25  9:13     ` 2.6.0-mm1 - Patch 1/2 - mousedev-remove-jitter Dmitry Torokhov
@ 2003-12-25 18:22     ` GCS
  1 sibling, 0 replies; 27+ messages in thread
From: GCS @ 2003-12-25 18:22 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, linux-kernel, Peter Osterlund

On Thu, Dec 25, 2003 at 04:11:54AM -0500, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> I am sending 2 patches - one to remove mouse jitter with Synaptics when
> it is used through mousedev (PS/2 emulation) - mousedev will use 3 point
> history and average when calculating deltas, the other one is the fix for
> the problem you are experiencing. They should apply to 2.6.0-mm1 and to
> stock 2.6.0 with minimal jitter.
 I have applied both to 2.6.0-mm1. They are just working, no jumping
mouse pointer when I release the touchpad, and both touchpad+usb mouse
working on console and under XFree86 as well. OK, I could not really
understand how they are working, as for me it seems gpm interprets
/dev/psaux only, and get both pointing device right, still XFree86 which
reads data replicated by gpm via gpmdata can't handle the USB mouse
directly. I had to use a separate config, which reads /dev/input/mice as
well. I think it's because XFree86's synaptics driver skip events from
the USB mouse. Anyway, thanks for your help and work!

Merry Christmas!
GCS
-- 
BorsodChem Joint-Stock Company				Linux Support Center
Software engineer					Developer
+36-48-511211/12-99                                     +36-20-4441745

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Synaptics problems in -mm1
  2003-12-25  9:14       ` 2.6.0-mm1 - Patch 2/2 - mousedev-dont-stop Dmitry Torokhov
@ 2003-12-27 11:38         ` Tomas Szepe
  2003-12-27 12:24           ` GCS
                             ` (2 more replies)
  0 siblings, 3 replies; 27+ messages in thread
From: Tomas Szepe @ 2003-12-27 11:38 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

Hi,

it seems one of the synaptics-related patches in 2.6.0-mm1 kills
off the pointer stick on my T40p.  2.6.0 vanilla works just fine
in that department.  Thought you might want to know.

Reverting

	input-08-synaptics-protocol-discovery.patch
	input-07-remove-synaptics-config-option.patch
	synaptics-powerpro-fix.patch

did not seem to help.  I failed to figure out a way to easily revert

	serio-06-synaptics-use-reconnect.patch
	serio-04-synaptics-cleanup.patch

so that I didn't try.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 11:38         ` Synaptics problems in -mm1 Tomas Szepe
@ 2003-12-27 12:24           ` GCS
  2003-12-27 13:22             ` Tomas Szepe
  2003-12-27 17:28           ` Dmitry Torokhov
  2003-12-27 17:56           ` Marcos D. Marado Torres
  2 siblings, 1 reply; 27+ messages in thread
From: GCS @ 2003-12-27 12:24 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Dmitry Torokhov, Andrew Morton, linux-kernel, Peter Osterlund

On Sat, Dec 27, 2003 at 12:38:48PM +0100, Tomas Szepe <szepe@pinerecords.com> wrote:
> it seems one of the synaptics-related patches in 2.6.0-mm1 kills
> off the pointer stick on my T40p.  2.6.0 vanilla works just fine
> in that department.  Thought you might want to know.
 I had the same problems, but Dmitry provided two additional patches,
which made my one working. Have you tried them? You can find them in the
thread.

Cheers,
GCS
Ps:Somehow I know you, just don't know where - are you Hungarian?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 12:24           ` GCS
@ 2003-12-27 13:22             ` Tomas Szepe
  0 siblings, 0 replies; 27+ messages in thread
From: Tomas Szepe @ 2003-12-27 13:22 UTC (permalink / raw)
  To: GCS; +Cc: Dmitry Torokhov, Andrew Morton, linux-kernel, Peter Osterlund

On Dec-27 2003, Sat, 13:24 +0100
GCS <gcs@lsc.hu> wrote:

> On Sat, Dec 27, 2003 at 12:38:48PM +0100, Tomas Szepe <szepe@pinerecords.com> wrote:
>
> > it seems one of the synaptics-related patches in 2.6.0-mm1 kills
> > off the pointer stick on my T40p.  2.6.0 vanilla works just fine
> > in that department.  Thought you might want to know.
>
> I had the same problems, but Dmitry provided two additional patches,
> which made my one working. Have you tried them? You can find them in the
> thread.

Unfortunately, the two patches from this thread don't solve
the mm1 problem I'm seeing, the stick keeps on resting. :)

> Ps:Somehow I know you, just don't know where - are you Hungarian?

Not really, it's just the name.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 11:38         ` Synaptics problems in -mm1 Tomas Szepe
  2003-12-27 12:24           ` GCS
@ 2003-12-27 17:28           ` Dmitry Torokhov
  2003-12-27 18:11             ` Tomas Szepe
  2003-12-27 17:56           ` Marcos D. Marado Torres
  2 siblings, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-27 17:28 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Saturday 27 December 2003 06:38 am, Tomas Szepe wrote:
> Hi,
>
> it seems one of the synaptics-related patches in 2.6.0-mm1 kills
> off the pointer stick on my T40p.  2.6.0 vanilla works just fine
> in that department.  Thought you might want to know.
>
> Reverting
>
> 	input-08-synaptics-protocol-discovery.patch
> 	input-07-remove-synaptics-config-option.patch
> 	synaptics-powerpro-fix.patch
>
> did not seem to help.  I failed to figure out a way to easily revert
>
> 	serio-06-synaptics-use-reconnect.patch
> 	serio-04-synaptics-cleanup.patch
>
> so that I didn't try.

I have a couple of questions (I am not familiar with IBM hardware so
please bear with me...):
- Is it detected as Synaptics but does not work?
- Should it be detected as Synaptics?
- Does it work if you pass psmouse_noext=1 or psmouse_proto=bare?
  And what about psmouse_proto=imps and psmouse_proto=exps
- Does it work if you give 2.6.0-test10-mm1 a quick boot?
- dmesg, input section of you XFree and version and parameters that
  are passed to GPM.

Thank you,

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 11:38         ` Synaptics problems in -mm1 Tomas Szepe
  2003-12-27 12:24           ` GCS
  2003-12-27 17:28           ` Dmitry Torokhov
@ 2003-12-27 17:56           ` Marcos D. Marado Torres
  2003-12-27 20:59             ` Dmitry Torokhov
  2 siblings, 1 reply; 27+ messages in thread
From: Marcos D. Marado Torres @ 2003-12-27 17:56 UTC (permalink / raw)
  To: Tomas Szepe
  Cc: Dmitry Torokhov, Andrew Morton, GCS, linux-kernel, Peter Osterlund

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


It kills the mouse tap on an Asus M3700N laptop too...

Mind Booster Noori

- --
==================================================
Marcos Daniel Marado Torres AKA Mind Booster Noori
/"\               http://student.dei.uc.pt/~marado
\ /                       marado@student.dei.uc.pt
 X   ASCII Ribbon Campaign
/ \  against HTML e-mail and Micro$oft attachments
==================================================

On Sat, 27 Dec 2003, Tomas Szepe wrote:

> Hi,
>
> it seems one of the synaptics-related patches in 2.6.0-mm1 kills
> off the pointer stick on my T40p.  2.6.0 vanilla works just fine
> in that department.  Thought you might want to know.
>
> Reverting
>
> 	input-08-synaptics-protocol-discovery.patch
> 	input-07-remove-synaptics-config-option.patch
> 	synaptics-powerpro-fix.patch
>
> did not seem to help.  I failed to figure out a way to easily revert
>
> 	serio-06-synaptics-use-reconnect.patch
> 	serio-04-synaptics-cleanup.patch
>
> so that I didn't try.
>
> --
> Tomas Szepe <szepe@pinerecords.com>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Made with pgp4pine 1.76

iD8DBQE/7cfQmNlq8m+oD34RAqUVAKDiNxT4XZgyDxsB2AzTqrUnmWfqkgCfZLah
18UNuecee424OP85exMvWW4=
=hki0
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 17:28           ` Dmitry Torokhov
@ 2003-12-27 18:11             ` Tomas Szepe
  2003-12-27 18:23               ` Dmitry Torokhov
  0 siblings, 1 reply; 27+ messages in thread
From: Tomas Szepe @ 2003-12-27 18:11 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Dec-27 2003, Sat, 12:28 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:

> > it seems one of the synaptics-related patches in 2.6.0-mm1 kills
> > off the pointer stick on my T40p.  2.6.0 vanilla works just fine
> > in that department.  Thought you might want to know.

...

> I have a couple of questions (I am not familiar with IBM hardware so
> please bear with me...):

No problem.

There are two pointer controllers on the T40p: a stick and a pad.
With 2.6.0, just compiling in synaptics support and running gpm as
"gpm -t ps2 -m /dev/psaux" or XFree with

  Option          "Protocol"      "PS/2"
  Option          "Device"        "/dev/psaux"

gives perfect results, both controllers work, even with
all the (3 + 2) buttons.

With 2.6.0-mm1 (the same .config of course), however, the stick does nothing.

> - Is it detected as Synaptics but does not work?

Yes.

> - Should it be detected as Synaptics?

I believe so.

> - Does it work if you pass psmouse_noext=1 or psmouse_proto=bare?

psmouse_noext=1				no change
psmouse_proto=bare			no change

>   And what about psmouse_proto=imps and psmouse_proto=exps

psmouse_proto=imps			no change
psmouse_proto=exps			no change

> - Does it work if you give 2.6.0-test10-mm1 a quick boot?

Hmmm, let's see.
[time passes]

-> No.

Linux version 2.6.0-test10-mm1 (kala@ns) (gcc version 3.3.2) #1 Sat Dec 27 18:59:17 CET 2003
...
mice: PS/2 mouse device common for all mice
input: PC Speaker
synaptics reset failed
synaptics reset failed
synaptics reset failed
Synaptics Touchpad, model: 1
 Firmware: 5.9
 Sensor: 44
 new absolute packet format
 Touchpad has extended capability bits
 -> multifinger detection
 -> palm detection
 -> pass-through port
input: SynPS/2 Synaptics TouchPad on isa0060/serio1
serio: Synaptics pass-through port at isa0060/serio1/input0

> - dmesg, input section of you XFree and version and parameters that
>   are passed to GPM.

Working kernel dmesg:

Linux version 2.6.0 (kala@ns) (gcc version 2.95.3 20010315 (release)) #1 Sat Dec 27 18:59:59 CET 2003
...
mice: PS/2 mouse device common for all mice
input: PC Speaker
Synaptics Touchpad, model: 1
 Firmware: 5.9
 Sensor: 44
 new absolute packet format
 Touchpad has extended capability bits
 -> multifinger detection
 -> palm detection
 -> pass-through port
input: SynPS/2 Synaptics TouchPad on isa0060/serio1
serio: Synaptics pass-through port at isa0060/serio1/input0
input: PS/2 Generic Mouse on synaptics-pt/serio0

Broken kernel dmesg:

Linux version 2.6.0-mm1 (kala@ns) (gcc version 3.3.2) #1 Sat Dec 27 14:12:13 CET 2003
...
mice: PS/2 mouse device common for all mice
input: PC Speaker
serio: i8042 AUX port at 0x60,0x64 irq 12
synaptics reset failed
synaptics reset failed
synaptics reset failed
Synaptics Touchpad, model: 1
 Firmware: 5.9
 Sensor: 44
 new absolute packet format
 Touchpad has extended capability bits
 -> multifinger detection
 -> palm detection
 -> pass-through port
input: SynPS/2 Synaptics TouchPad on isa0060/serio1
serio: Synaptics pass-through port at isa0060/serio1/input0
...
psmouse.c: TouchPad at isa0060/serio1/input0 lost synchronization, throwing 5 bytes away.

gpm is 1.19.6.
XFree is 4.3.0.
gpm parameters & XFree input config - see above.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 18:11             ` Tomas Szepe
@ 2003-12-27 18:23               ` Dmitry Torokhov
  2003-12-27 18:37                 ` Tomas Szepe
  0 siblings, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-27 18:23 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Saturday 27 December 2003 01:11 pm, Tomas Szepe wrote:

> mice: PS/2 mouse device common for all mice
> input: PC Speaker
> synaptics reset failed
> synaptics reset failed
> synaptics reset failed

Ok, are you running with cpufreq? I think it ACPI PM timer if you have
it activated - I am having problems with it myself but didn't have time
to look closer. Could you try booting with clock=tsc or clock=pit and
see if it fixes the touchpad.

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 18:23               ` Dmitry Torokhov
@ 2003-12-27 18:37                 ` Tomas Szepe
  2003-12-27 18:45                   ` Dmitry Torokhov
  2003-12-28  0:00                   ` Andrew Morton
  0 siblings, 2 replies; 27+ messages in thread
From: Tomas Szepe @ 2003-12-27 18:37 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Dec-27 2003, Sat, 13:23 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:

> > mice: PS/2 mouse device common for all mice
> > input: PC Speaker
> > synaptics reset failed
> > synaptics reset failed
> > synaptics reset failed
> 
> Ok, are you running with cpufreq?

Yes, but
	1) I've been on AC all the time.
	2) 2.6.0 works.

> I think it ACPI PM timer if you have it activated - I am having problems
> with it myself but didn't have time to look closer.  Could you try booting
> with clock=tsc or clock=pit and see if it fixes the touchpad.

clock=tsc		appears to fix the problem.
clock=pit		no change.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 18:37                 ` Tomas Szepe
@ 2003-12-27 18:45                   ` Dmitry Torokhov
  2003-12-27 19:01                     ` Tomas Szepe
  2003-12-28  0:00                   ` Andrew Morton
  1 sibling, 1 reply; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-27 18:45 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Saturday 27 December 2003 01:37 pm, Tomas Szepe wrote:
> On Dec-27 2003, Sat, 13:23 -0500
>
> Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > > mice: PS/2 mouse device common for all mice
> > > input: PC Speaker
> > > synaptics reset failed
> > > synaptics reset failed
> > > synaptics reset failed
> >
> > Ok, are you running with cpufreq?
>
> Yes, but
> 	1) I've been on AC all the time.
> 	2) 2.6.0 works.
>

Well, I have a daemon that monitors load and dynamically switches
between high and low frequency... 

> > I think it ACPI PM timer if you have it activated - I am having
> > problems with it myself but didn't have time to look closer.  Could
> > you try booting with clock=tsc or clock=pit and see if it fixes the
> > touchpad.
>
> clock=tsc		appears to fix the problem.
> clock=pit		no change.

Ok, good. So it is the timer funkiness. I would suggest not using ACPI
PM timer for now then. And yes, timer_pit does not have cpufreq hooks
either so it probably not the best timesource with cpufreq either,
so stick with TSC.

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 18:45                   ` Dmitry Torokhov
@ 2003-12-27 19:01                     ` Tomas Szepe
  2003-12-27 21:00                       ` Dmitry Torokhov
  0 siblings, 1 reply; 27+ messages in thread
From: Tomas Szepe @ 2003-12-27 19:01 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

> > Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > > > mice: PS/2 mouse device common for all mice
> > > > input: PC Speaker
> > > > synaptics reset failed
> > > > synaptics reset failed
> > > > synaptics reset failed
> > >
> > > Ok, are you running with cpufreq?
> >
> > Yes, but
> > 	1) I've been on AC all the time.
> > 	2) 2.6.0 works.
> >
> 
> Well, I have a daemon that monitors load and dynamically switches
> between high and low frequency... 

Sure, I've got one, too, but configured it to always go full throttle
when on AC.

> > > I think it ACPI PM timer if you have it activated - I am having
> > > problems with it myself but didn't have time to look closer.  Could
> > > you try booting with clock=tsc or clock=pit and see if it fixes the
> > > touchpad.
> >
> > clock=tsc		appears to fix the problem.
> > clock=pit		no change.
> 
> Ok, good. So it is the timer funkiness. I would suggest not using ACPI
> PM timer for now then. And yes, timer_pit does not have cpufreq hooks
> either so it probably not the best timesource with cpufreq either,
> so stick with TSC.

Stupid me, I absolutely forgot that I had enabled CONFIG_X86_PM_TIMER
(nonexistent in 2.6.0 stock) which indeed seems to be the culprit.
Please accept my apologies.  -mm1 with that config option unset won't
lose the stick, either.

Thanks!

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 17:56           ` Marcos D. Marado Torres
@ 2003-12-27 20:59             ` Dmitry Torokhov
  0 siblings, 0 replies; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-27 20:59 UTC (permalink / raw)
  To: Marcos D. Marado Torres
  Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund, Tomas Szepe

On Saturday 27 December 2003 12:56 pm, Marcos D. Marado Torres wrote:
> It kills the mouse tap on an Asus M3700N laptop too...

Mousedev PS/2 emulation for touchpads in absolute mode does not support
taps. You will either have to use Peter Osterlund's XFree86 driver at:
http://w1.894.telia.com/~u89404340/touchpad/index.html
and an updated version of GPM at http://www.geocities.com/dt_or/gpm
or disable native Synaptics support using psmouse_proto option
(bare, imps or exps; any of them should do the trick).

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 19:01                     ` Tomas Szepe
@ 2003-12-27 21:00                       ` Dmitry Torokhov
  0 siblings, 0 replies; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-27 21:00 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: Andrew Morton, GCS, linux-kernel, Peter Osterlund

On Saturday 27 December 2003 02:01 pm, Tomas Szepe wrote:
> > > Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > Ok, good. So it is the timer funkiness. I would suggest not using
> > ACPI PM timer for now then. And yes, timer_pit does not have cpufreq
> > hooks either so it probably not the best timesource with cpufreq
> > either, so stick with TSC.
>
> Stupid me, I absolutely forgot that I had enabled CONFIG_X86_PM_TIMER
> (nonexistent in 2.6.0 stock) which indeed seems to be the culprit.
> Please accept my apologies.  -mm1 with that config option unset won't
> lose the stick, either.
>
> Thanks!

Great! Thank you for letting me know.

Dmitry

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-27 18:37                 ` Tomas Szepe
  2003-12-27 18:45                   ` Dmitry Torokhov
@ 2003-12-28  0:00                   ` Andrew Morton
  2003-12-28  0:45                     ` Dmitry Torokhov
  2003-12-28  1:21                     ` Tomas Szepe
  1 sibling, 2 replies; 27+ messages in thread
From: Andrew Morton @ 2003-12-28  0:00 UTC (permalink / raw)
  To: Tomas Szepe; +Cc: dtor_core, gcs, linux-kernel, petero2, john stultz

Tomas Szepe <szepe@pinerecords.com> wrote:
>
>  > I think it ACPI PM timer if you have it activated - I am having problems
>  > with it myself but didn't have time to look closer.  Could you try booting
>  > with clock=tsc or clock=pit and see if it fixes the touchpad.
> 
>  clock=tsc		appears to fix the problem.
>  clock=pit		no change.

So we've established that it is an interaction between the input code, the
ACPI PM time code and cpufreq, yes?  That's a bit of a witches brew.

Does anyone know what aspect of the ACPI PM timer behaviour could cause
this?


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-28  0:00                   ` Andrew Morton
@ 2003-12-28  0:45                     ` Dmitry Torokhov
  2003-12-28  1:21                     ` Tomas Szepe
  1 sibling, 0 replies; 27+ messages in thread
From: Dmitry Torokhov @ 2003-12-28  0:45 UTC (permalink / raw)
  To: Andrew Morton, Tomas Szepe; +Cc: gcs, linux-kernel, petero2, john stultz

On Saturday 27 December 2003 07:00 pm, Andrew Morton wrote:
> Tomas Szepe <szepe@pinerecords.com> wrote:
> >  > I think it ACPI PM timer if you have it activated - I am having
> >  > problems with it myself but didn't have time to look closer. 
> >  > Could you try booting with clock=tsc or clock=pit and see if it
> >  > fixes the touchpad.
> >
> >  clock=tsc		appears to fix the problem.
> >  clock=pit		no change.
>
> So we've established that it is an interaction between the input code,
> the ACPI PM time code and cpufreq, yes?  That's a bit of a witches
> brew.
>
> Does anyone know what aspect of the ACPI PM timer behaviour could cause
> this?

>From my limited experience ACPI PM timer just gets the time wrong.
At least psmouse times out much quicker than 4 seconds when resetting
the touchpad which causes many problems.

Looking at the PM timer was on my TODO list ever since it was included
in -mm... I tried installing cpufreq handler to do the same adjustments
for loops_per_jiffy as in timer_pit but I was still getting pretty much
the same result - time goes too quickly.

Dmitry


^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: Synaptics problems in -mm1
  2003-12-28  0:00                   ` Andrew Morton
  2003-12-28  0:45                     ` Dmitry Torokhov
@ 2003-12-28  1:21                     ` Tomas Szepe
  1 sibling, 0 replies; 27+ messages in thread
From: Tomas Szepe @ 2003-12-28  1:21 UTC (permalink / raw)
  To: Andrew Morton; +Cc: dtor_core, gcs, linux-kernel, petero2, john stultz

On Dec-27 2003, Sat, 16:00 -0800
Andrew Morton <akpm@osdl.org> wrote:

> Tomas Szepe <szepe@pinerecords.com> wrote:
> >
> >  > I think it ACPI PM timer if you have it activated - I am having problems
> >  > with it myself but didn't have time to look closer.  Could you try booting
> >  > with clock=tsc or clock=pit and see if it fixes the touchpad.
> > 
> >  clock=tsc		appears to fix the problem.
> >  clock=pit		no change.
> 
> So we've established that it is an interaction between the input code, the
> ACPI PM time code and cpufreq, yes?  That's a bit of a witches brew.

Ok, I have verified this witch is not _that_ cunning.  cpufreq actually
seems to be innocent, I am able to reproduce the problem with CONFIG_CPU_FREQ
unset.

-- 
Tomas Szepe <szepe@pinerecords.com>

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2003-12-28  1:22 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-12-24  9:59 2.6.0-mm1 GCS
2003-12-24 11:32 ` 2.6.0-mm1 Andrew Morton
2003-12-24 11:53   ` 2.6.0-mm1 GCS
2003-12-24 12:23     ` 2.6.0-mm1 GCS
2003-12-24 15:17       ` 2.6.0-mm1 Dmitry Torokhov
2003-12-24 19:12         ` 2.6.0-mm1 GCS
2003-12-24 12:47   ` 2.6.0-mm1 Thomas Molina
2003-12-25  9:11   ` 2.6.0-mm1 Dmitry Torokhov
2003-12-25  9:13     ` 2.6.0-mm1 - Patch 1/2 - mousedev-remove-jitter Dmitry Torokhov
2003-12-25  9:14       ` 2.6.0-mm1 - Patch 2/2 - mousedev-dont-stop Dmitry Torokhov
2003-12-27 11:38         ` Synaptics problems in -mm1 Tomas Szepe
2003-12-27 12:24           ` GCS
2003-12-27 13:22             ` Tomas Szepe
2003-12-27 17:28           ` Dmitry Torokhov
2003-12-27 18:11             ` Tomas Szepe
2003-12-27 18:23               ` Dmitry Torokhov
2003-12-27 18:37                 ` Tomas Szepe
2003-12-27 18:45                   ` Dmitry Torokhov
2003-12-27 19:01                     ` Tomas Szepe
2003-12-27 21:00                       ` Dmitry Torokhov
2003-12-28  0:00                   ` Andrew Morton
2003-12-28  0:45                     ` Dmitry Torokhov
2003-12-28  1:21                     ` Tomas Szepe
2003-12-27 17:56           ` Marcos D. Marado Torres
2003-12-27 20:59             ` Dmitry Torokhov
2003-12-25 18:22     ` 2.6.0-mm1 GCS
2003-12-24 14:38 ` 2.6.0-mm1 GCS

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.