From: Mike Fedyk <mfedyk@matchmail.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Hans Reiser <reiser@namesys.com>,
"Tigran A. Aivazian" <tigran@veritas.com>,
Hans Reiser <reiserfs-dev@namesys.com>,
Daniel Pirkl <daniel.pirkl@email.cz>,
Russell King <rmk@arm.linux.org.uk>,
Will Dyson <will_dyson@pobox.com>,
linux-kernel@vger.kernel.org, nikita@namesys.com
Subject: Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested
Date: Tue, 6 Jan 2004 09:46:50 -0800 [thread overview]
Message-ID: <20040106174650.GD1882@matchmail.com> (raw)
In-Reply-To: <Pine.LNX.4.56.0401061218320.7945@jju_lnx.backbone.dif.dk>
On Tue, Jan 06, 2004 at 12:28:34PM +0100, Jesper Juhl wrote:
> --- linux-2.6.1-rc1-mm2-orig/fs/reiserfs/inode.c 2004-01-06 01:33:08.000000000 +0100
> +++ linux-2.6.1-rc1-mm2/fs/reiserfs/inode.c 2004-01-06 12:16:16.000000000 +0100
> @@ -574,11 +574,6 @@ int reiserfs_get_block (struct inode * i
> th.t_trans_id = 0 ;
> version = get_inode_item_key_version (inode);
>
> - if (block < 0) {
> - reiserfs_write_unlock(inode->i_sb);
> - return -EIO;
> - }
> -
Did you check the locking after this is removed?
Maybe after the sector_t merges, this code covered a case that is left open
now...
next prev parent reply other threads:[~2004-01-06 17:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 23:20 Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested Jesper Juhl
2004-01-06 8:51 ` Hans Reiser
2004-01-06 11:28 ` Jesper Juhl
2004-01-06 17:46 ` Mike Fedyk [this message]
2004-01-06 21:35 ` Oleg Drokin
2004-01-06 22:25 ` Mike Fedyk
2004-01-06 23:37 ` Hans Reiser
2004-01-06 23:53 ` Oleg Drokin
2004-01-07 9:26 ` Hans Reiser
2004-01-07 10:01 ` Oleg Drokin
2004-01-07 11:00 ` Hans Reiser
2004-01-07 12:08 ` Oleg Drokin
2004-01-07 12:17 ` Jesper Juhl
2004-01-07 12:27 ` Oleg Drokin
2004-01-07 17:45 ` Mike Fedyk
2004-01-13 16:26 ` Adrian Bunk
2004-01-06 22:43 ` Jesper Juhl
2004-01-06 22:58 ` Mike Fedyk
2004-01-06 23:26 ` Hans Reiser
2004-01-07 0:46 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040106174650.GD1882@matchmail.com \
--to=mfedyk@matchmail.com \
--cc=daniel.pirkl@email.cz \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@namesys.com \
--cc=reiser@namesys.com \
--cc=reiserfs-dev@namesys.com \
--cc=rmk@arm.linux.org.uk \
--cc=tigran@veritas.com \
--cc=will_dyson@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.