All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Drokin <green@linuxhacker.ru>
To: Hans Reiser <reiser@namesys.com>
Cc: linux-kernel@vger.kernel.org, mfedyk@matchmail.com,
	Jesper Juhl <juhl-lkml@dif.dk>
Subject: Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested
Date: Wed, 7 Jan 2004 01:53:35 +0200	[thread overview]
Message-ID: <20040106235335.GC415627@linuxhacker.ru> (raw)
In-Reply-To: <3FFB46B0.9060101@namesys.com>

Hello!

On Wed, Jan 07, 2004 at 02:37:20AM +0300, Hans Reiser wrote:

> >This code was never executing anyway.
> Oleg, I thought you ran a script for finding dead code last fall or 
> summer?  Any idea why it didn't find this and gcc did?  Or did you only 
> run it on reiser4?

Actually I found this dead code back then (with gcc as well), though
it was not looked all that serious. I think I decided we may want to have that
just in case sector_t will become signed oneday or something like that.
(in 2.4 the block type is still signed long, for example).

As for why gcc is finding this, but scripts (e.g. smatch) do not is because
scripts generally know nothing about variable types, so they cannot tell
this comparison was always false (and since gcc can do this for long time
already, there is no point in implementing it in scripts anyway).

Bye,
    Oleg

  reply	other threads:[~2004-01-06 23:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-05 23:20 Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested Jesper Juhl
2004-01-06  8:51 ` Hans Reiser
2004-01-06 11:28   ` Jesper Juhl
2004-01-06 17:46     ` Mike Fedyk
2004-01-06 21:35       ` Oleg Drokin
2004-01-06 22:25         ` Mike Fedyk
2004-01-06 23:37         ` Hans Reiser
2004-01-06 23:53           ` Oleg Drokin [this message]
2004-01-07  9:26             ` Hans Reiser
2004-01-07 10:01               ` Oleg Drokin
2004-01-07 11:00                 ` Hans Reiser
2004-01-07 12:08                   ` Oleg Drokin
2004-01-07 12:17                     ` Jesper Juhl
2004-01-07 12:27                       ` Oleg Drokin
2004-01-07 17:45                 ` Mike Fedyk
2004-01-13 16:26                 ` Adrian Bunk
2004-01-06 22:43       ` Jesper Juhl
2004-01-06 22:58         ` Mike Fedyk
2004-01-06 23:26         ` Hans Reiser
2004-01-07  0:46           ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040106235335.GC415627@linuxhacker.ru \
    --to=green@linuxhacker.ru \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfedyk@matchmail.com \
    --cc=reiser@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.