why not __MOD_DEC_USE_COUNT when we register match failer?

why not __MOD_DEC_USE_COUNT when we register match failer?

[lepton]

in ipt_state.c (and ipt_helper.c)

There is such code in init funciton
-------------------------------------------
/* NULL if ip_conntrack not a module */
if (ip_conntrack_module)
__MOD_INC_USE_COUNT(ip_conntrack_module);
return
	ipt_register_match(&state_match);
-------------------------------------------	

I think if ipt_register_match failed for some reason, the use count of
ip_conntrack_module will increase. Is it not a bug?

I thinks perhaps we should use such code:

------------------------------------------------
int ret;
/* NULL if ip_conntrack not a module */
if (ip_conntrack_module)
	__MOD_INC_USE_COUNT(ip_conntrack_module);
ret=ipt_register_match(&state_match);
if(ret)
	__MOD_DEC_USE_COUNT(ip_conntrack_module);
return ret;
------------------------------------------------

Re: why not __MOD_DEC_USE_COUNT when we register match failer?

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Tue, Jan 13, 2004 at 12:12:48PM +0800, lepton wrote:
> in ipt_state.c (and ipt_helper.c)
> 
> There is such code in init funciton
> -------------------------------------------
> /* NULL if ip_conntrack not a module */
> if (ip_conntrack_module)
> __MOD_INC_USE_COUNT(ip_conntrack_module);
> return
> 	ipt_register_match(&state_match);
> -------------------------------------------	
> 
> I think if ipt_register_match failed for some reason, the use count of
> ip_conntrack_module will increase. Is it not a bug?

yes, I agree.

> I thinks perhaps we should use such code:

Would you mind preparing a patch for those fixes?

-- 
- Harald Welte <laforge@netfilter.org>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]