* [patch 6/6] affs_setattr() retval fix
@ 2004-06-26 22:00 akpm
2004-06-26 22:46 ` Andreas Gruenbacher
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2004-06-26 22:00 UTC (permalink / raw)
To: mason; +Cc: shaggy, sfrench, vandrove, zippel, agruen, linux-fsdevel, akpm
affs is failing to propagate the inode_setattr() return value.
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/affs/inode.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/affs/inode.c~affs_setattr-retval-fix fs/affs/inode.c
--- 25/fs/affs/inode.c~affs_setattr-retval-fix 2004-06-26 14:46:27.538677464 -0700
+++ 25-akpm/fs/affs/inode.c 2004-06-26 14:46:40.798661640 -0700
@@ -249,7 +249,8 @@ affs_notify_change(struct dentry *dentry
goto out;
}
- inode_setattr(inode, attr);
+ if (!error)
+ error = inode_setattr(inode, attr);
if (!error && (attr->ia_valid & ATTR_MODE))
mode_to_prot(inode);
out:
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 6/6] affs_setattr() retval fix
2004-06-26 22:00 [patch 6/6] affs_setattr() retval fix akpm
@ 2004-06-26 22:46 ` Andreas Gruenbacher
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Gruenbacher @ 2004-06-26 22:46 UTC (permalink / raw)
To: akpm; +Cc: mason, shaggy, sfrench, vandrove, zippel, linux-fsdevel
On Sunday 27 June 2004 00:00, akpm@osdl.org wrote:
> affs is failing to propagate the inode_setattr() return value.
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> 25-akpm/fs/affs/inode.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN fs/affs/inode.c~affs_setattr-retval-fix fs/affs/inode.c
> --- 25/fs/affs/inode.c~affs_setattr-retval-fix 2004-06-26
> 14:46:27.538677464 -0700 +++ 25-akpm/fs/affs/inode.c 2004-06-26
> 14:46:40.798661640 -0700
> @@ -249,7 +249,8 @@ affs_notify_change(struct dentry *dentry
> goto out;
> }
>
> - inode_setattr(inode, attr);
> + if (!error)
> + error = inode_setattr(inode, attr);
> if (!error && (attr->ia_valid & ATTR_MODE))
> mode_to_prot(inode);
> out:
> _
This should be enough here:
--- linux-2.6.5.orig/fs/affs/inode.c
+++ linux-2.6.5/fs/affs/inode.c
@@ -251,3 +251,3 @@
- inode_setattr(inode, attr);
+ error = inode_setattr(inode, attr);
if (!error && (attr->ia_valid & ATTR_MODE))
Cheers,
--
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX AG
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-26 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-26 22:00 [patch 6/6] affs_setattr() retval fix akpm
2004-06-26 22:46 ` Andreas Gruenbacher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.