* [PATCH] plug leaks in aic7xxx_osm
@ 2004-09-01 15:51 Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2004-09-01 15:51 UTC (permalink / raw)
To: linux-kernel
Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/aic7xxx/aic7xxx_osm.c linux-2.6/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- bk-linus/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-08-28 21:57:23.000000000 +0100
+++ linux-2.6/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-09-01 13:31:12.000000000 +0100
@@ -1408,6 +1408,7 @@ ahc_dmamem_alloc(struct ahc_softc *ahc,
if (ahc->dev_softc != NULL)
if (ahc_pci_set_dma_mask(ahc->dev_softc, 0xFFFFFFFF)) {
printk(KERN_WARNING "aic7xxx: No suitable DMA available.\n");
+ kfree(map);
return (ENODEV);
}
*vaddr = pci_alloc_consistent(ahc->dev_softc,
@@ -1416,6 +1417,7 @@ ahc_dmamem_alloc(struct ahc_softc *ahc,
if (ahc_pci_set_dma_mask(ahc->dev_softc,
ahc->platform_data->hw_dma_mask)) {
printk(KERN_WARNING "aic7xxx: No suitable DMA available.\n");
+ kfree(map);
return (ENODEV);
}
#else /* LINUX_VERSION_CODE < KERNEL_VERSION(2,3,0) */
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] plug leaks in aic7xxx_osm
@ 2004-09-02 19:19 Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2004-09-02 19:19 UTC (permalink / raw)
To: linux-scsi
Spotted with the source checker from Coverity.com.
Signed-off-by: Dave Jones <davej@redhat.com>
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/scsi/aic7xxx/aic7xxx_osm.c linux-2.6/drivers/scsi/aic7xxx/aic7xxx_osm.c
--- bk-linus/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-08-28 21:57:23.000000000 +0100
+++ linux-2.6/drivers/scsi/aic7xxx/aic7xxx_osm.c 2004-09-01 13:31:12.000000000 +0100
@@ -1408,6 +1408,7 @@ ahc_dmamem_alloc(struct ahc_softc *ahc,
if (ahc->dev_softc != NULL)
if (ahc_pci_set_dma_mask(ahc->dev_softc, 0xFFFFFFFF)) {
printk(KERN_WARNING "aic7xxx: No suitable DMA available.\n");
+ kfree(map);
return (ENODEV);
}
*vaddr = pci_alloc_consistent(ahc->dev_softc,
@@ -1416,6 +1417,7 @@ ahc_dmamem_alloc(struct ahc_softc *ahc,
if (ahc_pci_set_dma_mask(ahc->dev_softc,
ahc->platform_data->hw_dma_mask)) {
printk(KERN_WARNING "aic7xxx: No suitable DMA available.\n");
+ kfree(map);
return (ENODEV);
}
#else /* LINUX_VERSION_CODE < KERNEL_VERSION(2,3,0) */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-02 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-01 15:51 [PATCH] plug leaks in aic7xxx_osm Dave Jones
2004-09-02 19:19 Dave Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.