* [PATCH] Add SPI-5 constants to scsi.h
@ 2004-09-21 11:50 Matthew Wilcox
2004-09-21 12:04 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2004-09-21 11:50 UTC (permalink / raw)
To: linux-scsi
Add the new constant names from SPI-5 to <scsi/scsi.h>
Index: linux-2.6/include/scsi/scsi.h
===================================================================
RCS file: /var/cvs/linux-2.6/include/scsi/scsi.h,v
retrieving revision 1.10
diff -u -p -r1.10 scsi.h
--- linux-2.6/include/scsi/scsi.h 13 Sep 2004 15:24:18 -0000 1.10
+++ linux-2.6/include/scsi/scsi.h 21 Sep 2004 11:48:09 -0000
@@ -246,24 +246,34 @@ struct scsi_lun {
#define EXTENDED_SDTR 0x01
#define EXTENDED_EXTENDED_IDENTIFY 0x02 /* SCSI-I only */
#define EXTENDED_WDTR 0x03
+#define EXTENDED_PPR 0x04
+#define EXTENDED_MODIFY_BIDI_DATA_PTR 0x05
#define SAVE_POINTERS 0x02
#define RESTORE_POINTERS 0x03
#define DISCONNECT 0x04
#define INITIATOR_ERROR 0x05
-#define ABORT 0x06
+#define ABORT_TASK_SET 0x06 /* SPI-5 name */
+#define ABORT ABORT_TASK_SET /* Old name */
#define MESSAGE_REJECT 0x07
#define NOP 0x08
#define MSG_PARITY_ERROR 0x09
#define LINKED_CMD_COMPLETE 0x0a
#define LINKED_FLG_CMD_COMPLETE 0x0b
-#define BUS_DEVICE_RESET 0x0c
-
+#define TARGET_RESET 0x0c /* SPI-5 name */
+#define BUS_DEVICE_RESET TARGET_RESET /* Old name */
+#define ABORT_TASK 0x0d
+#define CLEAR_TASK_SET 0x0e
#define INITIATE_RECOVERY 0x0f /* SCSI-II only */
#define RELEASE_RECOVERY 0x10 /* SCSI-II only */
-
+#define CLEAR_ACA 0x16
+#define LOGICAL_UNIT_RESET 0x17
#define SIMPLE_QUEUE_TAG 0x20
#define HEAD_OF_QUEUE_TAG 0x21
#define ORDERED_QUEUE_TAG 0x22
+#define IGNORE_WIDE_RESIDUE 0x23
+#define ACA 0x24
+#define QAS_REQUEST 0x55
+#define IDENTIFY 0x80
/*
* Host byte codes
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add SPI-5 constants to scsi.h
2004-09-21 11:50 [PATCH] Add SPI-5 constants to scsi.h Matthew Wilcox
@ 2004-09-21 12:04 ` Christoph Hellwig
2004-09-21 12:31 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2004-09-21 12:04 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-scsi
On Tue, Sep 21, 2004 at 12:50:59PM +0100, Matthew Wilcox wrote:
>
> Add the new constant names from SPI-5 to <scsi/scsi.h>
<nitpick>
What about having a section ala
/*
* Old SCSI2 names, don't use in new code
*/
#define ABORT ABORT_TASK_SET
#define BUS_DEVICE_RESET TARGET_RESET
instead of intermixing them with the rest of the defines?
</nitpick>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Add SPI-5 constants to scsi.h
2004-09-21 12:04 ` Christoph Hellwig
@ 2004-09-21 12:31 ` Matthew Wilcox
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2004-09-21 12:31 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Matthew Wilcox, linux-scsi
On Tue, Sep 21, 2004 at 01:04:38PM +0100, Christoph Hellwig wrote:
> On Tue, Sep 21, 2004 at 12:50:59PM +0100, Matthew Wilcox wrote:
> >
> > Add the new constant names from SPI-5 to <scsi/scsi.h>
>
> <nitpick>
> What about having a section ala
>
> /*
> * Old SCSI2 names, don't use in new code
> */
> #define ABORT ABORT_TASK_SET
> #define BUS_DEVICE_RESET TARGET_RESET
>
> instead of intermixing them with the rest of the defines?
Sure...
Index: linux-2.6/include/scsi/scsi.h
===================================================================
RCS file: /var/cvs/linux-2.6/include/scsi/scsi.h,v
retrieving revision 1.10
diff -u -p -r1.10 scsi.h
--- linux-2.6/include/scsi/scsi.h 13 Sep 2004 15:24:18 -0000 1.10
+++ linux-2.6/include/scsi/scsi.h 21 Sep 2004 12:30:39 -0000
@@ -246,24 +246,36 @@ struct scsi_lun {
#define EXTENDED_SDTR 0x01
#define EXTENDED_EXTENDED_IDENTIFY 0x02 /* SCSI-I only */
#define EXTENDED_WDTR 0x03
+#define EXTENDED_PPR 0x04
+#define EXTENDED_MODIFY_BIDI_DATA_PTR 0x05
#define SAVE_POINTERS 0x02
#define RESTORE_POINTERS 0x03
#define DISCONNECT 0x04
#define INITIATOR_ERROR 0x05
-#define ABORT 0x06
+#define ABORT_TASK_SET 0x06
#define MESSAGE_REJECT 0x07
#define NOP 0x08
#define MSG_PARITY_ERROR 0x09
#define LINKED_CMD_COMPLETE 0x0a
#define LINKED_FLG_CMD_COMPLETE 0x0b
-#define BUS_DEVICE_RESET 0x0c
-
+#define TARGET_RESET 0x0c
+#define ABORT_TASK 0x0d
+#define CLEAR_TASK_SET 0x0e
#define INITIATE_RECOVERY 0x0f /* SCSI-II only */
#define RELEASE_RECOVERY 0x10 /* SCSI-II only */
-
+#define CLEAR_ACA 0x16
+#define LOGICAL_UNIT_RESET 0x17
#define SIMPLE_QUEUE_TAG 0x20
#define HEAD_OF_QUEUE_TAG 0x21
#define ORDERED_QUEUE_TAG 0x22
+#define IGNORE_WIDE_RESIDUE 0x23
+#define ACA 0x24
+#define QAS_REQUEST 0x55
+#define IDENTIFY 0x80
+
+/* Old SCSI2 names, don't use in new code */
+#define BUS_DEVICE_RESET TARGET_RESET
+#define ABORT ABORT_TASK_SET
/*
* Host byte codes
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-21 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-21 11:50 [PATCH] Add SPI-5 constants to scsi.h Matthew Wilcox
2004-09-21 12:04 ` Christoph Hellwig
2004-09-21 12:31 ` Matthew Wilcox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.