* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace
@ 2004-09-16 23:46 Nishanth Aravamudan
2004-09-21 22:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir: Jean Tourrilhes
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Nishanth Aravamudan @ 2004-09-16 23:46 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Sorry, bad description, it
Uses msleep() in place of schedule_timeout() to guarantee the task
delays as expected.
On Thu, Sep 16, 2004 at 04:44:48PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Uses msleep() in place of cdrom_sleep()
> to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc2-vanilla/drivers/ide/legacy/ide-cs.c 2004-09-13 17:16:06.000000000 -0700
> +++ 2.6.9-rc2/drivers/ide/legacy/ide-cs.c 2004-09-16 16:42:03.000000000 -0700
> @@ -43,6 +43,7 @@
> #include <linux/ide.h>
> #include <linux/hdreg.h>
> #include <linux/major.h>
> +#include <linux/delay.h>
> #include <asm/io.h>
> #include <asm/system.h>
>
> @@ -357,8 +358,7 @@ void ide_config(dev_link_t *link)
> break;
> }
> }
> - __set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(HZ/10);
> + msleep(100);
> }
>
> if (hd < 0) {
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir:
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
@ 2004-09-21 22:04 ` Jean Tourrilhes
2004-09-21 23:49 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace Greg KH
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Jean Tourrilhes @ 2004-09-21 22:04 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
On Tue, Sep 21, 2004 at 02:57:58PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use msleep() instead of schedule_timeout()
> to guarantee the task delays as expected.
I already said that I don't want this. And looking at other
people getting confused by msleep, I'm more convinced than ever.
No.
Thank you.
Jean
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
2004-09-21 22:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir: Jean Tourrilhes
@ 2004-09-21 23:49 ` Greg KH
2004-09-22 9:58 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm: Markus Lidel
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2004-09-21 23:49 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Thu, Sep 16, 2004 at 04:40:31PM -0700, Nishanth Aravamudan wrote:
> Previous patch won't compile. Any comments would (still) be appreciated.
>
> Description: Properly orders set_current_state() and add_wait_queue().
> Uses msleep_interruptible() in place of schedule_timeout() to guarantee
> the task delays as expected. Uses set_current_state() instead of direct
> assignment of current->state.
Applied, thanks.
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm:
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
2004-09-21 22:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir: Jean Tourrilhes
2004-09-21 23:49 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace Greg KH
@ 2004-09-22 9:58 ` Markus Lidel
2004-09-23 22:27 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace Arnaldo Carvalho de Melo
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Markus Lidel @ 2004-09-22 9:58 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hello,
Nishanth Aravamudan wrote:
> Any comments would be appreciated.
> Description: Use msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.
Thank you very much!
Have changed it.
Best regards,
Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)
Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany
Phone: +49 82 82/99 51-0
Fax: +49 82 82/99 51-11
E-Mail: Markus.Lidel@shadowconnect.com
URL: http://www.shadowconnect.com
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
` (2 preceding siblings ...)
2004-09-22 9:58 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm: Markus Lidel
@ 2004-09-23 22:27 ` Arnaldo Carvalho de Melo
2004-09-24 18:21 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace Nishanth Aravamudan
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Arnaldo Carvalho de Melo @ 2004-09-23 22:27 UTC (permalink / raw)
To: kernel-janitors
Nishanth Aravamudan wrote:
> Any comments would be appreciated.
OK with me, as the other one for the cyc2x
>
> Description: Use ssleep() / msleep() [as appropriate]
> instead of schedule_timeout() to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.9-rc2-vanilla/drivers/net/appletalk/ltpc.c 2004-09-13 17:15:44.000000000 -0700
> +++ 2.6.9-rc2/drivers/net/appletalk/ltpc.c 2004-09-14 17:11:33.000000000 -0700
> @@ -1109,8 +1109,7 @@ struct net_device * __init ltpc_probe(vo
> inb_p(io+1);
> inb_p(io+3);
>
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(2*HZ/100);
> + msleep(20);
>
> inb_p(io+0);
> inb_p(io+2);
> @@ -1120,8 +1119,7 @@ struct net_device * __init ltpc_probe(vo
> inb_p(io+5); /* enable dma */
> inb_p(io+6); /* tri-state interrupt line */
>
> - set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(HZ);
> + ssleep(1);
>
> /* now, figure out which dma channel we're using, unless it's
> already been specified */
>
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
` (3 preceding siblings ...)
2004-09-23 22:27 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace Arnaldo Carvalho de Melo
@ 2004-09-24 18:21 ` Nishanth Aravamudan
2004-09-28 0:40 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx: David Gibson
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Nishanth Aravamudan @ 2004-09-24 18:21 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
On Fri, Sep 24, 2004 at 11:08:25AM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use ssleep() instead of schedule_timeout()
> to guarantee the task delays as expected.
As is pretty clear from the patch, this Description does not match.
Should be:
Description: Use msleep_interruptible() instead of schedule_timeout() to
guarantee the task delays as expected.
Sorry about that.
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx:
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
` (4 preceding siblings ...)
2004-09-24 18:21 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace Nishanth Aravamudan
@ 2004-09-28 0:40 ` David Gibson
2004-09-28 22:23 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl: David S. Miller
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp: Greg KH
7 siblings, 0 replies; 9+ messages in thread
From: David Gibson @ 2004-09-28 0:40 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Thu, Sep 23, 2004 at 03:01:10PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use ssleep() instead of schedule_timeout()
> to guarantee the task delays as expected.
This change (well, almost, using mdelay() rather than ssleep()) is
already in the working CVS tree. I already realise we're long, long
overdue on merging upstream.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl:
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
` (5 preceding siblings ...)
2004-09-28 0:40 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx: David Gibson
@ 2004-09-28 22:23 ` David S. Miller
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp: Greg KH
7 siblings, 0 replies; 9+ messages in thread
From: David S. Miller @ 2004-09-28 22:23 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
On Mon, 27 Sep 2004 10:25:50 -0700
Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected. Change the
> units of POLL_INTERVAL to msecs to correspond to the msleep*() change.
Applied, thanks.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp:
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
` (6 preceding siblings ...)
2004-09-28 22:23 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl: David S. Miller
@ 2004-09-29 17:41 ` Greg KH
7 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2004-09-29 17:41 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Fri, Sep 24, 2004 at 04:18:58PM -0700, Nishanth Aravamudan wrote:
> Any comments would be appreciated.
>
> Description: Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Applied, thanks.
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2004-09-29 17:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-16 23:46 [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/3] ide/ide-cs: replace Nishanth Aravamudan
2004-09-21 22:04 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/40] net/act2001-sir: Jean Tourrilhes
2004-09-21 23:49 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/2] i2c/i2c-mpc: replace Greg KH
2004-09-22 9:58 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] message/exec-osm: Markus Lidel
2004-09-23 22:27 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 22/38] net/ltpc: replace Arnaldo Carvalho de Melo
2004-09-24 18:21 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 28/38] net/pcnet32: replace Nishanth Aravamudan
2004-09-28 0:40 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 26/38] net/orinoco_plx: David Gibson
2004-09-28 22:23 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] sbus/bbc_envctrl: David S. Miller
2004-09-29 17:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2 2/4] pci hotplug/cpqphp: Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.