* [IPv4] Fix thinko in fib_find_alias
@ 2004-09-23 4:15 Herbert Xu
2004-09-23 20:37 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2004-09-23 4:15 UTC (permalink / raw)
To: David S. Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 455 bytes --]
Hi Dave:
fib_find_alias is meant to return either an exact match or the
entry just before where it should be. Currently it returns the
entry after that. This patch fixes that.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 296 bytes --]
===== net/ipv4/fib_hash.c 1.23 vs edited =====
--- 1.23/net/ipv4/fib_hash.c 2004-09-23 14:07:29 +10:00
+++ edited/net/ipv4/fib_hash.c 2004-09-23 14:08:42 +10:00
@@ -448,7 +448,7 @@
if (prio <= fa->fa_info->fib_priority)
break;
}
- return fa;
+ return prev_fa;
}
return NULL;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [IPv4] Fix thinko in fib_find_alias
2004-09-23 4:15 [IPv4] Fix thinko in fib_find_alias Herbert Xu
@ 2004-09-23 20:37 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-09-23 20:37 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
On Thu, 23 Sep 2004 14:15:16 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> fib_find_alias is meant to return either an exact match or the
> entry just before where it should be. Currently it returns the
> entry after that. This patch fixes that.
Good fix, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-09-23 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-23 4:15 [IPv4] Fix thinko in fib_find_alias Herbert Xu
2004-09-23 20:37 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.