* [KJ] [PATCH] video/sa1100fb: reorder set_current_state() and
@ 2004-10-22 23:56 Nishanth Aravamudan
2004-10-24 14:11 ` maximilian attems
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-10-22 23:56 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
Any comments would be, as always, appreciated.
-Nish
Description: Reorder add_wait_queue() and set_current_state() as a
signal could be lost in between the two functions.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-bk7-vanilla/drivers/video/sa1100fb.c 2004-10-22 10:40:44.000000000 -0700
+++ 2.6.9-bk7/drivers/video/sa1100fb.c 2004-10-22 15:59:35.000000000 -0700
@@ -1342,8 +1342,8 @@ static void sa1100fb_disable_controller(
GPCR |= SHANNON_GPIO_DISP_EN;
}
- add_wait_queue(&fbi->ctrlr_wait, &wait);
set_current_state(TASK_UNINTERRUPTIBLE);
+ add_wait_queue(&fbi->ctrlr_wait, &wait);
LCSR = 0xffffffff; /* Clear LCD Status Register */
LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [KJ] [PATCH] video/sa1100fb: reorder set_current_state() and
2004-10-22 23:56 [KJ] [PATCH] video/sa1100fb: reorder set_current_state() and Nishanth Aravamudan
@ 2004-10-24 14:11 ` maximilian attems
0 siblings, 0 replies; 2+ messages in thread
From: maximilian attems @ 2004-10-24 14:11 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Fri, 22 Oct 2004, Nishanth Aravamudan wrote:
> Any comments would be, as always, appreciated.
>
> -Nish
>
> Description: Reorder add_wait_queue() and set_current_state() as a
> signal could be lost in between the two functions.
>
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
applied to kjt,
to get further testing and to be shure it gets upstream.
thanks
--
maks
kernel janitor http://janitor.kernelnewbies.org/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-24 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-22 23:56 [KJ] [PATCH] video/sa1100fb: reorder set_current_state() and Nishanth Aravamudan
2004-10-24 14:11 ` maximilian attems
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.