[KJ] Re: [PATCH] w1/dscore: replace schedule_timeout() with

[KJ] Re: [PATCH] w1/dscore: replace schedule_timeout() with

[Evgeniy Polyakov]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Fri, 22 Oct 2004 16:24:24 -0700
Nishanth Aravamudan <nacc@us.ibm.com> wrote:

> Any comments would be, as always, appreciated.
> 
> -Nish
> 
> Description: Uses msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.

I'm Ok with your changes, all 4 patches applied, thank you.
They will be sent for inlusion through Greg Kroah-Hartman.

> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> --- 2.6.9-bk7-vanilla/drivers/w1/dscore.c	2004-10-22 10:41:43.000000000 -0700
> +++ 2.6.9-bk7/drivers/w1/dscore.c	2004-10-22 16:00:46.000000000 -0700
> @@ -733,10 +733,8 @@ void ds_disconnect(struct usb_interface 
>  	while (atomic_read(&dev->refcnt)) {
>  		printk(KERN_INFO "Waiting for DS to become free: refcnt=%d.\n",
>  				atomic_read(&dev->refcnt));
> -		set_current_state(TASK_INTERRUPTIBLE);
> -		schedule_timeout(HZ);
>  
> -		if (signal_pending(current))
> +		if (msleep_interruptible(1000))
>  			flush_signals(current);
>  	}
>  

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] Re: [PATCH] w1/dscore: replace schedule_timeout() with

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Sat, 23 Oct 2004, Evgeniy Polyakov wrote:

> On Fri, 22 Oct 2004 16:24:24 -0700
> Nishanth Aravamudan <nacc@us.ibm.com> wrote:
> 
> > Any comments would be, as always, appreciated.
> > 
> > -Nish
> > 
> > Description: Uses msleep_interruptible() instead of schedule_timeout()
> > to guarantee the task delays as expected.
> 
> I'm Ok with your changes, all 4 patches applied, thank you.
> They will be sent for inlusion through Greg Kroah-Hartman.
> 
great, 
in between applied them to the kjt tree with your signed-off,
just to be shure they get applied and further tested.

thanks maks


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors