* PATCH to fix smbfs on sparc64
@ 2004-10-30 23:21 Nicolas Boullis
2004-10-30 23:28 ` Nicolas Boullis
2004-11-09 23:48 ` David S. Miller
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Boullis @ 2004-10-30 23:21 UTC (permalink / raw)
To: sparclinux
Hi,
On sparc64, smbumount fails when called by a non-privileged user
because the SMB_IOC_GETMOUNTUID ioctl is broken. The attached patch
solves this and declares the new SMB_IOC_GETMOUNTUID as compatible with
32-bit userspace. I guss the second part of the patch should be handled
by this list. How about the first part? Should I send it to the
linux-kernel mailing-list? Or to the smbfs maintainer directly?
Thanks,
Nicolas Boullis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH to fix smbfs on sparc64
2004-10-30 23:21 PATCH to fix smbfs on sparc64 Nicolas Boullis
@ 2004-10-30 23:28 ` Nicolas Boullis
2004-11-09 23:48 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Boullis @ 2004-10-30 23:28 UTC (permalink / raw)
To: sparclinux
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
Hmmm....
As usual, I stupidly forgot to attach the promised patch. Here it is (if
I don't forget again).
Sorry for the extraneous noise,
Nicolas
[-- Attachment #2: linux-2.4.27-smbfs.patch --]
[-- Type: text/plain, Size: 1100 bytes --]
diff -ruN linux-2.4.27/arch/sparc64/kernel/ioctl32.c linux-2.4.27-smbfs/arch/sparc64/kernel/ioctl32.c
--- linux-2.4.27/arch/sparc64/kernel/ioctl32.c 2004-08-08 01:26:04.000000000 +0200
+++ linux-2.4.27-smbfs/arch/sparc64/kernel/ioctl32.c 2004-10-31 00:58:20.000000000 +0200
@@ -4928,6 +4928,7 @@
COMPATIBLE_IOCTL(RAW_GETBIND)
/* SMB ioctls which do not need any translations */
COMPATIBLE_IOCTL(SMB_IOC_NEWCONN)
+COMPATIBLE_IOCTL(SMB_IOC_GETMOUNTUID32)
/* NCP ioctls which do not need any translations */
COMPATIBLE_IOCTL(NCP_IOC_CONN_LOGGED_IN)
COMPATIBLE_IOCTL(NCP_IOC_SIGN_INIT)
diff -ruN linux-2.4.27/fs/smbfs/ioctl.c linux-2.4.27-smbfs/fs/smbfs/ioctl.c
--- linux-2.4.27/fs/smbfs/ioctl.c 2001-10-03 02:03:34.000000000 +0200
+++ linux-2.4.27-smbfs/fs/smbfs/ioctl.c 2004-10-31 00:58:20.000000000 +0200
@@ -32,7 +32,7 @@
switch (cmd) {
case SMB_IOC_GETMOUNTUID:
result = put_user(NEW_TO_OLD_UID(server->mnt->mounted_uid),
- (uid16_t *) arg);
+ (__kernel_old_uid_t *) arg);
break;
case SMB_IOC_GETMOUNTUID32:
result = put_user(server->mnt->mounted_uid, (uid_t *) arg);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH to fix smbfs on sparc64
2004-10-30 23:21 PATCH to fix smbfs on sparc64 Nicolas Boullis
2004-10-30 23:28 ` Nicolas Boullis
@ 2004-11-09 23:48 ` David S. Miller
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-11-09 23:48 UTC (permalink / raw)
To: sparclinux
On Sun, 31 Oct 2004 01:28:51 +0200
Nicolas Boullis <nboullis@debian.org> wrote:
> As usual, I stupidly forgot to attach the promised patch. Here it is (if
> I don't forget again).
I've applied the sparc64 part to my tree, thanks.
You should push the fs/smbfs/ioctl.c bit to the upstream
smbfs maintainer which appears to be listed as:
SMB FILESYSTEM
P: Urban Widmark
M: urban@teststation.com
W: http://samba.org/
L: samba@samba.org
S: Maintained
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-09 23:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-30 23:21 PATCH to fix smbfs on sparc64 Nicolas Boullis
2004-10-30 23:28 ` Nicolas Boullis
2004-11-09 23:48 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.