Re: [KJ] [PATCH] convert airo wireless driver to module_param

From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param
Date: Tue, 09 Nov 2004 22:29:01 +0000	[thread overview]
Message-ID: <20041109222901.GA7416@kroah.com> (raw)
In-Reply-To: <20041109212957.GA9496@dice.seeling33.de>

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

On Tue, Nov 09, 2004 at 11:21:06PM +0100, Stefan Sperling wrote:
> On Tue, Nov 09, 2004 at 01:38:18PM -0800, Randy.Dunlap wrote:
> > Stefan Sperling wrote:
>  
> > Rusty's first set of module_param() conversion patches, which
> > I mostly followed, use permission (last parameter) of 0
> > (not visible in sysfs) except for fields that can be modified.
> > Often this is a "debug" or "verbose" flag or bitmask.
> 
> Not in this one:
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=109826168201622&w=2
> 
> This is the reference link from the janitors TODO file.
> Everything 0444, except a debug flag, which is 0644.
> 
> Can someone please clarify the "official guidelines" for
> module parameter permissions in sysfs?

"When it makes sense to have it exposed to userspace"

Yeah, it's vague, sorry, but it all depends.

For things that can be changed on the fly, expose it.
For things that don't really matter, and no one will ever look them up,
don't.  I think the irq stuff is in the "don't" category, as almost no
one messes with them anymore.

Does this help?

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors