All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Sperling <stefan@binarchy.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param
Date: Tue, 09 Nov 2004 23:16:46 +0000	[thread overview]
Message-ID: <20041109231646.GA11645@dice.seeling33.de> (raw)
In-Reply-To: <20041109212957.GA9496@dice.seeling33.de>

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

On Tue, Nov 09, 2004 at 02:28:15PM -0800, Randy.Dunlap wrote:
> >>Rusty's first set of module_param() conversion patches, which
> >>I mostly followed, use permission (last parameter) of 0
> >>(not visible in sysfs) except for fields that can be modified.
> >>Often this is a "debug" or "verbose" flag or bitmask.
> >
> >
> >Not in this one:
> >
> >http://marc.theaimsgroup.com/?l=linux-kernel&m=109826168201622&w=2
> 
> True.  That's why we post patches and have review (one reason).
> 
> >This is the reference link from the janitors TODO file.
> >Everything 0444, except a debug flag, which is 0644.
> >
> >Can someone please clarify the "official guidelines" for
> >module parameter permissions in sysfs? Shall I use 0 or 0444
> >for parameters that should not be modified, i.e. everything
> >except debug and verbosity flags?
> 
> Compare with Rusty's (other) conversion patch (with wrap):
> 
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/remove-module_parm-from-allyesconfig-almost.patch


Yikes! He's quick.
He's already converted some of the drivers I have been converting.
Last time I looked he hadn't touched the wireless drivers yet...

Well, at least he did not convert all of them yet... ;-)
I'll post the missing ones soon so.

stefan
-- 
Give me a fish and I will eat today.
Teach me to fish and I will eat forever.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2004-11-09 23:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09 21:29 [KJ] [PATCH] convert airo wireless driver to module_param Stefan Sperling
2004-11-09 21:38 ` Randy.Dunlap
2004-11-09 22:05 ` Stefan Sperling
2004-11-09 22:21 ` Stefan Sperling
2004-11-09 22:28 ` Randy.Dunlap
2004-11-09 22:29 ` Greg KH
2004-11-09 22:29 ` Randy.Dunlap
2004-11-09 22:56 ` Stefan Sperling
2004-11-09 22:58 ` Stefan Sperling
2004-11-09 23:16 ` Stefan Sperling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041109231646.GA11645@dice.seeling33.de \
    --to=stefan@binarchy.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.