little mistake in nandwrite.c

little mistake in nandwrite.c

[Michael]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi.
I'm pretty sure I've found a small mistake in 'nandwrite.c'.

Relevant code block:  (mistake is 5 lines in)

        // force oob layout for jffs2 or yaffs ?
        if (forcejffs2 || forceyaffs) {
                struct nand_oobinfo *oobsel = forcejffs2 ?
&jffs2_oobinfo : &yaffs_oobinfo;

                if (forceyaffs && meminfo.oobsize == 8) {
                        if (forceyaffs) {
                                fprintf (stderr, "YAFSS cannot
operate on 256 Byte page size");
                                goto restoreoob;
                        }
                        /* Adjust number of ecc bytes */
                        jffs2_oobinfo.eccbytes = 3;
                }

                if (ioctl (fd, MEMSETOOBSEL, oobsel) != 0) {
                        perror ("MEMSETOOBSEL");
                        goto restoreoob;
                }
        }

Patch is attached.

[-- Attachment #2: nandwrite.c_patch --]
[-- Type: application/octet-stream, Size: 439 bytes --]

--- nandwrite.c.orig	2005-01-07 14:22:54.000000000 -0600
+++ nandwrite.c	2005-01-07 14:23:10.000000000 -0600
@@ -271,7 +271,7 @@
 	if (forcejffs2 || forceyaffs) {
 		struct nand_oobinfo *oobsel = forcejffs2 ? &jffs2_oobinfo : &yaffs_oobinfo;
 		
-		if (forceyaffs && meminfo.oobsize == 8) {
+		if (meminfo.oobsize == 8) {
     			if (forceyaffs) {
 				fprintf (stderr, "YAFSS cannot operate on 256 Byte page size");
 				goto restoreoob;