Re: [PATCH 3/4] new timeofday x86-64 arch specific changes (v. B1)

From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Parag Warudkar <kernel-stuff@comcast.net>
Cc: john stultz <johnstul@us.ibm.com>,
	Nishanth Aravamudan <nacc@us.ibm.com>, Andi Kleen <ak@suse.de>,
	lkml <linux-kernel@vger.kernel.org>,
	Tim Schmielau <tim@physik3.uni-rostock.de>,
	George Anzinger <george@mvista.com>,
	albert@users.sourceforge.net,
	Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
	Christoph Lameter <clameter@sgi.com>,
	David Mosberger <davidm@hpl.hp.com>,
	Andrew Morton <akpm@osdl.org>,
	paulus@samba.org, schwidefsky@de.ibm.com,
	keith maanthey <kmannth@us.ibm.com>,
	Chris McDermott <lcm@us.ibm.com>, Max Asbock <masbock@us.ibm.com>,
	mahuja@us.ibm.com, Darren Hart <darren@dvhart.com>,
	"Darrick J. Wong" <djwong@us.ibm.com>,
	Anton Blanchard <anton@samba.org>,
	donf@us.ibm.com, mpm@selenic.com, benh@kernel.crashing.org
Subject: Re: [PATCH 3/4] new timeofday x86-64 arch specific changes (v. B1)
Date: Mon, 6 Jun 2005 05:14:28 +0200	[thread overview]
Message-ID: <20050606031427.GA14196@isilmar.linta.de> (raw)
In-Reply-To: <200506052304.35298.kernel-stuff@comcast.net>

Hi,

On Sun, Jun 05, 2005 at 11:04:34PM -0400, Parag Warudkar wrote:
> tests the chipset read in the same do{}while loop - if the loop executes only 
> once, it considers the chipset good - in which case it executes the faster 
> read_pmtmr_fast function.) Or does it need wider testing under different 
> circumstances to conclude that chipset is good?

I fear that we need to run the loop a couple of times at least -- IIRC many
accesses were correct, but some failed. Will investigate soon.

> I tested the patch under Virtual PC which emulates a PIIX4 chipset. Test 
> passes there, meaning the do {}while  loop executes only once.

Possibly this is a bug-free emulation?

	Dominik