* recent sched.c broke cpu hotplug
@ 2005-06-23 21:30 Ashok Raj
2005-06-24 7:00 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Ashok Raj @ 2005-06-23 21:30 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, nickpiggin
Hi Andrew
trivial fix, this is required for getting cpu hotplug to work. These
functions are called during cpu down, but marked __init instead of __devinit.
--
Cheers,
Ashok Raj
- Open Source Technology Center
Some functions should be devinit for cpu hotplug purpose.
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
-----------------------------------------------------
kernel/sched.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.12-mm1/kernel/sched.c
===================================================================
--- linux-2.6.12-mm1.orig/kernel/sched.c
+++ linux-2.6.12-mm1/kernel/sched.c
@@ -5207,7 +5207,7 @@ __setup("migration_factor=", setup_migra
* Estimated distance of two CPUs, measured via the number of domains
* we have to pass for the two CPUs to be in the same span:
*/
-__init static unsigned long domain_distance(int cpu1, int cpu2)
+__devinit static unsigned long domain_distance(int cpu1, int cpu2)
{
unsigned long distance = 0;
struct sched_domain *sd;
@@ -5417,7 +5417,7 @@ measure_cost(int cpu1, int cpu2, void *c
return cost1 - cost2;
}
-__init static unsigned long long measure_migration_cost(int cpu1, int cpu2)
+__devinit static unsigned long long measure_migration_cost(int cpu1, int cpu2)
{
unsigned long long max_cost = 0, fluct = 0, avg_fluct = 0;
unsigned int max_size, size, size_found = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: recent sched.c broke cpu hotplug
2005-06-23 21:30 recent sched.c broke cpu hotplug Ashok Raj
@ 2005-06-24 7:00 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2005-06-24 7:00 UTC (permalink / raw)
To: Ashok Raj; +Cc: linux-kernel, akpm, nickpiggin
* Ashok Raj <ashok.raj@intel.com> wrote:
> Hi Andrew
>
> trivial fix, this is required for getting cpu hotplug to work. These
> functions are called during cpu down, but marked __init instead of
> __devinit.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-24 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-23 21:30 recent sched.c broke cpu hotplug Ashok Raj
2005-06-24 7:00 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.