[KJ] [PATCH] Balanced io{re|un}map : drivers/char/moxa.c

[KJ] [PATCH] Balanced io{re|un}map : drivers/char/moxa.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

description:
Balancing functions: io{re|un}map here.
Make sure calls to certain functions are matched by the relevant function 
at other end of the function, and also during ALL failure/early return paths.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

diff -urpN -X dontdiff 2.6.12-orig/drivers/char/moxa.c 2.6.12/drivers/char/moxa.c
--- 2.6.12-orig/drivers/char/moxa.c	2005-06-17 21:48:29.000000000 +0200
+++ 2.6.12/drivers/char/moxa.c	2005-06-24 09:52:40.321457432 +0200
@@ -492,6 +492,10 @@ static void __exit moxa_exit(void)
 	if (tty_unregister_driver(moxaDriver))
 		printk("Couldn't unregister MOXA Intellio family serial driver\n");
 	put_tty_driver(moxaDriver);
+	for (i = 0; i < numBoards; i++) {
+		iounmap((void __iomem *) moxaBaseAddr[i]);
+	}
+
 	if (verbose)
 		printk("Done\n");
 }

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] Balanced io{re|un}map : drivers/char/moxa.c

[Alexey Dobriyan]

On Friday 24 June 2005 12:52, Christophe Lucas wrote:
> Make sure calls to certain functions are matched by the relevant function 
> at other end of the function, and also during ALL failure/early return paths.

> --- 2.6.12-orig/drivers/char/moxa.c
> +++ 2.6.12/drivers/char/moxa.c
> @@ -492,6 +492,10 @@ static void __exit moxa_exit(void)

> +	for (i = 0; i < numBoards; i++) {
> +		iounmap((void __iomem *) moxaBaseAddr[i]);
> +	}
> +

No need for cast and for {}.

static void __iomem *moxaBaseAddr[MAX_BOARDS];

Oh, and it won't compile.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors