All of lore.kernel.org
 help / color / mirror / Atom feed
* Search in make menuconfig doesn't work properly
@ 2005-09-14  6:50 Karel Kulhavy
  2005-09-14  9:27 ` Cal Peake
  2005-09-24  2:09 ` [PATCH] clarify menuconfig /(search) help text Randy.Dunlap
  0 siblings, 2 replies; 6+ messages in thread
From: Karel Kulhavy @ 2005-09-14  6:50 UTC (permalink / raw)
  To: linux-kernel

I have 2.6.13 and if I press '/' in make menuconfig (Search
Configuration Parameter, Enter Keyword) and enther "emulation", it
doesn't find
CONFIG_BLK_DEV_IDESCSI -  SCSI emulation support.

CL<

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Search in make menuconfig doesn't work properly
  2005-09-14  6:50 Search in make menuconfig doesn't work properly Karel Kulhavy
@ 2005-09-14  9:27 ` Cal Peake
  2005-09-14 12:39   ` Karel Kulhavy
  2005-09-14 14:56   ` Randy.Dunlap
  2005-09-24  2:09 ` [PATCH] clarify menuconfig /(search) help text Randy.Dunlap
  1 sibling, 2 replies; 6+ messages in thread
From: Cal Peake @ 2005-09-14  9:27 UTC (permalink / raw)
  To: Karel Kulhavy; +Cc: linux-kernel

On Wed, 14 Sep 2005, Karel Kulhavy wrote:

> I have 2.6.13 and if I press '/' in make menuconfig (Search
> Configuration Parameter, Enter Keyword) and enther "emulation", it
> doesn't find
> CONFIG_BLK_DEV_IDESCSI -  SCSI emulation support.

AFAIK it only matches against the CONFIG_ symbols. If you want it to do 
more cook up a patch ;)

-- 
". . . tell 'em we use Linux." -- Dave Chappelle


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Search in make menuconfig doesn't work properly
  2005-09-14  9:27 ` Cal Peake
@ 2005-09-14 12:39   ` Karel Kulhavy
  2005-09-14 15:07     ` Randy.Dunlap
  2005-09-14 14:56   ` Randy.Dunlap
  1 sibling, 1 reply; 6+ messages in thread
From: Karel Kulhavy @ 2005-09-14 12:39 UTC (permalink / raw)
  To: linux-kernel

On Wed, Sep 14, 2005 at 05:27:49AM -0400, Cal Peake wrote:
> On Wed, 14 Sep 2005, Karel Kulhavy wrote:
> 
> > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > doesn't find
> > CONFIG_BLK_DEV_IDESCSI -  SCSI emulation support.
> 
> AFAIK it only matches against the CONFIG_ symbols. If you want it to do 
> more cook up a patch ;)

I suggest "Enter Keyword" to be changed to "Enter Keyword to search
in CONFIG_... symbols".

CL<

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Search in make menuconfig doesn't work properly
  2005-09-14  9:27 ` Cal Peake
  2005-09-14 12:39   ` Karel Kulhavy
@ 2005-09-14 14:56   ` Randy.Dunlap
  1 sibling, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2005-09-14 14:56 UTC (permalink / raw)
  To: Cal Peake; +Cc: Karel Kulhavy, linux-kernel

On Wed, 14 Sep 2005, Cal Peake wrote:

> On Wed, 14 Sep 2005, Karel Kulhavy wrote:
>
> > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > doesn't find
> > CONFIG_BLK_DEV_IDESCSI -  SCSI emulation support.
>
> AFAIK it only matches against the CONFIG_ symbols. If you want it to do
> more cook up a patch ;)

IOW, entering:

/BLK_DEV_IDESCSI

does produce the expected (but maybe not the desired?) results.

WFM.
-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Search in make menuconfig doesn't work properly
  2005-09-14 12:39   ` Karel Kulhavy
@ 2005-09-14 15:07     ` Randy.Dunlap
  0 siblings, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2005-09-14 15:07 UTC (permalink / raw)
  To: Karel Kulhavy; +Cc: linux-kernel

On Wed, 14 Sep 2005, Karel Kulhavy wrote:

> On Wed, Sep 14, 2005 at 05:27:49AM -0400, Cal Peake wrote:
> > On Wed, 14 Sep 2005, Karel Kulhavy wrote:
> >
> > > I have 2.6.13 and if I press '/' in make menuconfig (Search
> > > Configuration Parameter, Enter Keyword) and enther "emulation", it
> > > doesn't find
> > > CONFIG_BLK_DEV_IDESCSI -  SCSI emulation support.
> >
> > AFAIK it only matches against the CONFIG_ symbols. If you want it to do
> > more cook up a patch ;)
>
> I suggest "Enter Keyword" to be changed to "Enter Keyword to search
> in CONFIG_... symbols".

Makes sense.  or "Enter CONFIG_ symbol to search for: (omit CONFIG_)".

Please send a patch.

-- 
~Randy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] clarify menuconfig /(search) help text
  2005-09-14  6:50 Search in make menuconfig doesn't work properly Karel Kulhavy
  2005-09-14  9:27 ` Cal Peake
@ 2005-09-24  2:09 ` Randy.Dunlap
  1 sibling, 0 replies; 6+ messages in thread
From: Randy.Dunlap @ 2005-09-24  2:09 UTC (permalink / raw)
  To: Karel Kulhavy; +Cc: linux-kernel, akpm

From: Randy Dunlap <rdunlap@xenotime.net>

Add explicit text about
- where menuconfig '/' (search) searches for strings,
- that substrings are allowed, and
- that regular expressions are supported.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---

 scripts/kconfig/mconf.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -Naurp linux-2614-rc2-git3/scripts/kconfig/mconf.c~search_keyword linux-2614-rc2-git3/scripts/kconfig/mconf.c
--- linux-2614-rc2-git3/scripts/kconfig/mconf.c~search_keyword	2005-08-28 16:41:01.000000000 -0700
+++ linux-2614-rc2-git3/scripts/kconfig/mconf.c	2005-09-23 19:04:39.000000000 -0700
@@ -219,6 +219,7 @@ save_config_help[] = N_(
 search_help[] = N_(
 	"\n"
 	"Search for CONFIG_ symbols and display their relations.\n"
+	"Regular expressions are allowed.\n"
 	"Example: search for \"^FOO\"\n"
 	"Result:\n"
 	"-----------------------------------------------------------------\n"
@@ -531,7 +532,7 @@ again:
 	cprint("--title");
 	cprint(_("Search Configuration Parameter"));
 	cprint("--inputbox");
-	cprint(_("Enter Keyword"));
+	cprint(_("Enter CONFIG_ (sub)string to search for (omit CONFIG_)"));
 	cprint("10");
 	cprint("75");
 	cprint("");

---

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-09-24  2:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-14  6:50 Search in make menuconfig doesn't work properly Karel Kulhavy
2005-09-14  9:27 ` Cal Peake
2005-09-14 12:39   ` Karel Kulhavy
2005-09-14 15:07     ` Randy.Dunlap
2005-09-14 14:56   ` Randy.Dunlap
2005-09-24  2:09 ` [PATCH] clarify menuconfig /(search) help text Randy.Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.