From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Hugh Dickins <hugh@veritas.com>
Cc: Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Badari Pulavarty <pbadari@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: set_page_dirty vs set_page_dirty_lock
Date: Thu, 8 Dec 2005 23:56:00 +0200 [thread overview]
Message-ID: <20051208215600.GE13886@mellanox.co.il> (raw)
In-Reply-To: <Pine.LNX.4.61.0512081908530.11737@goblin.wat.veritas.com>
Quoting Hugh Dickins <hugh@veritas.com>:
> Many would be pleased if we could manage without set_page_dirty_lock.
It seems that I can do
if (TestSetPageLocked(page))
schedule_work()
and in this way, avoid the schedule_work overhead for the common case
where the page isnt locked.
Right?
If that works, I can mostly do things directly,
although I'm still stuck with the problem of an app performing
a fork + write into the same page while I'm doing DMA there.
I am currently solving this by doing a second get_user_pages after
DMA is done and comparing the page lists, but this, of course,
needs a task context ...
--
MST
next prev parent reply other threads:[~2005-12-08 21:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 19:09 set_page_dirty vs set_page_dirty_lock Michael S. Tsirkin
2005-12-08 19:19 ` Hugh Dickins
2005-12-08 19:29 ` Michael S. Tsirkin
2005-12-08 19:54 ` Jens Axboe
2005-12-08 21:56 ` Michael S. Tsirkin [this message]
2005-12-12 3:28 ` Nick Piggin
2005-12-12 6:35 ` Michael S. Tsirkin
2005-12-12 7:10 ` Nick Piggin
2005-12-12 8:14 ` Michael S. Tsirkin
2005-12-12 8:32 ` Nick Piggin
2005-12-12 8:55 ` Michael S. Tsirkin
2005-12-12 9:23 ` Nick Piggin
2005-12-12 9:59 ` Michael S. Tsirkin
2005-12-13 21:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208215600.GE13886@mellanox.co.il \
--to=mst@mellanox.co.il \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=pbadari@us.ibm.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.