All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Nelson <shannon.nelson@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, anders.roxell@linaro.org
Subject: Re: [PATCH net-next 0/2] fixes for ipsec selftests
Date: Thu, 21 Jun 2018 23:50:36 -0700	[thread overview]
Message-ID: <20059528-5d1d-cb7c-26f8-f9055bd807c2@oracle.com> (raw)
In-Reply-To: <20180622.134913.2049651808540037401.davem@davemloft.net>

On 6/21/2018 9:49 PM, David Miller wrote:
> From: Shannon Nelson <shannon.nelson@oracle.com>
> Date: Tue, 19 Jun 2018 22:42:41 -0700
> 
>> A couple of bad behaviors in the ipsec selftest were pointed out
>> by Anders Roxell <anders.roxell@linaro.org> and are addressed here.
>>
>> Shannon Nelson (2):
>>    selftests: rtnetlink: hide complaint from terminated monitor
>>    selftests: rtnetlink: use a local IP address for IPsec tests
> 
> Series applied, but I wonder about patch #2.
> 
> The idea is that we don't make modifications to the actual system
> networking configuration and therefore make changes that can't
> possibly disrupt connectivity for the system under test.
> 
> Using a configured local IP address seems to subvert that.

Yeah, I'm not so thrilled with it either.  I've got a couple more 
changes coming Real Soon Now that extend netdevsim and add a couple of 
tests for ipsec-hw-offload, so while I finish those up I can change this 
again and make use of netdevsim to leave existing devices alone.

For that matter, if you want to cut down on patch thrash, just drop patch 2.

sln

  reply	other threads:[~2018-06-22  6:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20  5:42 [PATCH net-next 0/2] fixes for ipsec selftests Shannon Nelson
2018-06-20  5:42 ` [PATCH net-next 1/2] selftests: rtnetlink: hide complaint from terminated monitor Shannon Nelson
2018-06-20  5:42 ` [PATCH net-next 2/2] selftests: rtnetlink: use a local IP address for IPsec tests Shannon Nelson
2018-06-20 19:09 ` [PATCH net-next 0/2] fixes for ipsec selftests Anders Roxell
2018-06-20 22:26   ` Shannon Nelson
2018-06-20 23:18     ` Anders Roxell
2018-06-21  0:32       ` Shannon Nelson
2018-06-21 16:56         ` Anders Roxell
2018-06-21 17:25           ` Shannon Nelson
2018-06-22  4:49 ` David Miller
2018-06-22  6:50   ` Shannon Nelson [this message]
2018-06-22  7:27     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20059528-5d1d-cb7c-26f8-f9055bd807c2@oracle.com \
    --to=shannon.nelson@oracle.com \
    --cc=anders.roxell@linaro.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.