* [PATCH] kprobe cleanup for VM_MASK judgement
@ 2006-04-26 9:56 mao, bibo
2006-04-26 16:43 ` Keshavamurthy Anil S
2006-04-26 17:57 ` Prasanna S Panchamukhi
0 siblings, 2 replies; 3+ messages in thread
From: mao, bibo @ 2006-04-26 9:56 UTC (permalink / raw)
To: Andrew Morton, Masami Hiramatsu, Jim Keniston, Keshavamurthy,
Anil S, Ananth N Mavinakayanahalli, prasanna
Cc: LKML, systemtap
Hi,
When trap happens in user space, kprobe_exceptions_notify() funtion will skip it.
This patch deletes some unnecessary code for VM_MASK judgement in eflags.
Signed-off-by: bibo, mao <bibo.mao@intel.com>
Thanks
bibo,mao
diff -Nruap 2.6.17-rc1-mm3.org/arch/i386/kernel/kprobes.c 2.6.17-rc1-mm3.new/arch/i386/kernel/kprobes.c
--- 2.6.17-rc1-mm3.org/arch/i386/kernel/kprobes.c 2006-04-26 15:52:24.000000000 +0800
+++ 2.6.17-rc1-mm3.new/arch/i386/kernel/kprobes.c 2006-04-26 16:25:38.000000000 +0800
@@ -242,10 +242,6 @@ static int __kprobes kprobe_handler(stru
kcb->kprobe_status = KPROBE_REENTER;
return 1;
} else {
- if (regs->eflags & VM_MASK) {
- /* We are in virtual-8086 mode. Return 0 */
- goto no_kprobe;
- }
if (*addr != BREAKPOINT_INSTRUCTION) {
/* The breakpoint instruction was removed by
* another cpu right after we hit, no further
@@ -265,11 +261,6 @@ static int __kprobes kprobe_handler(stru
p = get_kprobe(addr);
if (!p) {
- if (regs->eflags & VM_MASK) {
- /* We are in virtual-8086 mode. Return 0 */
- goto no_kprobe;
- }
-
if (*addr != BREAKPOINT_INSTRUCTION) {
/*
* The breakpoint instruction was removed right
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kprobe cleanup for VM_MASK judgement
2006-04-26 9:56 [PATCH] kprobe cleanup for VM_MASK judgement mao, bibo
@ 2006-04-26 16:43 ` Keshavamurthy Anil S
2006-04-26 17:57 ` Prasanna S Panchamukhi
1 sibling, 0 replies; 3+ messages in thread
From: Keshavamurthy Anil S @ 2006-04-26 16:43 UTC (permalink / raw)
To: mao, bibo
Cc: Andrew Morton, Masami Hiramatsu, Jim Keniston, Keshavamurthy,
Anil S, Ananth N Mavinakayanahalli, prasanna, LKML, systemtap
On Wed, Apr 26, 2006 at 05:56:26PM +0800, mao, bibo wrote:
> Hi,
> When trap happens in user space, kprobe_exceptions_notify() funtion will skip it.
> This patch deletes some unnecessary code for VM_MASK judgement in eflags.
>
> Signed-off-by: bibo, mao <bibo.mao@intel.com>
ACK
Acked-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kprobe cleanup for VM_MASK judgement
2006-04-26 9:56 [PATCH] kprobe cleanup for VM_MASK judgement mao, bibo
2006-04-26 16:43 ` Keshavamurthy Anil S
@ 2006-04-26 17:57 ` Prasanna S Panchamukhi
1 sibling, 0 replies; 3+ messages in thread
From: Prasanna S Panchamukhi @ 2006-04-26 17:57 UTC (permalink / raw)
To: mao, bibo
Cc: Andrew Morton, Masami Hiramatsu, Jim Keniston, Keshavamurthy,
Anil S, Ananth N Mavinakayanahalli, LKML, systemtap
> Hi,
> When trap happens in user space, kprobe_exceptions_notify() funtion will skip it.
> This patch deletes some unnecessary code for VM_MASK judgement in eflags.
>
> Signed-off-by: bibo, mao <bibo.mao@intel.com>
Looks good to me.
Thanks
Prasanna
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-51776329
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-04-26 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-26 9:56 [PATCH] kprobe cleanup for VM_MASK judgement mao, bibo
2006-04-26 16:43 ` Keshavamurthy Anil S
2006-04-26 17:57 ` Prasanna S Panchamukhi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.