[PATCH] LSM: add missing hook to do_compat_readv_writev()

[PATCH] LSM: add missing hook to do_compat_readv_writev()

[James Morris]

This patch addresses a flaw in LSM, where there is no mediation of readv() 
and writev() in for 32-bit compatible apps using a 64-bit kernel.

This bug was discovered and fixed initially in the native readv/writev 
code [1], but was not fixed in the compat code.  Thanks to Al for spotting 
this one.


Please apply.

Signed-off-by: James Morris <jmorris@namei.org> 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>


[1] http://lwn.net/Articles/154282/

---

diff -purN -X dontdiff linux-2.6.17-rc2.o/fs/compat.c linux-2.6.17-rc2.fix/fs/compat.c
--- linux-2.6.17-rc2.o/fs/compat.c	2006-04-19 23:31:24.000000000 -0400
+++ linux-2.6.17-rc2.fix/fs/compat.c	2006-04-25 20:41:39.000000000 -0400
@@ -1217,6 +1217,10 @@ static ssize_t compat_do_readv_writev(in
 	if (ret < 0)
 		goto out;
 
+	ret = security_file_permission(file, type == READ ? MAY_READ:MAY_WRITE);
+	if (ret)
+		goto out;
+
 	fnv = NULL;
 	if (type == READ) {
 		fn = file->f_op->read;

Re: [PATCH] LSM: add missing hook to do_compat_readv_writev()

[Chris Wright]

* James Morris (jmorris@namei.org) wrote:
> This patch addresses a flaw in LSM, where there is no mediation of readv() 
> and writev() in for 32-bit compatible apps using a 64-bit kernel.
> 
> This bug was discovered and fixed initially in the native readv/writev 
> code [1], but was not fixed in the compat code.  Thanks to Al for spotting 
> this one.
> 
> 
> Please apply.
> 
> Signed-off-by: James Morris <jmorris@namei.org> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: Chris Wright <chrisw@sous-sol.org>

thanks,
-chris