* [BPQ] lockdep: fix false positive
@ 2006-07-10 15:53 Ralf Baechle
2006-07-10 18:24 ` David Miller
2006-07-11 12:28 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Ralf Baechle @ 2006-07-10 15:53 UTC (permalink / raw)
To: David S. Miller, Jeff Garzik, netdev, Molnar Ingo, Arjan van de Ven
Bpqether is encapsulating AX.25 frames into ethernet frames. There is a
virtual bpqether device paired with each ethernet devices, so it's normal
to pass through dev_queue_xmit twice for each frame which triggers the
locking detector.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
drivers/net/hamradio/bpqether.c | 7 +++++++
1 file changed, 7 insertions(+)
Index: linux-net/drivers/net/hamradio/bpqether.c
===================================================================
--- linux-net.orig/drivers/net/hamradio/bpqether.c 2006-07-09 02:47:59.000000000 +0100
+++ linux-net/drivers/net/hamradio/bpqether.c 2006-07-10 14:18:48.000000000 +0100
@@ -122,6 +122,12 @@ struct bpqdev {
static LIST_HEAD(bpq_devices);
+/*
+ * bpqether network devices are paired with ethernet devices below them, so
+ * form a special "super class" of normal ethernet devices; split their locks
+ * off into a separate class since they always nest.
+ */
+static struct lock_class_key bpq_netdev_xmit_lock_key;
/* ------------------------------------------------------------------------ */
@@ -528,6 +534,7 @@ static int bpq_new_device(struct net_dev
err = register_netdevice(ndev);
if (err)
goto error;
+ lockdep_set_class(&ndev->_xmit_lock, &bpq_netdev_xmit_lock_key);
/* List protected by RTNL */
list_add_rcu(&bpq->bpq_list, &bpq_devices);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BPQ] lockdep: fix false positive
2006-07-10 15:53 [BPQ] lockdep: fix false positive Ralf Baechle
@ 2006-07-10 18:24 ` David Miller
2006-07-11 12:28 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2006-07-10 18:24 UTC (permalink / raw)
To: ralf; +Cc: jeff, netdev, mingo, arjan
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 10 Jul 2006 16:53:34 +0100
> Bpqether is encapsulating AX.25 frames into ethernet frames. There is a
> virtual bpqether device paired with each ethernet devices, so it's normal
> to pass through dev_queue_xmit twice for each frame which triggers the
> locking detector.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Applied, thanks Ralf.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BPQ] lockdep: fix false positive
2006-07-10 15:53 [BPQ] lockdep: fix false positive Ralf Baechle
2006-07-10 18:24 ` David Miller
@ 2006-07-11 12:28 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2006-07-11 12:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: David S. Miller, Jeff Garzik, netdev, Arjan van de Ven
* Ralf Baechle <ralf@linux-mips.org> wrote:
> Bpqether is encapsulating AX.25 frames into ethernet frames. There is
> a virtual bpqether device paired with each ethernet devices, so it's
> normal to pass through dev_queue_xmit twice for each frame which
> triggers the locking detector.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
thanks!
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-11 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-10 15:53 [BPQ] lockdep: fix false positive Ralf Baechle
2006-07-10 18:24 ` David Miller
2006-07-11 12:28 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.