All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -mm] libsas: externs not needed
@ 2006-08-07 18:38 Randy.Dunlap
  0 siblings, 0 replies; only message in thread
From: Randy.Dunlap @ 2006-08-07 18:38 UTC (permalink / raw)
  To: scsi; +Cc: jejb, akpm

From: Randy Dunlap <rdunlap@xenotime.net>

These functions shouldn't be 'extern'.  That's not needed for
exports in Linux.  Also, sparse complains, so fix them.

drivers/scsi/libsas/sas_init.c:138:39: warning: function 'sas_domain_attach_transport' with external linkage has definition
drivers/scsi/libsas/sas_init.c:158:13: warning: function 'sas_domain_release_transport' with external linkage has definitio

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/scsi/libsas/sas_init.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2618-rc3mm2.orig/drivers/scsi/libsas/sas_init.c
+++ linux-2618-rc3mm2/drivers/scsi/libsas/sas_init.c
@@ -135,7 +135,7 @@ int sas_unregister_ha(struct sas_ha_stru
 static struct sas_function_template sft = {
 };
 
-extern struct scsi_transport_template *
+struct scsi_transport_template *
 sas_domain_attach_transport(struct sas_domain_function_template *dft)
 {
 	struct scsi_transport_template *stt = sas_attach_transport(&sft);
@@ -155,7 +155,7 @@ sas_domain_attach_transport(struct sas_d
 EXPORT_SYMBOL_GPL(sas_domain_attach_transport);
 
 
-extern void sas_domain_release_transport(struct scsi_transport_template *stt)
+void sas_domain_release_transport(struct scsi_transport_template *stt)
 {
 	sas_release_transport(stt);
 }


---

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-08-07 18:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-07 18:38 [PATCH -mm] libsas: externs not needed Randy.Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.