All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] eCryptfs: mntput() lower mount on umount_begin()
@ 2006-08-24 20:02 Michael Halcrow
  0 siblings, 0 replies; only message in thread
From: Michael Halcrow @ 2006-08-24 20:02 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, mhalcrow

On unmount, eCryptfs needs to decrement the mount count of the lower
mount, or else you cannot unmount the lower filesystem.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>

---

 fs/ecryptfs/super.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

bcc1939b87a3df14a9b975bdfde47dd5b230a6e5
diff --git a/fs/ecryptfs/super.c b/fs/ecryptfs/super.c
index 120f060..f4f06ea 100644
--- a/fs/ecryptfs/super.c
+++ b/fs/ecryptfs/super.c
@@ -144,10 +144,7 @@ static void ecryptfs_clear_inode(struct 
 /**
  * ecryptfs_umount_begin
  *
- * Called in do_umount() if the MNT_FORCE flag was used and this
- * function is defined.  See comment in linux/fs/super.c:do_umount().
- * Used only in nfs, to kill any pending RPC tasks, so that subsequent
- * code can actually succeed and won't leave tasks that need handling.
+ * Called in do_umount().
  */
 static void ecryptfs_umount_begin(struct vfsmount *vfsmnt, int flags)
 {
@@ -155,6 +152,7 @@ static void ecryptfs_umount_begin(struct
 		ecryptfs_dentry_to_lower_mnt(vfsmnt->mnt_sb->s_root);
 	struct super_block *lower_sb;
 
+	mntput(lower_mnt);
 	lower_sb = lower_mnt->mnt_sb;
 	if (lower_sb->s_op->umount_begin)
 		lower_sb->s_op->umount_begin(lower_mnt, flags);
-- 
1.3.3


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-08-24 20:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-24 20:02 [PATCH] eCryptfs: mntput() lower mount on umount_begin() Michael Halcrow

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.