Re: [PATCH 3/4] Add __global tag where needed.

From: Adrian Bunk <bunk@stusta.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Add __global tag where needed.
Date: Thu, 24 Aug 2006 23:30:47 +0200	[thread overview]
Message-ID: <20060824213047.GR19810@stusta.de> (raw)
In-Reply-To: <1156433212.3012.120.camel@pmac.infradead.org>

On Thu, Aug 24, 2006 at 04:26:52PM +0100, David Woodhouse wrote:

> This patch just adds the __global tag to functions and variables which
> are used from outside the directory in which they're provided, to
> prevent -fwhole-program from eating them.
> 
> If we just define __global as a dummy for now, then there's no harm in
> applying this patch as-is -- but it's largely pointless without the
> Makefile changes.
>...

Applying this doesn't seem to make much sense until it's clear whether a
"build everything except for assembler files at once" approach (that 
needs less globals) or your current "compile only multi-obj at once" 
approach (that requires more globals).

> dwmw2

cu
Adrian

-- 

    Gentoo kernels are 42 times more popular than SUSE kernels among
    KLive users  (a service by SUSE contractor Andrea Arcangeli that
    gathers data about kernels from many users worldwide).

       There are three kinds of lies: Lies, Damn Lies, and Statistics.
                                                    Benjamin Disraeli