All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yoshfuji@linux-ipv6.org
Cc: brian.haley@hp.com, netdev@vger.kernel.org
Subject: Re: [GIT PATCH] IPv6 Updates for net-2.6.19
Date: Fri, 25 Aug 2006 16:06:58 -0700 (PDT)	[thread overview]
Message-ID: <20060825.160658.55726449.davem@davemloft.net> (raw)
In-Reply-To: <20060826.074438.22263593.yoshfuji@linux-ipv6.org>

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 26 Aug 2006 07:44:38 +0900 (JST)

> In article <44EF4F95.7030305@hp.com> (at Fri, 25 Aug 2006 15:29:25 -0400), Brian Haley <brian.haley@hp.com> says:
> 
> > >  				.saddr = iph->saddr,
> > > +				.fwmark = skb->nfmark,
> > >  				.flowlabel = (* (u32 *) iph)&IPV6_FLOWINFO_MASK,
> :
> > I can't build the latest 2.6.19-git with this patch, skb->nfmark 
> > requires CONFIG_NETFILTER, which isn't in my .config.  The obvious 
> > workaround is the patch below, but that might not be what you want.  Can 
> > send my .config if you need it.
> 
> Your fix is appropriate.
> 
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

It seems to make better sense to protect this with
IPV6_ROUTE_FWMARK instead of NETFILTER.  And it is
consistent with ipv4 side.

So that's how I will fix this build problem.

Thanks.

  reply	other threads:[~2006-08-25 23:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-24 18:00 [GIT PATCH] IPv6 Updates for net-2.6.19 YOSHIFUJI Hideaki / 吉藤英明
2006-08-25  8:21 ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-25 17:50   ` Thomas Graf
2006-08-25 19:29 ` Brian Haley
2006-08-25 22:44   ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-25 23:06     ` David Miller [this message]
2006-08-25 23:11       ` YOSHIFUJI Hideaki / 吉藤英明
2006-09-18 15:08 [GIT PATCH] IPV6: " YOSHIFUJI Hideaki / 吉藤英明
     [not found] ` <45101A35.6060908@6wind.com>
2006-09-20  3:46   ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825.160658.55726449.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brian.haley@hp.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.