All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, usagi-core@linux-ipv6.org
Subject: Re: [GIT PATCH] IPv6 Updates for net-2.6.19
Date: Fri, 25 Aug 2006 19:50:46 +0200	[thread overview]
Message-ID: <20060825175046.GT3470@postel.suug.ch> (raw)
In-Reply-To: <20060825.172130.112746083.yoshfuji@linux-ipv6.org>

* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <yoshfuji@linux-ipv6.org> 2006-08-25 17:21
> commit 10204d532f5f8bb379009ba0bee2113bafda72be
> Author: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Date:   Mon Aug 21 19:22:01 2006 +0900
> 
>     [IPV6] ROUTE: Routing by FWMARK.
>     
>     Based on patch by Jean Lorchat <lorchat@sfc.wide.ad.jp>.
>     
>     Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> 
> diff --git a/include/linux/fib_rules.h b/include/linux/fib_rules.h
> index 19a82b6..2987549 100644
> --- a/include/linux/fib_rules.h
> +++ b/include/linux/fib_rules.h
> @@ -34,7 +34,7 @@ enum
>  	FRA_UNUSED3,
>  	FRA_UNUSED4,
>  	FRA_UNUSED5,
> -	FRA_FWMARK,	/* netfilter mark (IPv4) */
> +	FRA_FWMARK,	/* netfilter mark (IPv4/IPv6) */
>  	FRA_FLOW,	/* flow/class id */
>  	FRA_UNUSED6,
>  	FRA_UNUSED7,

You're missing the validation policy entry for FRA_FWMARK
in the IPv6 policy.

> diff --git a/include/net/flow.h b/include/net/flow.h
> index e052291..3ca210e 100644
> --- a/include/net/flow.h
> +++ b/include/net/flow.h
> @@ -26,6 +26,7 @@ struct flowi {
>  		struct {
>  			struct in6_addr		daddr;
>  			struct in6_addr		saddr;
> +			__u32			fwmark;
>  			__u32			flowlabel;
>  		} ip6_u;

Since all flowi users now use fwmark it can be moved out
of the union.

> diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
> index 91f6233..aebd9e2 100644
> --- a/net/ipv6/fib6_rules.c
> +++ b/net/ipv6/fib6_rules.c
> @@ -26,6 +26,9 @@ struct fib6_rule
>  	struct fib_rule		common;
>  	struct rt6key		src;
>  	struct rt6key		dst;
> +#ifdef CONFIG_IPV6_ROUTE_FWMARK
> +	u8			fwmark;
> +#endif
>  	u8			tclass;
>  };

This doesn't look right.

  reply	other threads:[~2006-08-25 17:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-24 18:00 [GIT PATCH] IPv6 Updates for net-2.6.19 YOSHIFUJI Hideaki / 吉藤英明
2006-08-25  8:21 ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-25 17:50   ` Thomas Graf [this message]
2006-08-25 19:29 ` Brian Haley
2006-08-25 22:44   ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-25 23:06     ` David Miller
2006-08-25 23:11       ` YOSHIFUJI Hideaki / 吉藤英明
2006-09-18 15:08 [GIT PATCH] IPV6: " YOSHIFUJI Hideaki / 吉藤英明
     [not found] ` <45101A35.6060908@6wind.com>
2006-09-20  3:46   ` YOSHIFUJI Hideaki / 吉藤英明

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825175046.GT3470@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=usagi-core@linux-ipv6.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.