missing log_success_msg?

missing log_success_msg?

[Sean Dague]

[-- Attachment #1.1: Type: text/plain, Size: 892 bytes --]

Where is log_success_msg bash function supposed to be coming from?  It is
used in /etc/init.d/xendomains, and at least on my FC5 test system doesn't
seem to exist anywhere.

root@nibbler:~> service xendomains start
xendomains already running (lockfile exists)/etc/init.d/xendomains: line 67:
log_success_msg: command not found

It only seems to appear in the xendomains script:

root@nibbler:~/code/xen-unstable> grep -r log_success_msg *
dist/install/etc/init.d/xendomains:             log_success_msg "
[${_SMSG[${_RC_RV}]}] "
tools/examples/init.d/xendomains:               log_success_msg "
[${_SMSG[${_RC_RV}]}] "

This seems like a simple cosmetic issue that should be corrected prior to
3.0.3.

	-Sean

-- 
Sean Dague
IBM Linux Technology Center                     email: japh@us.ibm.com
Open Hypervisor Team                           alt: sldague@us.ibm.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 191 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: missing log_success_msg?

[Ewan Mellor]

On Fri, Aug 25, 2006 at 02:58:33PM -0400, Sean Dague wrote:

> Where is log_success_msg bash function supposed to be coming from?  It is
> used in /etc/init.d/xendomains, and at least on my FC5 test system doesn't
> seem to exist anywhere.
> 
> root@nibbler:~> service xendomains start
> xendomains already running (lockfile exists)/etc/init.d/xendomains: line 67:
> log_success_msg: command not found
> 
> It only seems to appear in the xendomains script:
> 
> root@nibbler:~/code/xen-unstable> grep -r log_success_msg *
> dist/install/etc/init.d/xendomains:             log_success_msg "
> [${_SMSG[${_RC_RV}]}] "
> tools/examples/init.d/xendomains:               log_success_msg "
> [${_SMSG[${_RC_RV}]}] "
> 
> This seems like a simple cosmetic issue that should be corrected prior to
> 3.0.3.

Well, since the script looks like this:

    if test -e /lib/lsb/init-functions; then
        # LSB
        . /lib/lsb/init-functions
        echo_rc()
        {
            if test ${_RC_RV} = 0; then
                log_success_msg "  [${_SMSG[${_RC_RV}]}] "
            else
                log_failure_msg "  [${_SMSG[${_RC_RV}]}] "
            fi
        }

I reckon someone expects it to be in /lib/lsb/init-functions.  Any
distro code-monkeys out there?

Ewan.

Re: missing log_success_msg?

[Sean Dague]

[-- Attachment #1.1: Type: text/plain, Size: 2687 bytes --]

On Fri, Aug 25, 2006 at 08:02:41PM +0100, Ewan Mellor wrote:
> On Fri, Aug 25, 2006 at 02:58:33PM -0400, Sean Dague wrote:
> 
> > Where is log_success_msg bash function supposed to be coming from?  It is
> > used in /etc/init.d/xendomains, and at least on my FC5 test system doesn't
> > seem to exist anywhere.
> > 
> > root@nibbler:~> service xendomains start
> > xendomains already running (lockfile exists)/etc/init.d/xendomains: line 67:
> > log_success_msg: command not found
> > 
> > It only seems to appear in the xendomains script:
> > 
> > root@nibbler:~/code/xen-unstable> grep -r log_success_msg *
> > dist/install/etc/init.d/xendomains:             log_success_msg "
> > [${_SMSG[${_RC_RV}]}] "
> > tools/examples/init.d/xendomains:               log_success_msg "
> > [${_SMSG[${_RC_RV}]}] "
> > 
> > This seems like a simple cosmetic issue that should be corrected prior to
> > 3.0.3.
> 
> Well, since the script looks like this:
> 
>     if test -e /lib/lsb/init-functions; then
>         # LSB
>         . /lib/lsb/init-functions
>         echo_rc()
>         {
>             if test ${_RC_RV} = 0; then
>                 log_success_msg "  [${_SMSG[${_RC_RV}]}] "
>             else
>                 log_failure_msg "  [${_SMSG[${_RC_RV}]}] "
>             fi
>         }
> 
> I reckon someone expects it to be in /lib/lsb/init-functions.  Any
> distro code-monkeys out there?

Fwiw, /lib/lsb/init-functions exists on FC5, and looks like the following:


root@nibbler:~> cat /lib/lsb/init-functions 
#!/bin/sh

# LSB initscript functions, as defined in the LSB Spec 1.1.0

alias start_daemon="/etc/redhat-lsb/lsb_start_daemon"
alias killproc="/etc/redhat-lsb/lsb_killproc"
alias pidofproc="/etc/redhat-lsb/lsb_pidofproc"
alias log_success_msg="/etc/redhat-lsb/lsb_log_message success"
alias log_failure_msg="/etc/redhat-lsb/lsb_log_message failure"
alias log_warning_msg="/etc/redhat-lsb/lsb_log_message warning"


root@nibbler:~> cat /etc/redhat-lsb/lsb_log_message
#!/bin/bash

. /etc/init.d/functions

ACTION=$1
shift

case "$ACTION" in
  success)
        echo -n $*
        success "$*"
        echo
        ;;
  failure)
        echo -n $*
        failure "$*"
        echo
        ;;
  warning)
        echo -n $*
        warning "$*"
        echo
        ;;
  *)
        ;;
esac
exit 0


my bash-foo is nearly none, so any bash folks that understand why this might
be not working would be appreciated.

	-Sean

-- 
Sean Dague
IBM Linux Technology Center                     email: japh@us.ibm.com
Open Hypervisor Team                           alt: sldague@us.ibm.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 191 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel