* [2.4 PATCH] sparc64 dma parenthesis fixes
@ 2006-12-04 9:44 Mariusz Kozlowski
2006-12-04 17:31 ` David Miller
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mariusz Kozlowski @ 2006-12-04 9:44 UTC (permalink / raw)
To: sparclinux
Hello,
This patch fixes some sparc64 dma macros.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
include/asm-sparc64/dma.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.4.34-pre6-a/include/asm-sparc64/dma.h 2000-02-01 08:37:19.000000000 +0100
+++ linux-2.4.34-pre6-b/include/asm-sparc64/dma.h 2006-12-01 12:00:23.000000000 +0100
@@ -153,9 +153,9 @@ extern void dvma_init(struct sbus_bus *)
#define DMA_MAXEND(addr) (0x01000000UL-(((unsigned long)(addr))&0x00ffffffUL))
/* Yes, I hack a lot of elisp in my spare time... */
-#define DMA_ERROR_P(regs) (((sbus_readl((regs) + DMA_CSR) & DMA_HNDL_ERROR))
-#define DMA_IRQ_P(regs) (((sbus_readl((regs) + DMA_CSR)) & (DMA_HNDL_INTR | DMA_HNDL_ERROR)))
-#define DMA_WRITE_P(regs) (((sbus_readl((regs) + DMA_CSR) & DMA_ST_WRITE))
+#define DMA_ERROR_P(regs) (sbus_readl((regs) + DMA_CSR) & DMA_HNDL_ERROR)
+#define DMA_IRQ_P(regs) ((sbus_readl((regs) + DMA_CSR)) & (DMA_HNDL_INTR | DMA_HNDL_ERROR))
+#define DMA_WRITE_P(regs) (sbus_readl((regs) + DMA_CSR) & DMA_ST_WRITE)
#define DMA_OFF(__regs) \
do { u32 tmp = sbus_readl((__regs) + DMA_CSR); \
tmp &= ~DMA_ENABLE; \
--
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.4 PATCH] sparc64 dma parenthesis fixes
2006-12-04 9:44 [2.4 PATCH] sparc64 dma parenthesis fixes Mariusz Kozlowski
@ 2006-12-04 17:31 ` David Miller
2006-12-04 18:21 ` Mariusz Kozlowski
2006-12-04 18:24 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2006-12-04 17:31 UTC (permalink / raw)
To: sparclinux
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Mon, 4 Dec 2006 10:44:19 +0100
> Hello,
>
> This patch fixes some sparc64 dma macros.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
I applied this patch already, and I sent you an email telling
you this over the weekend.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.4 PATCH] sparc64 dma parenthesis fixes
2006-12-04 9:44 [2.4 PATCH] sparc64 dma parenthesis fixes Mariusz Kozlowski
2006-12-04 17:31 ` David Miller
@ 2006-12-04 18:21 ` Mariusz Kozlowski
2006-12-04 18:24 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Mariusz Kozlowski @ 2006-12-04 18:21 UTC (permalink / raw)
To: sparclinux
Hello,
> > This patch fixes some sparc64 dma macros.
> >
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> I applied this patch already, and I sent you an email telling
> you this over the weekend.
Thanks. That was against 2.6. I thought 2.4 needs separate patch.
--
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.4 PATCH] sparc64 dma parenthesis fixes
2006-12-04 9:44 [2.4 PATCH] sparc64 dma parenthesis fixes Mariusz Kozlowski
2006-12-04 17:31 ` David Miller
2006-12-04 18:21 ` Mariusz Kozlowski
@ 2006-12-04 18:24 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2006-12-04 18:24 UTC (permalink / raw)
To: sparclinux
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Mon, 4 Dec 2006 19:21:51 +0100
> > > This patch fixes some sparc64 dma macros.
> > >
> > > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> >
> > I applied this patch already, and I sent you an email telling
> > you this over the weekend.
>
> Thanks. That was against 2.6. I thought 2.4 needs separate patch.
Aha, I didn't catch that, my mind thought this was
another submission on the 2.6.x side, sorry :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.4 PATCH] sparc64 dma parenthesis fixes
@ 2006-12-01 15:36 Mariusz Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Mariusz Kozlowski @ 2006-12-01 15:36 UTC (permalink / raw)
To: Willy Tarreau; +Cc: linux-kernel
Hello,
This patch fixes some sparc64 dma macros.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
include/asm-sparc64/dma.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.4.34-pre6-a/include/asm-sparc64/dma.h 2000-02-01 08:37:19.000000000 +0100
+++ linux-2.4.34-pre6-b/include/asm-sparc64/dma.h 2006-12-01 12:00:23.000000000 +0100
@@ -153,9 +153,9 @@ extern void dvma_init(struct sbus_bus *)
#define DMA_MAXEND(addr) (0x01000000UL-(((unsigned long)(addr))&0x00ffffffUL))
/* Yes, I hack a lot of elisp in my spare time... */
-#define DMA_ERROR_P(regs) (((sbus_readl((regs) + DMA_CSR) & DMA_HNDL_ERROR))
-#define DMA_IRQ_P(regs) (((sbus_readl((regs) + DMA_CSR)) & (DMA_HNDL_INTR | DMA_HNDL_ERROR)))
-#define DMA_WRITE_P(regs) (((sbus_readl((regs) + DMA_CSR) & DMA_ST_WRITE))
+#define DMA_ERROR_P(regs) (sbus_readl((regs) + DMA_CSR) & DMA_HNDL_ERROR)
+#define DMA_IRQ_P(regs) ((sbus_readl((regs) + DMA_CSR)) & (DMA_HNDL_INTR | DMA_HNDL_ERROR))
+#define DMA_WRITE_P(regs) (sbus_readl((regs) + DMA_CSR) & DMA_ST_WRITE)
#define DMA_OFF(__regs) \
do { u32 tmp = sbus_readl((__regs) + DMA_CSR); \
tmp &= ~DMA_ENABLE; \
--
Regards,
Mariusz Kozlowski
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-04 18:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-04 9:44 [2.4 PATCH] sparc64 dma parenthesis fixes Mariusz Kozlowski
2006-12-04 17:31 ` David Miller
2006-12-04 18:21 ` Mariusz Kozlowski
2006-12-04 18:24 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-12-01 15:36 Mariusz Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.