All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: -mm merge plans for 2.6.20
Date: Wed, 6 Dec 2006 16:22:44 +0100	[thread overview]
Message-ID: <20061206152244.GA24613@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0612061422190.1867@scrub.home>


* Roman Zippel <zippel@linux-m68k.org> wrote:

> > > > If I understand it correctly, Roman wants clockevents to be usable 
> > > > for other things aside hrtimer/dyntick, i.e. let other code request 
> > > > unused timer event hardware for special purposes. I thought about 
> > > > that in the originally but I stayed away from it, as there are no 
> > > > users at the moment and I wanted to avoid the usual "who needs that" 
> > > > comment.
> > > 
> > > Nonsense, [...]
> > 
> > why do you call Thomas' observation nonsense?
> 
> What's the point of this question? [...]

the point of my question was what it said: to ask you why you called 
Thomas' pretty fair observation 'nonsense'.

> [...] Your answer is/was in the "[...]" part.

meaning:

> > > [...] one obvious user would be the scheduler, [...]

but that is not a refutation of what Thomas said, at all. You say that 
the scheduler /could/ use such a facility. What Thomas said was that 
/there are no current users of such a facility/. It is a really simple 
(and unconditionally true) observation from Thomas. Yes, we could change 
other kernel code not directly related to high-res timers, but we chose 
not to.

[ The word 'nonsense' is in general a negative descriptor and implies 
  that what Thomas said was 'obviously false' - while in reality what we
  have is /at most/ a difference in opinion. I.e. even if our opinion 
  differs you shouldnt call his opinion "nonsense", unless you are 
  willing to prove that it's false - which you didnt do so far. I claim 
  that what Thomas said is /unconditionally true/, and i can prove it: 
  it is unconditionally true that such a new facility is not needed
  by our code, and that no other kernel code is using it at the moment -
  because the facility does not exist yet. If you misunderstood what 
  Thomas said then please point that out, or prove that his claims are 
  untrue - thanks. ]

> > Fact: there is no current user of such a facility. What we 
> > implemented, high-res timers and dynticks does not need such a 
> > facility.
> 
> Fact: there _are_ users which need a timer facility (e.g. the 
> scheduler).

this is something we are not contesting at all: that a new timer 
facility /could/ be used by /other/ kernel code, which does /not/ use it 
right now.

our point is simple: the code we add does not in itself necessiate the 
new facility, hence we didnt add it. We didnt want to impact other 
kernel code, just yet. We repeat: we agree (in theory) with such a 
facility, but we wanted to do it separately.

> > we wholeheartedly agree that such a facility 'would be nice', and 
> > 'could be used by existing kernel code' but we didnt want to chew 
> > too much at a time.
> 
> Maybe the existing code should have been cleaned up first? 

yes, we'll do that, and we have a good track record doing such cleanups. 

> Unfortunately the dynticks feature seems to more appealing than clean 
> code...

i think this accusation against us is very unfair.

> > > [...] one obvious user would be the scheduler, [...]
> > 
> > But cleaning up the scheduler tick was not our purpose with high-res 
> > timers nor with dynticks. One of your previous complaints was that the 
> > patches are too intrusive to be trusted. Now they are too simple?
> 
> Would you please stop these personal attacks?

please point it out which portion of the above two sentences you 
consider a personal attack - or if you cannot, please retract your 
baseless accusation.

Fact: you did complain in the past about the complexity and/or 
intrusiveness of our high-res timers patches - we've been working on 
getting high-res timers upstream for more than a year now.

Fact: you did complain about unused facilities in past patches of ours, 
and your feedback caused us significant extra work to remove those 
facilities, just to reintroduce them later again.

(i can provide URLs and Message-IDs for these facts)

this time around we chose the minimalistic approach, we didnt add 
anything that is not immediately needed, and we didnt want to increase 
intrusiveness by "cleaning up" other code and changing it over to the 
new facilities.

It cannot be had both ways: either we stay simpler and less intrusive, 
or we go more generic but more intrusive.

	Ingo

  reply	other threads:[~2006-12-06 15:23 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-05  4:40 -mm merge plans for 2.6.20 Andrew Morton
2006-12-05  4:56 ` Jeff Garzik
2006-12-05  5:41   ` Andrew Morton
2006-12-05  7:04     ` Jens Axboe
2006-12-05 15:00     ` Mark Lord
2006-12-06 19:19     ` Conke Hu
2006-12-06 19:26       ` Randy Dunlap
2006-12-06 19:40       ` Jeff Garzik
2006-12-06 22:36       ` Andrew Morton
2006-12-05  5:14 ` Paul Mackerras
2006-12-05  5:42   ` Andrew Morton
2006-12-05  5:53     ` Nick Piggin
2006-12-05  5:49   ` Nick Piggin
2006-12-05  8:36 ` Gautham R Shenoy
2006-12-05  8:47 ` Peter Zijlstra
2006-12-05 11:06 ` ext2 future [was Re: -mm merge plans for 2.6.20] Pavel Machek
2006-12-05 13:23 ` -mm merge plans for 2.6.20 John W. Linville
2006-12-05 14:27 ` Roman Zippel
2006-12-06  3:46   ` Horst Schirmeier
2006-12-05 16:02 ` Dave Jones
2006-12-12 17:49   ` Dave Jones
2006-12-19  5:20     ` Nick Piggin
2006-12-19  6:44       ` Dave Jones
2006-12-19  7:02         ` Nick Piggin
2007-01-07 17:36       ` page_mapcount(page) went negative Dave Jones
2007-01-10 23:53         ` Nick Piggin
2006-12-05 17:35 ` -mm merge plans for 2.6.20 James Simmons
2006-12-05 18:01   ` Andrew Morton
2006-12-05 18:25     ` James Simmons
2006-12-05 18:37       ` [PATCH] backlight sysfs change to the fbdev drivers James Simmons
2006-12-05 18:37         ` James Simmons
2006-12-05 19:43       ` -mm merge plans for 2.6.20 Andrew Morton
2006-12-05 19:59         ` James Simmons
2006-12-05 20:20           ` Andrew Morton
2006-12-05 21:34             ` James Simmons
2006-12-06 23:40               ` Andrew Morton
2006-12-07 14:31                 ` James Simmons
2006-12-05 20:40       ` Miguel Ojeda
2006-12-06 14:42         ` James Simmons
2006-12-05 19:18 ` Josef Sipek
2006-12-05 19:21   ` [PATCH 1/2] fsstack: Make fsstack_copy_attr_all copy inode size Josef Sipek
2006-12-05 19:22   ` [PATCH 2/2] fsstack: Fix up ecryptfs's fsstack usage Josef Sipek
2006-12-05 22:28     ` Andrew Morton
2006-12-05 22:38       ` Josef Sipek
2006-12-05 22:49         ` Andrew Morton
2006-12-05 23:16           ` Josef Sipek
2006-12-05 21:00 ` -mm merge plans for 2.6.20 Ingo Molnar
2006-12-05 21:17 ` -mm merge plans for 2.6.20, scheduler bits Ingo Molnar
2006-12-05 20:59   ` Siddha, Suresh B
2006-12-05 21:47     ` Ingo Molnar
2006-12-05 21:29   ` Miguel Ojeda
2006-12-06  2:59 ` -mm merge plans for 2.6.20 Roman Zippel
2006-12-06  4:30   ` Andrew Morton
2006-12-06  8:32     ` Thomas Gleixner
2006-12-06 12:54       ` Roman Zippel
2006-12-06 13:11         ` Ingo Molnar
2006-12-06 14:33           ` Roman Zippel
2006-12-06 15:22             ` Ingo Molnar [this message]
2006-12-06 16:42               ` Roman Zippel
2006-12-06 16:58                 ` Ingo Molnar
2006-12-06 16:59                 ` Ingo Molnar
2006-12-12 20:40             ` [RFC] HZ free ntp john stultz
2006-12-13  9:51               ` Ingo Molnar
2006-12-13 18:48                 ` john stultz
2006-12-13 13:47               ` Roman Zippel
2006-12-13 19:19                 ` john stultz
2006-12-13 20:40                   ` Roman Zippel
2006-12-20  1:32                     ` john stultz
2006-12-20  1:54                       ` john stultz
2006-12-21  4:26                         ` Andrew Morton
2007-01-01 18:29                         ` Roman Zippel
2007-01-02 19:46                           ` john stultz
2007-01-02 20:50                             ` john stultz
2007-01-06 16:56                               ` Roman Zippel
2007-01-22 19:27                         ` [patch] HZ-free NTP Ingo Molnar
2007-01-22 19:39                           ` Ingo Molnar
2007-01-01 16:27                       ` [RFC] HZ free ntp Roman Zippel
2007-01-02 19:42                         ` john stultz
2007-01-06 16:46                           ` Roman Zippel
2006-12-06 12:33     ` -mm merge plans for 2.6.20 Roman Zippel
2006-12-08 14:09 ` Stephen Smalley
2006-12-08 20:58   ` Andrew Morton
2006-12-10 15:07     ` Mimi Zohar
2006-12-09  9:30 ` Randy Dunlap
2006-12-09  9:44   ` Andrew Morton
2006-12-10 20:12     ` Randy Dunlap
2006-12-05 23:55 Alessandro Guido
2006-12-06  0:13 ` Andrew Morton
2006-12-08 18:32 Steve French
2006-12-08 21:38 ` Andrew Morton
2006-12-10  3:18 Chuck Ebbert
2006-12-11  4:19 ` Steve French
2006-12-11  9:32 Chuck Ebbert
2006-12-13  1:09 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061206152244.GA24613@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.