* [PATCH] Insert ACTIVESTATE_STRING in Git.pm
@ 2007-01-22 14:32 Alex Riesen
2007-01-22 14:43 ` Alex Riesen
2007-01-22 15:44 ` Petr Baudis
0 siblings, 2 replies; 4+ messages in thread
From: Alex Riesen @ 2007-01-22 14:32 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Petr Baudis
Also add "git" to the pipe parameters, otherwise it does not work at all, as
no git commands are usable out of git context.
---
This is not enough to make it work on ActiveState. It's just to
fix obvious TODOs, which should help someone to get it going.
The other problems are:
- tie refuses to bind a handle class activestate_pipe to a scalar $fh
(a patch follows)
- there are some unexplained warnings about uninitialized values
- cygwin-windows pathname conversion (not fixable at all)
perl/Git.pm | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Insert ACTIVESTATE_STRING in Git.pm
2007-01-22 14:32 [PATCH] Insert ACTIVESTATE_STRING in Git.pm Alex Riesen
@ 2007-01-22 14:43 ` Alex Riesen
2007-01-22 15:44 ` Petr Baudis
1 sibling, 0 replies; 4+ messages in thread
From: Alex Riesen @ 2007-01-22 14:43 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Petr Baudis
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Also add "git" to the pipe parameters, otherwise it does not work at all, as
no git commands are usable out of git context.
---
Oh, fine, just what I needed... Forgot to attach the patch!
> This is not enough to make it work on ActiveState. It's just to
> fix obvious TODOs, which should help someone to get it going.
> The other problems are:
> - tie refuses to bind a handle class activestate_pipe to a scalar $fh
> (a patch follows)
> - there are some unexplained warnings about uninitialized values
> - cygwin-windows pathname conversion (not fixable at all)
>
> perl/Git.pm | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
[-- Attachment #2: 0001-Insert-ACTIVESTATE_STRING-in-Git.pm.patch --]
[-- Type: application/xxxxx, Size: 1249 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm
2007-01-22 14:32 [PATCH] Insert ACTIVESTATE_STRING in Git.pm Alex Riesen
2007-01-22 14:43 ` Alex Riesen
@ 2007-01-22 15:44 ` Petr Baudis
2007-01-22 16:07 ` Alex Riesen
1 sibling, 1 reply; 4+ messages in thread
From: Petr Baudis @ 2007-01-22 15:44 UTC (permalink / raw)
To: Alex Riesen; +Cc: Git Mailing List, Junio C Hamano
On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:
> Also add "git" to the pipe parameters, otherwise it does not work at all, as
> no git commands are usable out of git context.
>
> ---
>
> This is not enough to make it work on ActiveState. It's just to
> fix obvious TODOs, which should help someone to get it going.
> The other problems are:
> - tie refuses to bind a handle class activestate_pipe to a scalar $fh
> (a patch follows)
> - there are some unexplained warnings about uninitialized values
> - cygwin-windows pathname conversion (not fixable at all)
>
> perl/Git.pm | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
Cool.
Acked-by: Petr Baudis <pasky@suse.cz>
Perhaps ACPIPE could use some comment in the code but that's just vain
nitpicking.
--
Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."
-- Kurt Vonnegut, Sirens from Titan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm
2007-01-22 15:44 ` Petr Baudis
@ 2007-01-22 16:07 ` Alex Riesen
0 siblings, 0 replies; 4+ messages in thread
From: Alex Riesen @ 2007-01-22 16:07 UTC (permalink / raw)
To: Petr Baudis; +Cc: Git Mailing List, Junio C Hamano
On 1/22/07, Petr Baudis <pasky@suse.cz> wrote:
> On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:
> > Also add "git" to the pipe parameters, otherwise it does not work at all, as
> > no git commands are usable out of git context.
> >
> > ---
> >
> > This is not enough to make it work on ActiveState. It's just to
> > fix obvious TODOs, which should help someone to get it going.
> > The other problems are:
> > - tie refuses to bind a handle class activestate_pipe to a scalar $fh
> > (a patch follows)
> > - there are some unexplained warnings about uninitialized values
> > - cygwin-windows pathname conversion (not fixable at all)
> >
> > perl/Git.pm | 7 ++++---
> > 1 files changed, 4 insertions(+), 3 deletions(-)
>
> Cool.
>
> Acked-by: Petr Baudis <pasky@suse.cz>
>
> Perhaps ACPIPE could use some comment in the code but that's just vain
> nitpicking.
Will do, with a sign-off this time.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-22 16:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-22 14:32 [PATCH] Insert ACTIVESTATE_STRING in Git.pm Alex Riesen
2007-01-22 14:43 ` Alex Riesen
2007-01-22 15:44 ` Petr Baudis
2007-01-22 16:07 ` Alex Riesen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.