boolian logic bug in vgremove

boolian logic bug in vgremove

[Andre Noll]

[-- Attachment #1.1: Type: text/plain, Size: 1029 bytes --]

Hi

In the argument checking code of vgreduce.c there are two occasions of
'&' that really should be '&&'. Patch below.

Signed-off.by: Andre Noll <maan@systemlinux.org>
---
Index: vgreduce.c
===================================================================
RCS file: /cvs/lvm2/LVM2/tools/vgreduce.c,v
retrieving revision 1.55
diff -u -r1.55 vgreduce.c
--- vgreduce.c	9 Jan 2007 23:14:34 -0000	1.55
+++ vgreduce.c	31 Jan 2007 15:17:01 -0000
@@ -427,13 +427,13 @@
 	int ret = 1;
 	int consistent = 1;
 
-	if (!argc & !arg_count(cmd, removemissing_ARG)) {
+	if (!argc && !arg_count(cmd, removemissing_ARG)) {
 		log_error("Please give volume group name and "
 			  "physical volume paths");
 		return EINVALID_CMD_LINE;
 	}
 
-	if (!argc & arg_count(cmd, removemissing_ARG)) {
+	if (!argc && arg_count(cmd, removemissing_ARG)) {
 		log_error("Please give volume group name");
 		return EINVALID_CMD_LINE;
 	}

Andre
-- 
The only person who always got his work done by Friday was Robinson Crusoe

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: boolian logic bug in vgremove

[Alasdair G Kergon]

On Wed, Jan 31, 2007 at 04:30:06PM +0100, Andre Noll wrote:
> In the argument checking code of vgreduce.c there are two occasions of
> '&' that really should be '&&'. Patch below.
 
Well-spotted - apparently it's been like that for 4 years!

Alasdair
-- 
agk@redhat.com