* [PATCH] atl1_main: pci_module_int returns to haunt us
@ 2007-01-31 17:04 Alan
2007-01-31 22:04 ` Jay Cliburn
0 siblings, 1 reply; 2+ messages in thread
From: Alan @ 2007-01-31 17:04 UTC (permalink / raw)
To: akpm, linux-kernel, jeff
Perhaps Adrian would care to simply delete the pci_module_init ancient compat
code so nobody else can inadvertently merge a driver that uses it.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c
--- linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 14:20:41.000000000 +0000
+++ linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 15:25:29.083361224 +0000
@@ -2482,12 +2482,9 @@
**/
static int __init atl1_init_module(void)
{
- int ret;
printk(KERN_INFO "%s - version %s\n", atl1_driver_string, DRIVER_VERSION);
printk(KERN_INFO "%s\n", atl1_copyright);
- ret = pci_module_init(&atl1_driver);
-
- return ret;
+ return pci_register_driver(&atl1_driver);
}
module_init(atl1_init_module);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] atl1_main: pci_module_int returns to haunt us
2007-01-31 17:04 [PATCH] atl1_main: pci_module_int returns to haunt us Alan
@ 2007-01-31 22:04 ` Jay Cliburn
0 siblings, 0 replies; 2+ messages in thread
From: Jay Cliburn @ 2007-01-31 22:04 UTC (permalink / raw)
To: Alan; +Cc: akpm, linux-kernel, jeff, Chris Snook
Alan wrote:
> Perhaps Adrian would care to simply delete the pci_module_init ancient compat
> code so nobody else can inadvertently merge a driver that uses it.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c
> --- linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 14:20:41.000000000 +0000
> +++ linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 15:25:29.083361224 +0000
> @@ -2482,12 +2482,9 @@
> **/
> static int __init atl1_init_module(void)
> {
> - int ret;
> printk(KERN_INFO "%s - version %s\n", atl1_driver_string, DRIVER_VERSION);
> printk(KERN_INFO "%s\n", atl1_copyright);
> - ret = pci_module_init(&atl1_driver);
> -
> - return ret;
> + return pci_register_driver(&atl1_driver);
> }
>
> module_init(atl1_init_module);
Ack. As expected, works fine. Thanks.
Jay
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-31 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-31 17:04 [PATCH] atl1_main: pci_module_int returns to haunt us Alan
2007-01-31 22:04 ` Jay Cliburn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.