* [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking
@ 2007-02-05 16:45 Sergei Shtylyov
2007-02-07 0:54 ` Jeff Garzik
2009-05-31 13:25 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2007-02-05 16:45 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, alan
Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
fast timing bank starting with PIO2, just like the ata_piix driver does.
Also, fix/rephrase some comments while at it.
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
drivers/ata/pata_oldpiix.c | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
Index: linux-2.6/drivers/ata/pata_oldpiix.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_oldpiix.c
+++ linux-2.6/drivers/ata/pata_oldpiix.c
@@ -25,7 +25,7 @@
#include <linux/ata.h>
#define DRV_NAME "pata_oldpiix"
-#define DRV_VERSION "0.5.2"
+#define DRV_VERSION "0.5.3"
/**
* oldpiix_pre_reset - probe begin
@@ -94,19 +94,21 @@ static void oldpiix_set_piomode (struct
{ 2, 1 },
{ 2, 3 }, };
- if (pio > 2)
- control |= 1; /* TIME1 enable */
+ if (pio > 1)
+ control |= 1; /* TIME */
if (ata_pio_need_iordy(adev))
- control |= 2; /* IE IORDY */
+ control |= 2; /* IE */
- /* Intel specifies that the PPE functionality is for disk only */
+ /* Intel specifies that the prefetch/posting is for disk only */
if (adev->class == ATA_DEV_ATA)
- control |= 4; /* PPE enable */
+ control |= 4; /* PPE */
pci_read_config_word(dev, idetm_port, &idetm_data);
- /* Enable PPE, IE and TIME as appropriate. Clear the other
- drive timing bits */
+ /*
+ * Set PPE, IE and TIME as appropriate.
+ * Clear the other drive's timing bits.
+ */
if (adev->devno == 0) {
idetm_data &= 0xCCE0;
idetm_data |= control;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking
2007-02-05 16:45 [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking Sergei Shtylyov
@ 2007-02-07 0:54 ` Jeff Garzik
2009-05-31 13:25 ` Sergei Shtylyov
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2007-02-07 0:54 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, alan
Sergei Shtylyov wrote:
> Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> fast timing bank starting with PIO2, just like the ata_piix driver does.
> Also, fix/rephrase some comments while at it.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> drivers/ata/pata_oldpiix.c | 18 ++++++++++--------
> 1 files changed, 10 insertions(+), 8 deletions(-)
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking
2007-02-05 16:45 [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking Sergei Shtylyov
2007-02-07 0:54 ` Jeff Garzik
@ 2009-05-31 13:25 ` Sergei Shtylyov
2009-06-01 13:41 ` Alan Cox
1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2009-05-31 13:25 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, alan
Hello, I wrote:
> Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> fast timing bank starting with PIO2, just like the ata_piix driver does.
> Also, fix/rephrase some comments while at it.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Hm, looks like pata_efar still needs the same fix...
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking
2009-05-31 13:25 ` Sergei Shtylyov
@ 2009-06-01 13:41 ` Alan Cox
2009-06-01 14:21 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2009-06-01 13:41 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: jgarzik, linux-ide
On Sun, 31 May 2009 17:25:14 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> Hello, I wrote:
>
> > Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
> > fast timing bank starting with PIO2, just like the ata_piix driver does.
> > Also, fix/rephrase some comments while at it.
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> Hm, looks like pata_efar still needs the same fix...
I can't find the original email (not in my archive for 2008 or 2009) but
the comment makes sense
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking
2009-06-01 13:41 ` Alan Cox
@ 2009-06-01 14:21 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2009-06-01 14:21 UTC (permalink / raw)
To: Alan Cox; +Cc: jgarzik, linux-ide
Alan Cox wrote:
>>Hello, I wrote:
>>>Fix the PIO mode 2 using mode 0 timings -- this driver should enable the
>>>fast timing bank starting with PIO2, just like the ata_piix driver does.
>>>Also, fix/rephrase some comments while at it.
>>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> Hm, looks like pata_efar still needs the same fix...
> I can't find the original email (not in my archive for 2008 or 2009) but
> the comment makes sense
It was the patch merged back in 2007. I'll submit the pata_efar patch
shortly.
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-01 14:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-05 16:45 [PATCH] (2.6.20) pata_oldpiix: fix PIO2 underclocking Sergei Shtylyov
2007-02-07 0:54 ` Jeff Garzik
2009-05-31 13:25 ` Sergei Shtylyov
2009-06-01 13:41 ` Alan Cox
2009-06-01 14:21 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.