* Fw: [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2)
@ 2007-02-08 0:42 Shinta Sugimoto
2007-02-08 0:52 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Shinta Sugimoto @ 2007-02-08 0:42 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Dear David,
I noticed that I sent wrong version (not the newest one) of the
patch set by mistake. I will re-post the patch set soon, so could
you please wait for that? I am sorry for the confusion.
Regards,
Shinta
Forwarded by Shinta Sugimoto <shinta@sfc.wide.ad.jp>
----------------------- Original Message -----------------------
From: Shinta Sugimoto <shinta@sfc.wide.ad.jp>
To: netdev@vger.kernel.org
Cc: Francis Dupont <Francis.Dupont@point6.net>,
Masahide Nakamura <nakam@linux-ipv6.org>,
yoshfuji@linux-ipv6.org,
usagi-core@linux-ipv6.org
Date: Wed, 07 Feb 2007 22:17:41 +0900
Subject: [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2)
----
Hello,
Let me send an updated version of patch set of MIGRATE support
for XFRM/PFKEYv2. About a week ago, I sent a request for comments
for this patch set. All the comments received were taken into
account. In summary, the changes are as follow:
- replace alloc & memcpy with kmemdup
- remove unnecessary null-check
- fix bugs in handling protocol value for selector
- add sanity check for handling MIGRATE message from PF_KEY socket
- some other minor changes
Please note that the patch set is against current net-2.6.21
tree and these changes are available in the branch named
"migrate-20070207-2131" at:
git://git.linux-ipv6.org/gitroot/shinta/net-2.6.21-migrate.git
Regards,
Shinta
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--------------------- Original Message Ends --------------------
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2)
2007-02-08 0:42 Fw: [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2) Shinta Sugimoto
@ 2007-02-08 0:52 ` David Miller
2007-02-08 21:32 ` [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint Eric Dumazet
2007-02-08 21:33 ` [PATCH 1/5] NET : Introduce union in struct dst_entry to hold 'next' pointer Eric Dumazet
0 siblings, 2 replies; 7+ messages in thread
From: David Miller @ 2007-02-08 0:52 UTC (permalink / raw)
To: shinta; +Cc: netdev
From: Shinta Sugimoto <shinta@sfc.wide.ad.jp>
Date: Thu, 08 Feb 2007 09:42:00 +0900
> I noticed that I sent wrong version (not the newest one) of the
> patch set by mistake. I will re-post the patch set soon, so could
> you please wait for that? I am sorry for the confusion.
Ok, no problem.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint
2007-02-08 0:52 ` David Miller
@ 2007-02-08 21:32 ` Eric Dumazet
2007-02-10 1:31 ` David Miller
2007-02-08 21:33 ` [PATCH 1/5] NET : Introduce union in struct dst_entry to hold 'next' pointer Eric Dumazet
1 sibling, 1 reply; 7+ messages in thread
From: Eric Dumazet @ 2007-02-08 21:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi David
Large routers/servers spend lot of CPU time in route cache lookups. This is
because each item lookup uses two cache lines : the next pointer is at the
begining of item, but keys are far away from this pointer.
Furthermore, the u unions declared in struct rtable, rt6_info and dn_route are
imho quite ugly (forcing next pointer be at null offset)
This patch try to cleanup the layering and try to put the 'next' pointer near
the fields used at lookup time (in ip_route_input() for example)
I prepared the following five patches :
[PATCH 1/5] : Introduce union in struct dst_entry, to prepare patches 2,3,4
[PATCH 2/5] : Convert ipv4 route to use the new dst_entry 'next' pointer
[PATCH 3/5] : Convert ipv6 route to use the new dst_entry 'next' pointer
[PATCH 4/5] : Convert decnet route to use the new dst_entry 'next' pointer
[PATCH 5/5] : Reorder fields of struct dst_entry
Thank you
Eric Dumazet
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint
2007-02-08 21:32 ` [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint Eric Dumazet
@ 2007-02-10 1:31 ` David Miller
2007-02-10 8:17 ` Eric Dumazet
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2007-02-10 1:31 UTC (permalink / raw)
To: dada1; +Cc: netdev
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Thu, 08 Feb 2007 22:32:10 +0100
> I prepared the following five patches :
>
> [PATCH 1/5] : Introduce union in struct dst_entry, to prepare patches 2,3,4
> [PATCH 2/5] : Convert ipv4 route to use the new dst_entry 'next' pointer
> [PATCH 3/5] : Convert ipv6 route to use the new dst_entry 'next' pointer
> [PATCH 4/5] : Convert decnet route to use the new dst_entry 'next' pointer
> [PATCH 5/5] : Reorder fields of struct dst_entry
I've applied all of this, and fixed up the changelog description
of patch #4 as-needed :-)
Thanks a lot Eric.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint
2007-02-10 1:31 ` David Miller
@ 2007-02-10 8:17 ` Eric Dumazet
0 siblings, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2007-02-10 8:17 UTC (permalink / raw)
To: David Miller; +Cc: netdev
David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Thu, 08 Feb 2007 22:32:10 +0100
>
>> I prepared the following five patches :
>>
>> [PATCH 1/5] : Introduce union in struct dst_entry, to prepare patches 2,3,4
>> [PATCH 2/5] : Convert ipv4 route to use the new dst_entry 'next' pointer
>> [PATCH 3/5] : Convert ipv6 route to use the new dst_entry 'next' pointer
>> [PATCH 4/5] : Convert decnet route to use the new dst_entry 'next' pointer
>> [PATCH 5/5] : Reorder fields of struct dst_entry
>
> I've applied all of this, and fixed up the changelog description
> of patch #4 as-needed :-)
>
> Thanks a lot Eric.
I was about to correct this stuff this saturday morning, so *many* thanks to
you David, I can start my week end like normal guys :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] NET : Introduce union in struct dst_entry to hold 'next' pointer
2007-02-08 0:52 ` David Miller
2007-02-08 21:32 ` [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint Eric Dumazet
@ 2007-02-08 21:33 ` Eric Dumazet
1 sibling, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2007-02-08 21:33 UTC (permalink / raw)
To: David Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
This patch introduces an anonymous union to nicely express the fact that all
objects inherited from struct dst_entry should access to the generic 'next'
pointer but with appropriate type verification.
This patch is a prereq before following patches.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: introduce_union_in_dst_entry.patch --]
[-- Type: text/plain, Size: 458 bytes --]
--- linux-2.6.20/include/net/dst.h 2007-02-08 21:06:15.000000000 +0100
+++ linux-2.6.20-ed/include/net/dst.h 2007-02-08 21:07:21.000000000 +0100
@@ -37,7 +37,12 @@ struct sk_buff;
struct dst_entry
{
- struct dst_entry *next;
+ union {
+ struct dst_entry *next;
+ struct rtable *rt_next;
+ struct rt6_info *rt6_next;
+ struct dn_route *dn_next;
+ };
atomic_t __refcnt; /* client references */
int __use;
struct dst_entry *child;
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2)
@ 2007-02-07 13:17 Shinta Sugimoto
0 siblings, 0 replies; 7+ messages in thread
From: Shinta Sugimoto @ 2007-02-07 13:17 UTC (permalink / raw)
To: netdev; +Cc: Francis Dupont, Masahide Nakamura, yoshfuji, usagi-core
Hello,
Let me send an updated version of patch set of MIGRATE support
for XFRM/PFKEYv2. About a week ago, I sent a request for comments
for this patch set. All the comments received were taken into
account. In summary, the changes are as follow:
- replace alloc & memcpy with kmemdup
- remove unnecessary null-check
- fix bugs in handling protocol value for selector
- add sanity check for handling MIGRATE message from PF_KEY socket
- some other minor changes
Please note that the patch set is against current net-2.6.21
tree and these changes are available in the branch named
"migrate-20070207-2131" at:
git://git.linux-ipv6.org/gitroot/shinta/net-2.6.21-migrate.git
Regards,
Shinta
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-02-10 8:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08 0:42 Fw: [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2) Shinta Sugimoto
2007-02-08 0:52 ` David Miller
2007-02-08 21:32 ` [PATCH 0/5] NET Improve layering of structs dst_entry/rtable/rt6_info/dn_route to get less dcache footprint Eric Dumazet
2007-02-10 1:31 ` David Miller
2007-02-10 8:17 ` Eric Dumazet
2007-02-08 21:33 ` [PATCH 1/5] NET : Introduce union in struct dst_entry to hold 'next' pointer Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2007-02-07 13:17 [PATCH 0/5] [XFRM,PFKEYV2]: MIGRATE support (take 2) Shinta Sugimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.