* [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
@ 2007-02-07 6:49 ` Horms
0 siblings, 0 replies; 8+ messages in thread
From: Horms @ 2007-02-07 6:49 UTC (permalink / raw)
To: linux-ia64, linux-kernel, fastboot
Cc: Zou Nan hai, Khalid Aziz, Adrian Bunk, Tony Luck, Andrew Morton,
Magnus Damm
kexec.h is needed by arch/ia64/kernel/process.c so for the
declaration of kexec_disable_iosapic() which is used in machine_shutdown().
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/kernel/process.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/process.c 2007-02-07 12:43:09.000000000 +0900
+++ linux-2.6/arch/ia64/kernel/process.c 2007-02-07 12:43:16.000000000 +0900
@@ -41,6 +41,7 @@
#include <asm/uaccess.h>
#include <asm/unwind.h>
#include <asm/user.h>
+#include <asm/kexec.h>
#include "entry.h"
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
@ 2007-02-07 6:49 ` Horms
0 siblings, 0 replies; 8+ messages in thread
From: Horms @ 2007-02-07 6:49 UTC (permalink / raw)
To: linux-ia64, linux-kernel, fastboot
Cc: Zou Nan hai, Khalid Aziz, Adrian Bunk, Tony Luck, Andrew Morton,
Magnus Damm
kexec.h is needed by arch/ia64/kernel/process.c so for the
declaration of kexec_disable_iosapic() which is used in machine_shutdown().
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/kernel/process.c
=================================--- linux-2.6.orig/arch/ia64/kernel/process.c 2007-02-07 12:43:09.000000000 +0900
+++ linux-2.6/arch/ia64/kernel/process.c 2007-02-07 12:43:16.000000000 +0900
@@ -41,6 +41,7 @@
#include <asm/uaccess.h>
#include <asm/unwind.h>
#include <asm/user.h>
+#include <asm/kexec.h>
#include "entry.h"
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
2007-02-07 6:49 ` Horms
@ 2007-02-07 17:07 ` Luck, Tony
-1 siblings, 0 replies; 8+ messages in thread
From: Luck, Tony @ 2007-02-07 17:07 UTC (permalink / raw)
To: Horms, linux-ia64, linux-kernel, fastboot
Cc: Zou, Nanhai, Khalid Aziz, Adrian Bunk, Andrew Morton, Magnus Damm
> kexec.h is needed by arch/ia64/kernel/process.c so for the
> declaration of kexec_disable_iosapic() which is used in machine_shutdown().
> +#include <asm/kexec.h>
I merged this into your earlier change (moving machine_shutdown() into
process.c). Linus pulled it last night.
I also added a "#ifdef CONFIG_KEXEC" around the call to kexec_disable_iosapic()
(because I first noticed that this was undefined when building non-KEXEC kernels).
But perhaps it might have been better to #define an empty stub for this function
inside kexec.h for the #ifndef CONFIG_KEXEC case?
-Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
@ 2007-02-07 17:07 ` Luck, Tony
0 siblings, 0 replies; 8+ messages in thread
From: Luck, Tony @ 2007-02-07 17:07 UTC (permalink / raw)
To: Horms, linux-ia64, linux-kernel, fastboot
Cc: Zou, Nanhai, Khalid Aziz, Adrian Bunk, Andrew Morton, Magnus Damm
> kexec.h is needed by arch/ia64/kernel/process.c so for the
> declaration of kexec_disable_iosapic() which is used in machine_shutdown().
> +#include <asm/kexec.h>
I merged this into your earlier change (moving machine_shutdown() into
process.c). Linus pulled it last night.
I also added a "#ifdef CONFIG_KEXEC" around the call to kexec_disable_iosapic()
(because I first noticed that this was undefined when building non-KEXEC kernels).
But perhaps it might have been better to #define an empty stub for this function
inside kexec.h for the #ifndef CONFIG_KEXEC case?
-Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
2007-02-07 17:07 ` Luck, Tony
@ 2007-02-08 2:19 ` Horms
-1 siblings, 0 replies; 8+ messages in thread
From: Horms @ 2007-02-08 2:19 UTC (permalink / raw)
To: Luck, Tony
Cc: linux-ia64, linux-kernel, fastboot, Zou, Nanhai, Khalid Aziz,
Adrian Bunk, Andrew Morton, Magnus Damm
On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > declaration of kexec_disable_iosapic() which is used in
> > machine_shutdown().
>
> > +#include <asm/kexec.h>
>
> I merged this into your earlier change (moving machine_shutdown() into
> process.c). Linus pulled it last night.
Thanks
> I also added a "#ifdef CONFIG_KEXEC" around the call to
> kexec_disable_iosapic() (because I first noticed that this was
> undefined when building non-KEXEC kernels). But perhaps it might have
> been better to #define an empty stub for this function inside kexec.h
> for the #ifndef CONFIG_KEXEC case?
Good catch :)
I think that #define in the process.c vs an empty stub inside
asm/kexec.h is really a style issue. I'm quite ok with things
the way they are. But If you are more comfortable with the stub
approach, I have no objections.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
@ 2007-02-08 2:19 ` Horms
0 siblings, 0 replies; 8+ messages in thread
From: Horms @ 2007-02-08 2:19 UTC (permalink / raw)
To: Luck, Tony
Cc: linux-ia64, linux-kernel, fastboot, Zou, Nanhai, Khalid Aziz,
Adrian Bunk, Andrew Morton, Magnus Damm
On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > declaration of kexec_disable_iosapic() which is used in
> > machine_shutdown().
>
> > +#include <asm/kexec.h>
>
> I merged this into your earlier change (moving machine_shutdown() into
> process.c). Linus pulled it last night.
Thanks
> I also added a "#ifdef CONFIG_KEXEC" around the call to
> kexec_disable_iosapic() (because I first noticed that this was
> undefined when building non-KEXEC kernels). But perhaps it might have
> been better to #define an empty stub for this function inside kexec.h
> for the #ifndef CONFIG_KEXEC case?
Good catch :)
I think that #define in the process.c vs an empty stub inside
asm/kexec.h is really a style issue. I'm quite ok with things
the way they are. But If you are more comfortable with the stub
approach, I have no objections.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
2007-02-08 2:19 ` Horms
@ 2007-02-08 3:27 ` Randy Dunlap
-1 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2007-02-08 3:27 UTC (permalink / raw)
To: Horms
Cc: Luck, Tony, linux-ia64, linux-kernel, fastboot, Zou, Nanhai,
Khalid Aziz, Adrian Bunk, Andrew Morton, Magnus Damm
On Thu, 8 Feb 2007 11:19:03 +0900 Horms wrote:
> On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > > declaration of kexec_disable_iosapic() which is used in
> > > machine_shutdown().
> >
> > > +#include <asm/kexec.h>
> >
> > I merged this into your earlier change (moving machine_shutdown() into
> > process.c). Linus pulled it last night.
>
> Thanks
>
> > I also added a "#ifdef CONFIG_KEXEC" around the call to
> > kexec_disable_iosapic() (because I first noticed that this was
> > undefined when building non-KEXEC kernels). But perhaps it might have
> > been better to #define an empty stub for this function inside kexec.h
> > for the #ifndef CONFIG_KEXEC case?
>
> Good catch :)
uh, every one of Andrew's commit emails now contains the line
at the end of my mail sig... Try it sometimes^W often.
> I think that #define in the process.c vs an empty stub inside
> asm/kexec.h is really a style issue. I'm quite ok with things
> the way they are. But If you are more comfortable with the stub
> approach, I have no objections.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c
@ 2007-02-08 3:27 ` Randy Dunlap
0 siblings, 0 replies; 8+ messages in thread
From: Randy Dunlap @ 2007-02-08 3:27 UTC (permalink / raw)
To: Horms
Cc: Luck, Tony, linux-ia64, linux-kernel, fastboot, Zou, Nanhai,
Khalid Aziz, Adrian Bunk, Andrew Morton, Magnus Damm
On Thu, 8 Feb 2007 11:19:03 +0900 Horms wrote:
> On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote:
> > > kexec.h is needed by arch/ia64/kernel/process.c so for the
> > > declaration of kexec_disable_iosapic() which is used in
> > > machine_shutdown().
> >
> > > +#include <asm/kexec.h>
> >
> > I merged this into your earlier change (moving machine_shutdown() into
> > process.c). Linus pulled it last night.
>
> Thanks
>
> > I also added a "#ifdef CONFIG_KEXEC" around the call to
> > kexec_disable_iosapic() (because I first noticed that this was
> > undefined when building non-KEXEC kernels). But perhaps it might have
> > been better to #define an empty stub for this function inside kexec.h
> > for the #ifndef CONFIG_KEXEC case?
>
> Good catch :)
uh, every one of Andrew's commit emails now contains the line
at the end of my mail sig... Try it sometimes^W often.
> I think that #define in the process.c vs an empty stub inside
> asm/kexec.h is really a style issue. I'm quite ok with things
> the way they are. But If you are more comfortable with the stub
> approach, I have no objections.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2007-02-08 3:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-07 6:49 [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c Horms
2007-02-07 6:49 ` Horms
2007-02-07 17:07 ` Luck, Tony
2007-02-07 17:07 ` Luck, Tony
2007-02-08 2:19 ` Horms
2007-02-08 2:19 ` Horms
2007-02-08 3:27 ` Randy Dunlap
2007-02-08 3:27 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.